From: Dario Faggioli <dario.faggioli@citrix.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Anshul Makkar <anshul.makkar@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 4/4] libxl/xl: allow to get and set cap on Credit2.
Date: Thu, 29 Jun 2017 12:22:29 +0200 [thread overview]
Message-ID: <1498731749.7288.16.camel@citrix.com> (raw)
In-Reply-To: <CAFLBxZbNwK3yRBEdeVWT-yoUaHzm1AUzF=GXLzpaCirqZu7iMw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 791 bytes --]
On Wed, 2017-06-28 at 19:43 +0100, George Dunlap wrote:
> On Thu, Jun 8, 2017 at 1:09 PM, Dario Faggioli
> <dario.faggioli@citrix.com> wrote:
> > Note that a cap is considered valid only if
> > it is within the [1, nr_vcpus]% interval.
>
> Oh, I see you added the check here.
>
Yeah...
> Still, I think we should add a check in the hypervisor too. The
> check
> here should mainly be to give a reasonable error message; we
> shouldn't
> rely on it for safety.
>
...sure, I totally agree.
Will do.
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-06-29 10:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 12:08 [PATCH 0/4] xen/tools: Credit2: implement caps Dario Faggioli
2017-06-08 12:08 ` [PATCH 1/4] xen: credit2: implement utilization cap Dario Faggioli
2017-06-12 11:16 ` Anshul Makkar
2017-06-12 13:19 ` Dario Faggioli
2017-06-13 16:07 ` Anshul Makkar
2017-06-13 21:13 ` Dario Faggioli
2017-06-15 16:16 ` Anshul Makkar
2017-06-22 16:55 ` George Dunlap
2017-06-23 16:19 ` Dario Faggioli
2017-06-28 14:28 ` George Dunlap
2017-06-28 14:56 ` Dario Faggioli
2017-06-28 19:05 ` George Dunlap
2017-06-29 10:09 ` Dario Faggioli
2017-07-25 14:34 ` George Dunlap
2017-07-25 17:29 ` Dario Faggioli
2017-07-25 15:08 ` George Dunlap
2017-07-25 16:05 ` Dario Faggioli
2017-06-08 12:08 ` [PATCH 2/4] xen: credit2: allow to set and get " Dario Faggioli
2017-06-28 15:19 ` George Dunlap
2017-06-29 10:21 ` Dario Faggioli
2017-06-29 7:39 ` Alan Robinson
2017-06-29 8:26 ` George Dunlap
2017-06-08 12:09 ` [PATCH 3/4] xen: credit2: improve distribution of budget (for domains with caps) Dario Faggioli
2017-06-28 16:02 ` George Dunlap
2017-06-08 12:09 ` [PATCH 4/4] libxl/xl: allow to get and set cap on Credit2 Dario Faggioli
2017-06-09 10:41 ` Wei Liu
2017-06-28 18:43 ` George Dunlap
2017-06-29 10:22 ` Dario Faggioli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498731749.7288.16.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=anshul.makkar@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).