* [PATCH-for-4.15] tools/libs/light: fix xl save -c handling
@ 2021-02-19 14:13 Juergen Gross
2021-02-19 14:15 ` Jan Beulich
2021-02-19 17:26 ` Wei Liu
0 siblings, 2 replies; 4+ messages in thread
From: Juergen Gross @ 2021-02-19 14:13 UTC (permalink / raw)
To: xen-devel
Cc: Juergen Gross, Ian Jackson, Wei Liu, Anthony PERARD,
Marek Marczykowski-Górecki
libxl_domain_resume() won't work correctly for the case it was called
due to a "xl save -c" command, i.e. to continue the suspended domain.
The information to do that is not saved in libxl__dm_resume_state for
non-HVM domains.
Fixes: 6298f0eb8f443 ("libxl: Re-introduce libxl__domain_resume")
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/libs/light/libxl_dom_suspend.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/libs/light/libxl_dom_suspend.c b/tools/libs/light/libxl_dom_suspend.c
index 25d1571895..f7823bbc8f 100644
--- a/tools/libs/light/libxl_dom_suspend.c
+++ b/tools/libs/light/libxl_dom_suspend.c
@@ -630,12 +630,13 @@ void libxl__domain_resume(libxl__egc *egc,
goto out;
}
+ dmrs->suspend_cancel = suspend_cancel;
+
if (type != LIBXL_DOMAIN_TYPE_HVM) {
rc = 0;
goto out;
}
- dmrs->suspend_cancel = suspend_cancel;
dmrs->dm_resumed_callback = domain_resume_done;
libxl__dm_resume(egc, dmrs); /* must be last */
return;
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH-for-4.15] tools/libs/light: fix xl save -c handling
2021-02-19 14:13 [PATCH-for-4.15] tools/libs/light: fix xl save -c handling Juergen Gross
@ 2021-02-19 14:15 ` Jan Beulich
2021-02-19 15:01 ` Marek Marczykowski-Górecki
2021-02-19 17:26 ` Wei Liu
1 sibling, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2021-02-19 14:15 UTC (permalink / raw)
To: Juergen Gross
Cc: Ian Jackson, Wei Liu, Anthony PERARD,
Marek Marczykowski-Górecki, xen-devel
On 19.02.2021 15:13, Juergen Gross wrote:
> libxl_domain_resume() won't work correctly for the case it was called
> due to a "xl save -c" command, i.e. to continue the suspended domain.
>
> The information to do that is not saved in libxl__dm_resume_state for
> non-HVM domains.
>
> Fixes: 6298f0eb8f443 ("libxl: Re-introduce libxl__domain_resume")
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH-for-4.15] tools/libs/light: fix xl save -c handling
2021-02-19 14:15 ` Jan Beulich
@ 2021-02-19 15:01 ` Marek Marczykowski-Górecki
0 siblings, 0 replies; 4+ messages in thread
From: Marek Marczykowski-Górecki @ 2021-02-19 15:01 UTC (permalink / raw)
To: Jan Beulich
Cc: Juergen Gross, Ian Jackson, Wei Liu, Anthony PERARD, xen-devel
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On Fri, Feb 19, 2021 at 03:15:52PM +0100, Jan Beulich wrote:
> On 19.02.2021 15:13, Juergen Gross wrote:
> > libxl_domain_resume() won't work correctly for the case it was called
> > due to a "xl save -c" command, i.e. to continue the suspended domain.
> >
> > The information to do that is not saved in libxl__dm_resume_state for
> > non-HVM domains.
> >
> > Fixes: 6298f0eb8f443 ("libxl: Re-introduce libxl__domain_resume")
> > Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> > Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
Works with both xl save and libvirt now.
Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Thanks!
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH-for-4.15] tools/libs/light: fix xl save -c handling
2021-02-19 14:13 [PATCH-for-4.15] tools/libs/light: fix xl save -c handling Juergen Gross
2021-02-19 14:15 ` Jan Beulich
@ 2021-02-19 17:26 ` Wei Liu
1 sibling, 0 replies; 4+ messages in thread
From: Wei Liu @ 2021-02-19 17:26 UTC (permalink / raw)
To: Juergen Gross
Cc: xen-devel, Ian Jackson, Wei Liu, Anthony PERARD,
Marek Marczykowski-Górecki
On Fri, Feb 19, 2021 at 03:13:37PM +0100, Juergen Gross wrote:
> libxl_domain_resume() won't work correctly for the case it was called
> due to a "xl save -c" command, i.e. to continue the suspended domain.
>
> The information to do that is not saved in libxl__dm_resume_state for
> non-HVM domains.
>
> Fixes: 6298f0eb8f443 ("libxl: Re-introduce libxl__domain_resume")
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Wei Liu <wl@xen.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-19 17:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 14:13 [PATCH-for-4.15] tools/libs/light: fix xl save -c handling Juergen Gross
2021-02-19 14:15 ` Jan Beulich
2021-02-19 15:01 ` Marek Marczykowski-Górecki
2021-02-19 17:26 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).