From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>, andrii.anisov@gmail.com
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
xen-devel <xen-devel@lists.xenproject.org>,
"andrii_anisov@epam.com" <andrii_anisov@epam.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2 2/2] xen: implement VCPUOP_register_runstate_phys_memory_area
Date: Tue, 14 May 2019 10:35:40 +0100 [thread overview]
Message-ID: <1c8b7f5f-09d7-6e38-1e78-9528c1f0a756@arm.com> (raw)
In-Reply-To: <5CD3F266020000780022D0F3@prv1-mh.provo.novell.com>
Hi Jan,
On 09/05/2019 10:27, Jan Beulich wrote:
>>>> On 08.05.19 at 17:40, <julien.grall@arm.com> wrote:
>> On 23/04/2019 09:10, Andrii Anisov wrote:
>>> --- a/xen/include/xen/sched.h
>>> +++ b/xen/include/xen/sched.h
>>> @@ -163,15 +163,23 @@ struct vcpu
>>> void *sched_priv; /* scheduler-specific data */
>>>
>>> struct vcpu_runstate_info runstate;
>>> +
>>> + spinlock_t mapped_runstate_lock;
>>> +
>>> #ifndef CONFIG_COMPAT
>>> # define runstate_guest(v) ((v)->runstate_guest)
>>> XEN_GUEST_HANDLE(vcpu_runstate_info_t) runstate_guest; /* guest address */
>>> + vcpu_runstate_info_t *mapped_runstate;
>>> #else
>>> # define runstate_guest(v) ((v)->runstate_guest.native)
>>> union {
>>> XEN_GUEST_HANDLE(vcpu_runstate_info_t) native;
>>> XEN_GUEST_HANDLE(vcpu_runstate_info_compat_t) compat;
>>> } runstate_guest; /* guest address */
>>> + union {
>>> + vcpu_runstate_info_t* native;
>>> + vcpu_runstate_info_compat_t* compat;
>>> + } mapped_runstate; /* guest address */
>>
>> The combination of mapped_runstate and runstate_guest is a bit confusing. I
>> think you want to rework the interface to show that only one is possible at the
>> time and make clear which one is used by who. Maybe:
>>
>> union
>> {
>> /* Legacy interface to be used when the guest provides a virtual address */
>> union {
>> XEN_GUEST_HANDLE(vcpu_runstate_info_t) native;
>> ...
>> } virt;
>>
>> /* Interface used when the guest provides a physical address */
>> union {
>> } phys;
>> } runstate_guest.
>>
>> runstate_guest_type /* could be a bool or enum */
>>
>> Jan what do you think?
>
> I fully agree - no mixing of approaches here, if possible. However,
> care needs to be taken that after a domain reset the new kernel
> can chose the opposite model. Question is whether there are even
> other cases where independent components (say boot loader and
> OS) may need to be permitted to chose models independently of
> one another.
Good point. On a similar topic, how does Kexec works on Xen? Do we reset the
domain as well?
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>, andrii.anisov@gmail.com
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
xen-devel <xen-devel@lists.xenproject.org>,
"andrii_anisov@epam.com" <andrii_anisov@epam.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 2/2] xen: implement VCPUOP_register_runstate_phys_memory_area
Date: Tue, 14 May 2019 10:35:40 +0100 [thread overview]
Message-ID: <1c8b7f5f-09d7-6e38-1e78-9528c1f0a756@arm.com> (raw)
Message-ID: <20190514093540.Ac_Ex_BJaZuGn1Luqf2NbGw_ZYTx18acc3nyYNiEZaw@z> (raw)
In-Reply-To: <5CD3F266020000780022D0F3@prv1-mh.provo.novell.com>
Hi Jan,
On 09/05/2019 10:27, Jan Beulich wrote:
>>>> On 08.05.19 at 17:40, <julien.grall@arm.com> wrote:
>> On 23/04/2019 09:10, Andrii Anisov wrote:
>>> --- a/xen/include/xen/sched.h
>>> +++ b/xen/include/xen/sched.h
>>> @@ -163,15 +163,23 @@ struct vcpu
>>> void *sched_priv; /* scheduler-specific data */
>>>
>>> struct vcpu_runstate_info runstate;
>>> +
>>> + spinlock_t mapped_runstate_lock;
>>> +
>>> #ifndef CONFIG_COMPAT
>>> # define runstate_guest(v) ((v)->runstate_guest)
>>> XEN_GUEST_HANDLE(vcpu_runstate_info_t) runstate_guest; /* guest address */
>>> + vcpu_runstate_info_t *mapped_runstate;
>>> #else
>>> # define runstate_guest(v) ((v)->runstate_guest.native)
>>> union {
>>> XEN_GUEST_HANDLE(vcpu_runstate_info_t) native;
>>> XEN_GUEST_HANDLE(vcpu_runstate_info_compat_t) compat;
>>> } runstate_guest; /* guest address */
>>> + union {
>>> + vcpu_runstate_info_t* native;
>>> + vcpu_runstate_info_compat_t* compat;
>>> + } mapped_runstate; /* guest address */
>>
>> The combination of mapped_runstate and runstate_guest is a bit confusing. I
>> think you want to rework the interface to show that only one is possible at the
>> time and make clear which one is used by who. Maybe:
>>
>> union
>> {
>> /* Legacy interface to be used when the guest provides a virtual address */
>> union {
>> XEN_GUEST_HANDLE(vcpu_runstate_info_t) native;
>> ...
>> } virt;
>>
>> /* Interface used when the guest provides a physical address */
>> union {
>> } phys;
>> } runstate_guest.
>>
>> runstate_guest_type /* could be a bool or enum */
>>
>> Jan what do you think?
>
> I fully agree - no mixing of approaches here, if possible. However,
> care needs to be taken that after a domain reset the new kernel
> can chose the opposite model. Question is whether there are even
> other cases where independent components (say boot loader and
> OS) may need to be permitted to chose models independently of
> one another.
Good point. On a similar topic, how does Kexec works on Xen? Do we reset the
domain as well?
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-14 9:35 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 8:10 [PATCH v2 0/2] Introduce runstate area registration with phys address Andrii Anisov
2019-04-23 8:10 ` [PATCH v2 1/2] xen: introduce VCPUOP_register_runstate_phys_memory_area hypercall Andrii Anisov
2019-04-23 8:10 ` [Xen-devel] " Andrii Anisov
2019-05-08 10:10 ` George Dunlap
2019-05-08 10:10 ` [Xen-devel] " George Dunlap
2019-04-23 8:10 ` [PATCH v2 2/2] xen: implement VCPUOP_register_runstate_phys_memory_area Andrii Anisov
2019-04-23 8:10 ` [Xen-devel] " Andrii Anisov
2019-05-08 15:40 ` Julien Grall
2019-05-08 15:40 ` [Xen-devel] " Julien Grall
2019-05-09 9:27 ` Jan Beulich
2019-05-09 9:27 ` [Xen-devel] " Jan Beulich
2019-05-14 9:35 ` Julien Grall [this message]
2019-05-14 9:35 ` Julien Grall
2019-05-14 9:48 ` Jan Beulich
2019-05-14 9:48 ` [Xen-devel] " Jan Beulich
2019-05-14 11:23 ` Julien Grall
2019-05-14 11:23 ` [Xen-devel] " Julien Grall
2019-05-14 11:29 ` Jan Beulich
2019-05-14 11:29 ` [Xen-devel] " Jan Beulich
2019-05-13 12:30 ` Andrii Anisov
2019-05-13 12:30 ` [Xen-devel] " Andrii Anisov
2019-05-14 9:58 ` Julien Grall
2019-05-14 9:58 ` [Xen-devel] " Julien Grall
2019-05-14 10:08 ` Andrii Anisov
2019-05-14 10:08 ` [Xen-devel] " Andrii Anisov
2019-05-14 11:24 ` Julien Grall
2019-05-14 11:24 ` [Xen-devel] " Julien Grall
2019-05-14 11:45 ` Andrii Anisov
2019-05-14 11:45 ` [Xen-devel] " Andrii Anisov
2019-05-14 12:02 ` Jan Beulich
2019-05-14 12:02 ` [Xen-devel] " Jan Beulich
2019-05-14 13:05 ` Andrii Anisov
2019-05-14 13:05 ` [Xen-devel] " Andrii Anisov
2019-05-14 13:49 ` Julien Grall
2019-05-14 13:49 ` [Xen-devel] " Julien Grall
2019-05-15 9:04 ` Andrii Anisov
2019-05-15 9:04 ` [Xen-devel] " Andrii Anisov
2019-05-15 10:31 ` Julien Grall
2019-05-15 10:31 ` [Xen-devel] " Julien Grall
2019-05-14 13:49 ` Jan Beulich
2019-05-14 13:49 ` [Xen-devel] " Jan Beulich
2019-05-15 8:44 ` Andrii Anisov
2019-05-15 8:44 ` [Xen-devel] " Andrii Anisov
2019-05-15 11:59 ` Jan Beulich
2019-05-15 11:59 ` [Xen-devel] " Jan Beulich
2019-05-16 12:09 ` Jan Beulich
2019-05-16 12:09 ` [Xen-devel] " Jan Beulich
2019-05-16 13:30 ` Andrii Anisov
2019-05-16 13:30 ` [Xen-devel] " Andrii Anisov
2019-05-16 13:30 ` Andrii Anisov
2019-05-16 13:30 ` [Xen-devel] " Andrii Anisov
2019-05-16 13:48 ` Julien Grall
2019-05-16 13:48 ` [Xen-devel] " Julien Grall
2019-05-16 14:25 ` Andrii Anisov
2019-05-16 14:25 ` [Xen-devel] " Andrii Anisov
2019-05-16 14:28 ` Julien Grall
2019-05-16 14:28 ` [Xen-devel] " Julien Grall
2019-05-16 14:29 ` Andrii Anisov
2019-05-16 14:29 ` [Xen-devel] " Andrii Anisov
[not found] ` <fa126315-31af-854e-817a-8640b431c82b@arm.com>
[not found] ` <CAC1WxdiMzAq5hRC-mhRQuFDs7z_Hj5w7VAy52ec87SJQOGmp3w@mail.gmail.com>
[not found] ` <a28f95a1-d9da-2caf-f4b4-013100176b02@arm.com>
[not found] ` <090ce8cc-f329-fe54-4894-b7f12e3cd5a6@gmail.com>
2019-05-08 13:39 ` [PATCH v2 0/2] Introduce runstate area registration with phys address Julien Grall
2019-05-08 13:39 ` [Xen-devel] " Julien Grall
2019-05-08 13:54 ` Andrii Anisov
2019-05-08 13:54 ` [Xen-devel] " Andrii Anisov
2019-05-08 14:31 ` Julien Grall
2019-05-08 14:31 ` [Xen-devel] " Julien Grall
2019-05-08 16:01 ` Andrii Anisov
2019-05-08 16:01 ` [Xen-devel] " Andrii Anisov
2019-05-13 10:50 ` Julien Grall
2019-05-13 10:50 ` [Xen-devel] " Julien Grall
2019-05-13 14:34 ` Andrii Anisov
2019-05-13 14:34 ` [Xen-devel] " Andrii Anisov
2019-05-08 13:59 ` Julien Grall
2019-05-13 10:15 ` Andrii Anisov
2019-05-13 11:16 ` Julien Grall
2019-05-13 14:14 ` Andrii Anisov
2019-05-13 14:34 ` Julien Grall
2019-05-13 15:29 ` Andrii Anisov
2019-05-13 15:31 ` Julien Grall
2019-05-13 15:38 ` Andrii Anisov
2019-05-13 15:40 ` Julien Grall
2019-05-13 15:42 ` Andrii Anisov
2019-05-13 15:45 ` Julien Grall
2019-05-13 16:05 ` Andrii Anisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c8b7f5f-09d7-6e38-1e78-9528c1f0a756@arm.com \
--to=julien.grall@arm.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=andrii.anisov@gmail.com \
--cc=andrii_anisov@epam.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).