* [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()
@ 2016-04-11 12:20 Vitaly Kuznetsov
2016-04-11 12:36 ` Wei Liu
0 siblings, 1 reply; 6+ messages in thread
From: Vitaly Kuznetsov @ 2016-04-11 12:20 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Wei Liu, Wen Congyang, Stefano Stabellini
c/s d5c693d "libxl/save: Refactor libxl__domain_suspend_state" broke soft
reset as libxl__domain_suspend_device_model() now fails when domid in not set
in libxl__domain_suspend_state.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
tools/libxl/libxl_create.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index f1028bc..f8d5e36 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -1700,7 +1700,7 @@ static int do_domain_soft_reset(libxl_ctx *ctx,
free(xs_console_mfn);
dss->ao = ao;
- dss->domid = domid_soft_reset;
+ dss->domid = dss->dsps.domid = domid_soft_reset;
dss->dsps.dm_savefile = GCSPRINTF(LIBXL_DEVICE_MODEL_SAVE_FILE".%d",
domid_soft_reset);
--
2.5.5
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()
2016-04-11 12:20 [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset() Vitaly Kuznetsov
@ 2016-04-11 12:36 ` Wei Liu
2016-04-11 12:53 ` Vitaly Kuznetsov
2016-04-14 17:36 ` Wei Liu
0 siblings, 2 replies; 6+ messages in thread
From: Wei Liu @ 2016-04-11 12:36 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: Ian Jackson, Stefano Stabellini, Wei Liu, Wen Congyang, xen-devel
Sorry for breaking it!
On Mon, Apr 11, 2016 at 02:20:04PM +0200, Vitaly Kuznetsov wrote:
> c/s d5c693d "libxl/save: Refactor libxl__domain_suspend_state" broke soft
> reset as libxl__domain_suspend_device_model() now fails when domid in not set
> in libxl__domain_suspend_state.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
What sort of arrangement is needed to get this tested? Any specific
kernel version etc?
> ---
> tools/libxl/libxl_create.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index f1028bc..f8d5e36 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -1700,7 +1700,7 @@ static int do_domain_soft_reset(libxl_ctx *ctx,
> free(xs_console_mfn);
>
> dss->ao = ao;
> - dss->domid = domid_soft_reset;
> + dss->domid = dss->dsps.domid = domid_soft_reset;
> dss->dsps.dm_savefile = GCSPRINTF(LIBXL_DEVICE_MODEL_SAVE_FILE".%d",
> domid_soft_reset);
>
> --
> 2.5.5
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()
2016-04-11 12:36 ` Wei Liu
@ 2016-04-11 12:53 ` Vitaly Kuznetsov
2016-04-11 13:09 ` Wei Liu
2016-04-14 17:36 ` Wei Liu
1 sibling, 1 reply; 6+ messages in thread
From: Vitaly Kuznetsov @ 2016-04-11 12:53 UTC (permalink / raw)
To: Wei Liu; +Cc: Stefano Stabellini, Ian Jackson, Wen Congyang, xen-devel
Wei Liu <wei.liu2@citrix.com> writes:
> Sorry for breaking it!
>
Np!
> On Mon, Apr 11, 2016 at 02:20:04PM +0200, Vitaly Kuznetsov wrote:
>> c/s d5c693d "libxl/save: Refactor libxl__domain_suspend_state" broke soft
>> reset as libxl__domain_suspend_device_model() now fails when domid in not set
>> in libxl__domain_suspend_state.
>>
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> What sort of arrangement is needed to get this tested? Any specific
> kernel version etc?
>
You need a kernel with the following:
commit 0b34a166f291d255755be46e43ed5497cdd194f2
Author: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: Fri Sep 25 11:59:52 2015 +0200
x86/xen: Support kexec/kdump in HVM guests by doing a soft reset
It is included in upstream kernels starting from 4.5 and a number of
stable kernels.
To smoke test the feature your linux kernel should have KEXEC, in my
.config I see:
CONFIG_KEXEC_CORE=y
CONFIG_KEXEC=y
CONFIG_KEXEC_FILE=y
# CONFIG_KEXEC_VERIFY_SIG is not set
CONFIG_KEXEC_JUMP=y
and then you can simply do:
# kexec -f --reuse-cmdline --initrd /boot/initramfs-`uname -r`.img /boot/vmlinuz-`uname -r`
to experience 'soft reset'. You can also try to do kdump arming for your
kernel and crashing it (with e.g. 'echo c > /proc/sysrq-trigger').
>> ---
>> tools/libxl/libxl_create.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
>> index f1028bc..f8d5e36 100644
>> --- a/tools/libxl/libxl_create.c
>> +++ b/tools/libxl/libxl_create.c
>> @@ -1700,7 +1700,7 @@ static int do_domain_soft_reset(libxl_ctx *ctx,
>> free(xs_console_mfn);
>>
>> dss->ao = ao;
>> - dss->domid = domid_soft_reset;
>> + dss->domid = dss->dsps.domid = domid_soft_reset;
>> dss->dsps.dm_savefile = GCSPRINTF(LIBXL_DEVICE_MODEL_SAVE_FILE".%d",
>> domid_soft_reset);
>>
>> --
>> 2.5.5
>>
--
Vitaly
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()
2016-04-11 12:53 ` Vitaly Kuznetsov
@ 2016-04-11 13:09 ` Wei Liu
0 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2016-04-11 13:09 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: Ian Jackson, xen-devel, Wei Liu, Wen Congyang, Stefano Stabellini
On Mon, Apr 11, 2016 at 02:53:21PM +0200, Vitaly Kuznetsov wrote:
> Wei Liu <wei.liu2@citrix.com> writes:
>
> > Sorry for breaking it!
> >
>
> Np!
>
> > On Mon, Apr 11, 2016 at 02:20:04PM +0200, Vitaly Kuznetsov wrote:
> >> c/s d5c693d "libxl/save: Refactor libxl__domain_suspend_state" broke soft
> >> reset as libxl__domain_suspend_device_model() now fails when domid in not set
> >> in libxl__domain_suspend_state.
> >>
> >> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> >
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> >
> > What sort of arrangement is needed to get this tested? Any specific
> > kernel version etc?
> >
>
> You need a kernel with the following:
>
> commit 0b34a166f291d255755be46e43ed5497cdd194f2
> Author: Vitaly Kuznetsov <vkuznets@redhat.com>
> Date: Fri Sep 25 11:59:52 2015 +0200
>
> x86/xen: Support kexec/kdump in HVM guests by doing a soft reset
>
> It is included in upstream kernels starting from 4.5 and a number of
> stable kernels.
>
> To smoke test the feature your linux kernel should have KEXEC, in my
> .config I see:
>
> CONFIG_KEXEC_CORE=y
> CONFIG_KEXEC=y
> CONFIG_KEXEC_FILE=y
> # CONFIG_KEXEC_VERIFY_SIG is not set
> CONFIG_KEXEC_JUMP=y
>
> and then you can simply do:
> # kexec -f --reuse-cmdline --initrd /boot/initramfs-`uname -r`.img /boot/vmlinuz-`uname -r`
>
> to experience 'soft reset'. You can also try to do kdump arming for your
> kernel and crashing it (with e.g. 'echo c > /proc/sysrq-trigger').
>
Thanks for the instructions.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()
2016-04-11 12:36 ` Wei Liu
2016-04-11 12:53 ` Vitaly Kuznetsov
@ 2016-04-14 17:36 ` Wei Liu
2016-04-15 10:59 ` Ian Jackson
1 sibling, 1 reply; 6+ messages in thread
From: Wei Liu @ 2016-04-14 17:36 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: Ian Jackson, Stefano Stabellini, Wei Liu, Wen Congyang, xen-devel
On Mon, Apr 11, 2016 at 01:36:14PM +0100, Wei Liu wrote:
> Sorry for breaking it!
>
> On Mon, Apr 11, 2016 at 02:20:04PM +0200, Vitaly Kuznetsov wrote:
> > c/s d5c693d "libxl/save: Refactor libxl__domain_suspend_state" broke soft
> > reset as libxl__domain_suspend_device_model() now fails when domid in not set
> > in libxl__domain_suspend_state.
> >
> > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()
2016-04-14 17:36 ` Wei Liu
@ 2016-04-15 10:59 ` Ian Jackson
0 siblings, 0 replies; 6+ messages in thread
From: Ian Jackson @ 2016-04-15 10:59 UTC (permalink / raw)
To: Wei Liu; +Cc: Vitaly Kuznetsov, Stefano Stabellini, Wen Congyang, xen-devel
Wei Liu writes ("Re: [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()"):
> On Mon, Apr 11, 2016 at 01:36:14PM +0100, Wei Liu wrote:
> > Sorry for breaking it!
> >
> > On Mon, Apr 11, 2016 at 02:20:04PM +0200, Vitaly Kuznetsov wrote:
> > > c/s d5c693d "libxl/save: Refactor libxl__domain_suspend_state" broke soft
> > > reset as libxl__domain_suspend_device_model() now fails when domid in not set
> > > in libxl__domain_suspend_state.
> > >
> > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> >
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
> >
>
> Release-acked-by: Wei Liu <wei.liu2@citrix.com>
Queued, thanks.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-15 10:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-11 12:20 [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset() Vitaly Kuznetsov
2016-04-11 12:36 ` Wei Liu
2016-04-11 12:53 ` Vitaly Kuznetsov
2016-04-11 13:09 ` Wei Liu
2016-04-14 17:36 ` Wei Liu
2016-04-15 10:59 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).