xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Paul Durrant <paul.durrant@citrix.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org,
	xen-devel@lists.xenproject.org
Cc: Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul.durrant@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH 07/18] xen: add event channel interface for XenDevice-s
Date: Wed, 21 Nov 2018 15:12:00 +0000	[thread overview]
Message-ID: <20181121151211.15997-8-paul.durrant__7810.47075656733$1542813064$gmane$org@citrix.com> (raw)
In-Reply-To: <20181121151211.15997-1-paul.durrant@citrix.com>

The legacy PV backend infrastructure provides functions to bind, unbind
and send notifications to event channnels. Similar functionality will be
required by XenDevice implementations so this patch adds the necessary
support.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Anthony Perard <anthony.perard@citrix.com>
---
 hw/xen/xen-bus.c         | 84 ++++++++++++++++++++++++++++++++++++++++++++++++
 include/hw/xen/xen-bus.h | 16 +++++++++
 2 files changed, 100 insertions(+)

diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
index 7a152d2a2f..64c8af54b0 100644
--- a/hw/xen/xen-bus.c
+++ b/hw/xen/xen-bus.c
@@ -579,6 +579,65 @@ done:
     g_free(xengnttab_segs);
 }
 
+struct XenEventChannel {
+    unsigned int local_port;
+    XenEventHandler handler;
+    void *opaque;
+    Notifier notifier;
+};
+
+static void event_notify(Notifier *n, void *data)
+{
+    XenEventChannel *channel = container_of(n, XenEventChannel, notifier);
+    unsigned long port = (unsigned long)data;
+
+    if (port == channel->local_port) {
+        channel->handler(channel->opaque);
+    }
+}
+
+XenEventChannel *xen_device_bind_event_channel(XenDevice *xendev,
+                                               unsigned int port,
+                                               XenEventHandler handler,
+                                               void *opaque, Error **errp)
+{
+    XenEventChannel *channel = g_new0(XenEventChannel, 1);
+
+    channel->local_port = xenevtchn_bind_interdomain(xendev->xeh,
+                                                     xendev->frontend_id,
+                                                     port);
+    if (xendev->local_port < 0) {
+        error_setg_errno(errp, errno, "xenevtchn_bind_interdomain failed");
+
+        g_free(channel);
+        return NULL;
+    }
+
+    channel->handler = handler;
+    channel->opaque = opaque;
+    channel->notifier.notify = event_notify;
+
+    notifier_list_add(&xendev->event_notifiers, &channel->notifier);
+
+    return channel;
+}
+
+void xen_device_notify_event_channel(XenDevice *xendev,
+                                     XenEventChannel *channel)
+{
+    xenevtchn_notify(xendev->xeh, channel->local_port);
+}
+
+void xen_device_unbind_event_channel(XenDevice *xendev,
+                                     XenEventChannel *channel)
+{
+    notifier_remove(&channel->notifier);
+
+    xenevtchn_unbind(xendev->xeh, channel->local_port);
+
+    g_free(channel);
+}
+
 static void xen_device_unrealize(DeviceState *dev, Error **errp)
 {
     XenDevice *xendev = XEN_DEVICE(dev);
@@ -602,6 +661,11 @@ static void xen_device_unrealize(DeviceState *dev, Error **errp)
     xen_device_frontend_destroy(xendev);
     xen_device_backend_destroy(xendev);
 
+    if (xendev->xeh) {
+        qemu_set_fd_handler(xenevtchn_fd(xendev->xeh), NULL, NULL, NULL);
+        xenevtchn_close(xendev->xeh);
+    }
+
     if (xendev->xgth) {
         xengnttab_close(xendev->xgth);
     }
@@ -616,6 +680,16 @@ static void xen_device_exit(Notifier *n, void *data)
     xen_device_unrealize(DEVICE(xendev), &error_abort);
 }
 
+static void xen_device_event(void *opaque)
+{
+    XenDevice *xendev = opaque;
+    unsigned long port = xenevtchn_pending(xendev->xeh);
+
+    notifier_list_notify(&xendev->event_notifiers, (void *)port);
+
+    xenevtchn_unmask(xendev->xeh, port);
+}
+
 static void xen_device_realize(DeviceState *dev, Error **errp)
 {
     XenDevice *xendev = XEN_DEVICE(dev);
@@ -656,6 +730,16 @@ static void xen_device_realize(DeviceState *dev, Error **errp)
     xendev->feature_grant_copy =
         (xengnttab_grant_copy(xendev->xgth, 0, NULL) == 0);
 
+    xendev->xeh = xenevtchn_open(NULL, 0);
+    if (!xendev->xeh) {
+        error_setg_errno(errp, errno, "failed xenevtchn_open");
+        goto unrealize;
+    }
+
+    notifier_list_init(&xendev->event_notifiers);
+    qemu_set_fd_handler(xenevtchn_fd(xendev->xeh), xen_device_event, NULL,
+                        xendev);
+
     xen_device_backend_create(xendev, &local_err);
     if (local_err) {
         error_propagate(errp, local_err);
diff --git a/include/hw/xen/xen-bus.h b/include/hw/xen/xen-bus.h
index db14d49027..386f6bfc93 100644
--- a/include/hw/xen/xen-bus.h
+++ b/include/hw/xen/xen-bus.h
@@ -24,6 +24,9 @@ typedef struct XenDevice {
     XenWatch *frontend_state_watch;
     xengnttab_handle *xgth;
     bool feature_grant_copy;
+    xenevtchn_handle *xeh;
+    xenevtchn_port_or_error_t local_port;
+    NotifierList event_notifiers;
 } XenDevice;
 
 typedef char *(*XenDeviceGetName)(XenDevice *xendev, Error **errp);
@@ -102,4 +105,17 @@ void xen_device_copy_grant_refs(XenDevice *xendev, bool to_domain,
                                 XenDeviceGrantCopySegment segs[],
                                 unsigned int nr_segs, Error **errp);
 
+typedef struct XenEventChannel XenEventChannel;
+
+typedef void (*XenEventHandler)(void *opaque);
+
+XenEventChannel *xen_device_bind_event_channel(XenDevice *xendev,
+                                               unsigned int port,
+                                               XenEventHandler handler,
+                                               void *opaque, Error **errp);
+void xen_device_notify_event_channel(XenDevice *xendev,
+                                     XenEventChannel *channel);
+void xen_device_unbind_event_channel(XenDevice *xendev,
+                                     XenEventChannel *channel);
+
 #endif /* HW_XEN_BUS_H */
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-11-21 15:12 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181121151211.15997-1-paul.durrant@citrix.com>
2018-11-21 15:11 ` [PATCH 01/18] xen: re-name XenDevice to XenLegacyDevice Paul Durrant
2018-11-28 16:06   ` Anthony PERARD
2018-11-21 15:11 ` [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Paul Durrant
2018-11-21 15:11 ` [PATCH 03/18] xen: introduce 'xen-qdisk' Paul Durrant
2018-11-21 15:11 ` [PATCH 04/18] xen: create xenstore areas for XenDevice-s Paul Durrant
2018-11-21 15:11 ` [PATCH 05/18] xen: add xenstore watcher infratructure Paul Durrant
2018-11-21 15:11 ` [PATCH 06/18] xen: add grant table interface for XenDevice-s Paul Durrant
2018-12-03 15:45   ` Anthony PERARD
2018-12-05 16:12     ` Paul Durrant
2018-11-21 15:12 ` Paul Durrant [this message]
2018-11-21 15:12 ` [PATCH 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-qdisk.c Paul Durrant
2018-12-03 16:35   ` Anthony PERARD
2018-12-03 16:42     ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 09/18] xen: remove unnecessary code from dataplane/xen-qdisk.c Paul Durrant
2018-12-03 16:58   ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 10/18] xen: add header and build dataplane/xen-qdisk.c Paul Durrant
2018-12-03 18:09   ` Anthony PERARD
     [not found]   ` <20181203180911.GQ14786@perard.uk.xensource.com>
2018-12-05 17:31     ` Paul Durrant
2018-11-21 15:12 ` [PATCH 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-qdisk Paul Durrant
2018-11-21 15:12 ` [PATCH 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-qdisk.c Paul Durrant
2018-12-04 11:34   ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-qdisk.c Paul Durrant
2018-12-04 12:10   ` Anthony PERARD
2018-12-05 17:28     ` Paul Durrant
2018-11-21 15:12 ` [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions Paul Durrant
2018-11-21 15:12 ` [PATCH 15/18] xen: add a mechanism to automatically create XenDevice-s Paul Durrant
2018-12-04 15:35   ` Anthony PERARD
2018-12-06 12:36     ` Paul Durrant
2018-12-06 15:24       ` Anthony PERARD
     [not found]       ` <20181206152406.GC18875@perard.uk.xensource.com>
2018-12-06 15:36         ` Paul Durrant
2018-11-21 15:12 ` [PATCH 16/18] xen: automatically create XenQdiskDevice-s Paul Durrant
2018-11-21 15:12 ` [PATCH 17/18] MAINTAINERS: add myself as a Xen maintainer Paul Durrant
2018-11-27 19:05   ` Stefano Stabellini
2018-11-29 14:00   ` [Qemu-devel] " Philippe Mathieu-Daudé
     [not found]   ` <a247dae0-a766-7f97-c16d-07a32572f35d@redhat.com>
2018-11-29 14:01     ` Paul Durrant
2018-12-04 16:42   ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 18/18] xen: remove the legacy 'xen_disk' backend Paul Durrant
     [not found] ` <20181121151211.15997-3-paul.durrant@citrix.com>
2018-11-28 16:19   ` [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Kevin Wolf
     [not found]   ` <20181128161917.GE4222@dhcp-200-186.str.redhat.com>
2018-11-28 16:26     ` Paul Durrant
2018-11-28 16:28       ` Paul Durrant
2018-11-28 16:28       ` Stefano Stabellini
2018-11-28 16:29         ` Paul Durrant
2018-11-28 16:39           ` Kevin Wolf
2018-11-28 16:45             ` Paul Durrant
     [not found]             ` <5327ba765089439caf8119de49c3a399@AMSPEX02CL03.citrite.net>
2018-11-28 16:46               ` Paul Durrant
2018-11-29  9:04                 ` Kevin Wolf
2018-11-28 17:01       ` [Qemu-devel] " Eric Blake
2018-11-28 17:04         ` Paul Durrant
2018-11-28 17:10   ` Anthony PERARD
2018-11-28 17:17     ` Paul Durrant
2018-11-28 17:32       ` Anthony PERARD
     [not found] ` <20181121151211.15997-4-paul.durrant@citrix.com>
2018-11-29 16:05   ` [PATCH 03/18] xen: introduce 'xen-qdisk' Anthony PERARD
     [not found]   ` <20181129160541.GG14786@perard.uk.xensource.com>
2018-12-04 15:20     ` Paul Durrant
     [not found]     ` <311937f3c787461686f2ebf68a70a326@AMSPEX02CL03.citrite.net>
2018-12-04 15:49       ` Anthony PERARD
     [not found]       ` <20181204154908.GX14786@perard.uk.xensource.com>
2018-12-04 15:50         ` Paul Durrant
2018-12-04 17:14       ` Paul Durrant
     [not found] ` <20181121151211.15997-5-paul.durrant@citrix.com>
2018-11-29 18:48   ` [PATCH 04/18] xen: create xenstore areas for XenDevice-s Anthony PERARD
     [not found]   ` <20181129184841.GJ14786@perard.uk.xensource.com>
2018-12-05 12:05     ` Paul Durrant
     [not found]     ` <589a4488f1ba4e4496775cc06bda291d@AMSPEX02CL03.citrite.net>
2018-12-05 12:43       ` Paul Durrant
     [not found]       ` <d5bf17f689a34e69b9e3b7b92bcfe4fd@AMSPEX02CL03.citrite.net>
2018-12-05 13:58         ` Anthony PERARD
     [not found]         ` <20181205135839.GB1259@perard.uk.xensource.com>
2018-12-05 14:24           ` Paul Durrant
2018-12-05 16:28       ` Anthony PERARD
     [not found] ` <20181121151211.15997-6-paul.durrant@citrix.com>
2018-12-03 14:42   ` [PATCH 05/18] xen: add xenstore watcher infratructure Anthony PERARD
     [not found]   ` <20181203144231.GK14786@perard.uk.xensource.com>
2018-12-05 15:24     ` Paul Durrant
     [not found] ` <20181121151211.15997-8-paul.durrant@citrix.com>
2018-12-03 16:24   ` [PATCH 07/18] xen: add event channel interface for XenDevice-s Anthony PERARD
2018-12-04 14:24     ` Anthony PERARD
2018-12-05 16:16       ` Paul Durrant
     [not found] ` <20181121151211.15997-12-paul.durrant@citrix.com>
2018-12-04 11:05   ` [PATCH 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-qdisk Anthony PERARD
     [not found] ` <20181121151211.15997-15-paul.durrant@citrix.com>
2018-11-28 16:34   ` [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions Kevin Wolf
2018-11-28 16:40     ` Paul Durrant
2018-11-29  9:00       ` Kevin Wolf
     [not found]       ` <20181129090046.GA4797@linux.fritz.box>
2018-11-29  9:33         ` Paul Durrant
     [not found]         ` <bdee6326dd3041f58202220a50abf9c8@AMSPEX02CL03.citrite.net>
2018-11-29 10:46           ` Kevin Wolf
2018-11-29 10:47             ` Paul Durrant
2018-12-04 12:33   ` Anthony PERARD
     [not found]   ` <20181204123349.GU14786@perard.uk.xensource.com>
2018-12-06 12:27     ` Paul Durrant
     [not found] ` <20181121151211.15997-17-paul.durrant@citrix.com>
2018-12-04 16:40   ` [PATCH 16/18] xen: automatically create XenQdiskDevice-s Anthony PERARD
2018-12-06 13:06     ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20181121151211.15997-8-paul.durrant__7810.47075656733$1542813064$gmane$org@citrix.com' \
    --to=paul.durrant@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).