From: Paul Durrant <Paul.Durrant@citrix.com>
To: Paul Durrant <Paul.Durrant@citrix.com>,
Anthony Perard <anthony.perard@citrix.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 04/18] xen: create xenstore areas for XenDevice-s
Date: Wed, 5 Dec 2018 12:43:57 +0000 [thread overview]
Message-ID: <d5bf17f689a34e69b9e3b7b92bcfe4fd__28407.3300114416$1544013766$gmane$org@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <589a4488f1ba4e4496775cc06bda291d@AMSPEX02CL03.citrite.net>
> -----Original Message-----
> From: Qemu-devel [mailto:qemu-devel-
> bounces+paul.durrant=citrix.com@nongnu.org] On Behalf Of Paul Durrant
> Sent: 05 December 2018 12:05
> To: Anthony Perard <anthony.perard@citrix.com>
> Cc: Kevin Wolf <kwolf@redhat.com>; Stefano Stabellini
> <sstabellini@kernel.org>; qemu-block@nongnu.org; qemu-devel@nongnu.org;
> Max Reitz <mreitz@redhat.com>; xen-devel@lists.xenproject.org
> Subject: Re: [Qemu-devel] [PATCH 04/18] xen: create xenstore areas for
> XenDevice-s
>
> > -----Original Message-----
> > From: Anthony PERARD [mailto:anthony.perard@citrix.com]
> > Sent: 29 November 2018 18:49
> > To: Paul Durrant <Paul.Durrant@citrix.com>
> > Cc: qemu-block@nongnu.org; qemu-devel@nongnu.org; xen-
> > devel@lists.xenproject.org; Stefano Stabellini <sstabellini@kernel.org>;
> > Kevin Wolf <kwolf@redhat.com>; Max Reitz <mreitz@redhat.com>
> > Subject: Re: [PATCH 04/18] xen: create xenstore areas for XenDevice-s
> >
> > On Wed, Nov 21, 2018 at 03:11:57PM +0000, Paul Durrant wrote:
> > > This patch adds a new source module, xen-bus-helper.c, which builds on
> > > basic libxenstore primitives to provide functions to create (setting
> > > permissions appropriately) and destroy xenstore areas, and functions
> to
> > > 'printf' and 'scanf' nodes therein. The main xen-bus code then uses
> > > these primitives [1] to initialize and destroy the frontend and
> backend
> > > areas for a XenDevice during realize and unrealize respectively.
> > >
> > > The 'xen-qdisk' implementation is extended with a 'get_name' method
> that
> > > returns the VBD number. This number is reqired to 'name' the xenstore
> >
> > ^ required
> >
>
> Ok.
>
> > > diff --git a/hw/xen/xen-bus-helper.c b/hw/xen/xen-bus-helper.c
> > > new file mode 100644
> > > index 0000000000..d9ee2ed6a0
> > > --- /dev/null
> > > +++ b/hw/xen/xen-bus-helper.c
> > [...]
> > > +void xs_node_destroy(struct xs_handle *xsh, const char *node)
> > > +{
> > > + xs_rm(xsh, XBT_NULL, node);
> >
> > We should check for error, and grab errno.
> >
>
> I'll make all of them fill in an Error *
>
> > > +}
> > > +
> > > +void xs_node_vprintf(struct xs_handle *xsh, const char *node,
> > > + const char *key, const char *fmt, va_list ap)
> > > +{
> > > + char *path, *value;
> > > +
> > > + path = (strlen(node) != 0) ? g_strdup_printf("%s/%s", node, key)
> :
> > > + g_strdup(key);
> >
> > A comment would be helpful to findout how to use that function,
> > especialy the fact that with node="", we write to $key instead of
> > $node/$key.
>
> Ok, I'll add comments into the header.
>
> >
> > > + value = g_strdup_vprintf(fmt, ap);
> >
> > Looks like g_vasprintf() would be better, since it returns the lenght as
> > well.
> >
>
> Yes.
I tried this and it appears not to exist in the version of glib in my environment so I guess I'll stick with g_strdup_printf().
Paul
>
> > > +
> > > + xs_write(xsh, XBT_NULL, path, value, strlen(value));
> >
> > You should check for failures, and grab errno.
> >
> > > + g_free(value);
> > > + g_free(path);
> > > +}
> > > +
> > > +int xs_node_vscanf(struct xs_handle *xsh, const char *node, const
> char
> > *key,
> > > + const char *fmt, va_list ap)
> > > +{
> > > + char *path, *value;
> > > + int rc;
> > > +
> > > + path = (strlen(node) != 0) ? g_strdup_printf("%s/%s", node, key)
> :
> > > + g_strdup(key);
> > > +
> > > + value = xs_read(xsh, XBT_NULL, path, NULL);
> >
> > The xenstore.h isn't clear about failure of this function, it is
> > supposed to return a malloced value. Do we actually need to check if
> value
> > is NULL?
>
> The comment above xs_read() in xs.c is:
>
> /* Get the value of a single file, nul terminated.
> * Returns a malloced value: call free() on it after use.
> * len indicates length in bytes, not including the nul.
> */
>
> and I think we should check it for NULL before passing it to vsscanf().
>
> >
> > > +
> > > + rc = value ? vsscanf(value, fmt, ap) : EOF;
> > > +
> > > + free(value);
> > > + g_free(path);
> > > +
> > > + return rc;
> > > +}
> > > +
> > > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
> > > index dede2d914a..663aa8e117 100644
> > > --- a/hw/xen/xen-bus.c
> > > +++ b/hw/xen/xen-bus.c
> > [...]
> >
> > > +static void xen_device_backend_destroy(XenDevice *xendev)
> > > +{
> > > + XenBus *xenbus = XEN_BUS(qdev_get_parent_bus(DEVICE(xendev)));
> > > +
> > > + if (!xendev->backend_path) {
> > > + return;
> > > + }
> > > +
> > > + g_assert(xenbus->xsh);
> > > +
> > > + xs_node_destroy(xenbus->xsh, xendev->backend_path);
> > > + g_free(xendev->backend_path);
> >
> > It would be nice to also set backend_path to NULL.
> >
>
> Yes, it should be for idempotency.
>
> > > diff --git a/include/hw/xen/xen-bus-helper.h b/include/hw/xen/xen-bus-
> > helper.h
> > > new file mode 100644
> > > index 0000000000..53570650db
> > > --- /dev/null
> > > +++ b/include/hw/xen/xen-bus-helper.h
> > > @@ -0,0 +1,26 @@
> > > +/*
> > > + * Copyright (c) Citrix Systems Inc.
> > > + * All rights reserved.
> > > + */
> > > +
> > > +#ifndef HW_XEN_BUS_HELPER_H
> > > +#define HW_XEN_BUS_HELPER_H
> >
> > That should probably include xen_common.h, to have `enum xenbus_state`,
> > `struct xs_handle`, ..
>
> Ok.
>
> >
> > > +const char *xs_strstate(enum xenbus_state state);
> > > +
> > > +void xs_node_create(struct xs_handle *xsh, const char *node,
> > > + struct xs_permissions perms[],
> > > + unsigned int nr_perms, Error **errp);
> > > +void xs_node_destroy(struct xs_handle *xsh, const char *node);
> > > +
> > > +void xs_node_vprintf(struct xs_handle *xsh, const char *node,
> > > + const char *key, const char *fmt, va_list ap);
> > > +void xs_node_printf(struct xs_handle *xsh, const char *node, const
> char
> > *key,
> > > + const char *fmt, ...);
> >
> > This prototype needs GCC_FMT_ATTR(), that's the printf format
> > __attribute__.
> >
> > > +
> > > +int xs_node_vscanf(struct xs_handle *xsh, const char *node, const
> char
> > *key,
> > > + const char *fmt, va_list ap);
> > > +int xs_node_scanf(struct xs_handle *xsh, const char *node, const char
> > *key,
> > > + const char *fmt, ...);
> >
> > Maybe here as well.
>
> Will do.
>
> Paul
>
> >
> >
> > --
> > Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-12-05 12:44 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181121151211.15997-1-paul.durrant@citrix.com>
2018-11-21 15:11 ` [PATCH 01/18] xen: re-name XenDevice to XenLegacyDevice Paul Durrant
2018-11-28 16:06 ` Anthony PERARD
2018-11-21 15:11 ` [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Paul Durrant
2018-11-21 15:11 ` [PATCH 03/18] xen: introduce 'xen-qdisk' Paul Durrant
2018-11-21 15:11 ` [PATCH 04/18] xen: create xenstore areas for XenDevice-s Paul Durrant
2018-11-21 15:11 ` [PATCH 05/18] xen: add xenstore watcher infratructure Paul Durrant
2018-11-21 15:11 ` [PATCH 06/18] xen: add grant table interface for XenDevice-s Paul Durrant
2018-12-03 15:45 ` Anthony PERARD
2018-12-05 16:12 ` Paul Durrant
2018-11-21 15:12 ` [PATCH 07/18] xen: add event channel " Paul Durrant
2018-11-21 15:12 ` [PATCH 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-qdisk.c Paul Durrant
2018-12-03 16:35 ` Anthony PERARD
2018-12-03 16:42 ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 09/18] xen: remove unnecessary code from dataplane/xen-qdisk.c Paul Durrant
2018-12-03 16:58 ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 10/18] xen: add header and build dataplane/xen-qdisk.c Paul Durrant
2018-12-03 18:09 ` Anthony PERARD
[not found] ` <20181203180911.GQ14786@perard.uk.xensource.com>
2018-12-05 17:31 ` Paul Durrant
2018-11-21 15:12 ` [PATCH 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-qdisk Paul Durrant
2018-11-21 15:12 ` [PATCH 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-qdisk.c Paul Durrant
2018-12-04 11:34 ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-qdisk.c Paul Durrant
2018-12-04 12:10 ` Anthony PERARD
2018-12-05 17:28 ` Paul Durrant
2018-11-21 15:12 ` [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions Paul Durrant
2018-11-21 15:12 ` [PATCH 15/18] xen: add a mechanism to automatically create XenDevice-s Paul Durrant
2018-12-04 15:35 ` Anthony PERARD
2018-12-06 12:36 ` Paul Durrant
2018-12-06 15:24 ` Anthony PERARD
[not found] ` <20181206152406.GC18875@perard.uk.xensource.com>
2018-12-06 15:36 ` Paul Durrant
2018-11-21 15:12 ` [PATCH 16/18] xen: automatically create XenQdiskDevice-s Paul Durrant
2018-11-21 15:12 ` [PATCH 17/18] MAINTAINERS: add myself as a Xen maintainer Paul Durrant
2018-11-27 19:05 ` Stefano Stabellini
2018-11-29 14:00 ` [Qemu-devel] " Philippe Mathieu-Daudé
[not found] ` <a247dae0-a766-7f97-c16d-07a32572f35d@redhat.com>
2018-11-29 14:01 ` Paul Durrant
2018-12-04 16:42 ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 18/18] xen: remove the legacy 'xen_disk' backend Paul Durrant
[not found] ` <20181121151211.15997-3-paul.durrant@citrix.com>
2018-11-28 16:19 ` [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Kevin Wolf
[not found] ` <20181128161917.GE4222@dhcp-200-186.str.redhat.com>
2018-11-28 16:26 ` Paul Durrant
2018-11-28 16:28 ` Paul Durrant
2018-11-28 16:28 ` Stefano Stabellini
2018-11-28 16:29 ` Paul Durrant
2018-11-28 16:39 ` Kevin Wolf
2018-11-28 16:45 ` Paul Durrant
[not found] ` <5327ba765089439caf8119de49c3a399@AMSPEX02CL03.citrite.net>
2018-11-28 16:46 ` Paul Durrant
2018-11-29 9:04 ` Kevin Wolf
2018-11-28 17:01 ` [Qemu-devel] " Eric Blake
2018-11-28 17:04 ` Paul Durrant
2018-11-28 17:10 ` Anthony PERARD
2018-11-28 17:17 ` Paul Durrant
2018-11-28 17:32 ` Anthony PERARD
[not found] ` <20181121151211.15997-4-paul.durrant@citrix.com>
2018-11-29 16:05 ` [PATCH 03/18] xen: introduce 'xen-qdisk' Anthony PERARD
[not found] ` <20181129160541.GG14786@perard.uk.xensource.com>
2018-12-04 15:20 ` Paul Durrant
[not found] ` <311937f3c787461686f2ebf68a70a326@AMSPEX02CL03.citrite.net>
2018-12-04 15:49 ` Anthony PERARD
[not found] ` <20181204154908.GX14786@perard.uk.xensource.com>
2018-12-04 15:50 ` Paul Durrant
2018-12-04 17:14 ` Paul Durrant
[not found] ` <20181121151211.15997-5-paul.durrant@citrix.com>
2018-11-29 18:48 ` [PATCH 04/18] xen: create xenstore areas for XenDevice-s Anthony PERARD
[not found] ` <20181129184841.GJ14786@perard.uk.xensource.com>
2018-12-05 12:05 ` Paul Durrant
[not found] ` <589a4488f1ba4e4496775cc06bda291d@AMSPEX02CL03.citrite.net>
2018-12-05 12:43 ` Paul Durrant [this message]
[not found] ` <d5bf17f689a34e69b9e3b7b92bcfe4fd@AMSPEX02CL03.citrite.net>
2018-12-05 13:58 ` Anthony PERARD
[not found] ` <20181205135839.GB1259@perard.uk.xensource.com>
2018-12-05 14:24 ` Paul Durrant
2018-12-05 16:28 ` Anthony PERARD
[not found] ` <20181121151211.15997-6-paul.durrant@citrix.com>
2018-12-03 14:42 ` [PATCH 05/18] xen: add xenstore watcher infratructure Anthony PERARD
[not found] ` <20181203144231.GK14786@perard.uk.xensource.com>
2018-12-05 15:24 ` Paul Durrant
[not found] ` <20181121151211.15997-8-paul.durrant@citrix.com>
2018-12-03 16:24 ` [PATCH 07/18] xen: add event channel interface for XenDevice-s Anthony PERARD
2018-12-04 14:24 ` Anthony PERARD
2018-12-05 16:16 ` Paul Durrant
[not found] ` <20181121151211.15997-12-paul.durrant@citrix.com>
2018-12-04 11:05 ` [PATCH 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-qdisk Anthony PERARD
[not found] ` <20181121151211.15997-15-paul.durrant@citrix.com>
2018-11-28 16:34 ` [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions Kevin Wolf
2018-11-28 16:40 ` Paul Durrant
2018-11-29 9:00 ` Kevin Wolf
[not found] ` <20181129090046.GA4797@linux.fritz.box>
2018-11-29 9:33 ` Paul Durrant
[not found] ` <bdee6326dd3041f58202220a50abf9c8@AMSPEX02CL03.citrite.net>
2018-11-29 10:46 ` Kevin Wolf
2018-11-29 10:47 ` Paul Durrant
2018-12-04 12:33 ` Anthony PERARD
[not found] ` <20181204123349.GU14786@perard.uk.xensource.com>
2018-12-06 12:27 ` Paul Durrant
[not found] ` <20181121151211.15997-17-paul.durrant@citrix.com>
2018-12-04 16:40 ` [PATCH 16/18] xen: automatically create XenQdiskDevice-s Anthony PERARD
2018-12-06 13:06 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='d5bf17f689a34e69b9e3b7b92bcfe4fd__28407.3300114416$1544013766$gmane$org@AMSPEX02CL03.citrite.net' \
--to=paul.durrant@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).