From: Anthony PERARD <anthony.perard@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-qdisk.c
Date: Tue, 4 Dec 2018 12:10:41 +0000 [thread overview]
Message-ID: <20181204121041.GT14786@perard.uk.xensource.com> (raw)
In-Reply-To: <20181121151211.15997-14-paul.durrant@citrix.com>
On Wed, Nov 21, 2018 at 03:12:06PM +0000, Paul Durrant wrote:
> This is a purely cosmetic patch that purges remaining use of 'blk' and
> 'ioreq' in local function names.
>
> No functional change.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
I don't think it's a good idee to use function names that could be use
elsewhere, don't have a namespace. It makes it more difficult to figure
out which function is called by just searching for the function name.
Could you had a prefix?
Maybe xendisk_ or xen_disk or xen_qdisk or xen_block or ..., so we can
have xendisk_start_request, or xendisk_request_start. I don't have a
preference beside staying away from generic names.
Thanks,
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-12-04 12:11 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181121151211.15997-1-paul.durrant@citrix.com>
2018-11-21 15:11 ` [PATCH 01/18] xen: re-name XenDevice to XenLegacyDevice Paul Durrant
2018-11-28 16:06 ` Anthony PERARD
2018-11-21 15:11 ` [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Paul Durrant
2018-11-21 15:11 ` [PATCH 03/18] xen: introduce 'xen-qdisk' Paul Durrant
2018-11-21 15:11 ` [PATCH 04/18] xen: create xenstore areas for XenDevice-s Paul Durrant
2018-11-21 15:11 ` [PATCH 05/18] xen: add xenstore watcher infratructure Paul Durrant
2018-11-21 15:11 ` [PATCH 06/18] xen: add grant table interface for XenDevice-s Paul Durrant
2018-12-03 15:45 ` Anthony PERARD
2018-12-05 16:12 ` Paul Durrant
2018-11-21 15:12 ` [PATCH 07/18] xen: add event channel " Paul Durrant
2018-11-21 15:12 ` [PATCH 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-qdisk.c Paul Durrant
2018-12-03 16:35 ` Anthony PERARD
2018-12-03 16:42 ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 09/18] xen: remove unnecessary code from dataplane/xen-qdisk.c Paul Durrant
2018-12-03 16:58 ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 10/18] xen: add header and build dataplane/xen-qdisk.c Paul Durrant
2018-12-03 18:09 ` Anthony PERARD
[not found] ` <20181203180911.GQ14786@perard.uk.xensource.com>
2018-12-05 17:31 ` Paul Durrant
2018-11-21 15:12 ` [PATCH 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-qdisk Paul Durrant
2018-11-21 15:12 ` [PATCH 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-qdisk.c Paul Durrant
2018-12-04 11:34 ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-qdisk.c Paul Durrant
2018-12-04 12:10 ` Anthony PERARD [this message]
2018-12-05 17:28 ` Paul Durrant
2018-11-21 15:12 ` [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions Paul Durrant
2018-11-21 15:12 ` [PATCH 15/18] xen: add a mechanism to automatically create XenDevice-s Paul Durrant
2018-12-04 15:35 ` Anthony PERARD
2018-12-06 12:36 ` Paul Durrant
2018-12-06 15:24 ` Anthony PERARD
[not found] ` <20181206152406.GC18875@perard.uk.xensource.com>
2018-12-06 15:36 ` Paul Durrant
2018-11-21 15:12 ` [PATCH 16/18] xen: automatically create XenQdiskDevice-s Paul Durrant
2018-11-21 15:12 ` [PATCH 17/18] MAINTAINERS: add myself as a Xen maintainer Paul Durrant
2018-11-27 19:05 ` Stefano Stabellini
2018-11-29 14:00 ` [Qemu-devel] " Philippe Mathieu-Daudé
[not found] ` <a247dae0-a766-7f97-c16d-07a32572f35d@redhat.com>
2018-11-29 14:01 ` Paul Durrant
2018-12-04 16:42 ` Anthony PERARD
2018-11-21 15:12 ` [PATCH 18/18] xen: remove the legacy 'xen_disk' backend Paul Durrant
[not found] ` <20181121151211.15997-3-paul.durrant@citrix.com>
2018-11-28 16:19 ` [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Kevin Wolf
[not found] ` <20181128161917.GE4222@dhcp-200-186.str.redhat.com>
2018-11-28 16:26 ` Paul Durrant
2018-11-28 16:28 ` Paul Durrant
2018-11-28 16:28 ` Stefano Stabellini
2018-11-28 16:29 ` Paul Durrant
2018-11-28 16:39 ` Kevin Wolf
2018-11-28 16:45 ` Paul Durrant
[not found] ` <5327ba765089439caf8119de49c3a399@AMSPEX02CL03.citrite.net>
2018-11-28 16:46 ` Paul Durrant
2018-11-29 9:04 ` Kevin Wolf
2018-11-28 17:01 ` [Qemu-devel] " Eric Blake
2018-11-28 17:04 ` Paul Durrant
2018-11-28 17:10 ` Anthony PERARD
2018-11-28 17:17 ` Paul Durrant
2018-11-28 17:32 ` Anthony PERARD
[not found] ` <20181121151211.15997-4-paul.durrant@citrix.com>
2018-11-29 16:05 ` [PATCH 03/18] xen: introduce 'xen-qdisk' Anthony PERARD
[not found] ` <20181129160541.GG14786@perard.uk.xensource.com>
2018-12-04 15:20 ` Paul Durrant
[not found] ` <311937f3c787461686f2ebf68a70a326@AMSPEX02CL03.citrite.net>
2018-12-04 15:49 ` Anthony PERARD
[not found] ` <20181204154908.GX14786@perard.uk.xensource.com>
2018-12-04 15:50 ` Paul Durrant
2018-12-04 17:14 ` Paul Durrant
[not found] ` <20181121151211.15997-5-paul.durrant@citrix.com>
2018-11-29 18:48 ` [PATCH 04/18] xen: create xenstore areas for XenDevice-s Anthony PERARD
[not found] ` <20181129184841.GJ14786@perard.uk.xensource.com>
2018-12-05 12:05 ` Paul Durrant
[not found] ` <589a4488f1ba4e4496775cc06bda291d@AMSPEX02CL03.citrite.net>
2018-12-05 12:43 ` Paul Durrant
[not found] ` <d5bf17f689a34e69b9e3b7b92bcfe4fd@AMSPEX02CL03.citrite.net>
2018-12-05 13:58 ` Anthony PERARD
[not found] ` <20181205135839.GB1259@perard.uk.xensource.com>
2018-12-05 14:24 ` Paul Durrant
2018-12-05 16:28 ` Anthony PERARD
[not found] ` <20181121151211.15997-6-paul.durrant@citrix.com>
2018-12-03 14:42 ` [PATCH 05/18] xen: add xenstore watcher infratructure Anthony PERARD
[not found] ` <20181203144231.GK14786@perard.uk.xensource.com>
2018-12-05 15:24 ` Paul Durrant
[not found] ` <20181121151211.15997-8-paul.durrant@citrix.com>
2018-12-03 16:24 ` [PATCH 07/18] xen: add event channel interface for XenDevice-s Anthony PERARD
2018-12-04 14:24 ` Anthony PERARD
2018-12-05 16:16 ` Paul Durrant
[not found] ` <20181121151211.15997-12-paul.durrant@citrix.com>
2018-12-04 11:05 ` [PATCH 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-qdisk Anthony PERARD
[not found] ` <20181121151211.15997-15-paul.durrant@citrix.com>
2018-11-28 16:34 ` [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions Kevin Wolf
2018-11-28 16:40 ` Paul Durrant
2018-11-29 9:00 ` Kevin Wolf
[not found] ` <20181129090046.GA4797@linux.fritz.box>
2018-11-29 9:33 ` Paul Durrant
[not found] ` <bdee6326dd3041f58202220a50abf9c8@AMSPEX02CL03.citrite.net>
2018-11-29 10:46 ` Kevin Wolf
2018-11-29 10:47 ` Paul Durrant
2018-12-04 12:33 ` Anthony PERARD
[not found] ` <20181204123349.GU14786@perard.uk.xensource.com>
2018-12-06 12:27 ` Paul Durrant
[not found] ` <20181121151211.15997-17-paul.durrant@citrix.com>
2018-12-04 16:40 ` [PATCH 16/18] xen: automatically create XenQdiskDevice-s Anthony PERARD
2018-12-06 13:06 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204121041.GT14786@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=paul.durrant@citrix.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=stefanha@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).