From: Olaf Hering <olaf@aepfle.de>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH v1] libxl: add helper function to set device_model_version
Date: Tue, 14 May 2019 12:31:18 +0200 [thread overview]
Message-ID: <20190514123118.6c9ecbf7.olaf@aepfle.de> (raw)
In-Reply-To: <20190514101856.6otetd56n72t42bm@Air-de-Roger>
[-- Attachment #1.1: Type: text/plain, Size: 315 bytes --]
Am Tue, 14 May 2019 12:18:56 +0200
schrieb Roger Pau Monné <roger.pau@citrix.com>:
> Why is it not fine to set the device model version in
> libxl__domain_build_info_setdefault?
Because it receives just build_info, which lacks all the data to decide
if a device type needs a device model or not.
Olaf
[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olaf@aepfle.de>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH v1] libxl: add helper function to set device_model_version
Date: Tue, 14 May 2019 12:31:18 +0200 [thread overview]
Message-ID: <20190514123118.6c9ecbf7.olaf@aepfle.de> (raw)
Message-ID: <20190514103118.syLZowL5tTyhCfrJVSi8-tDlOQm_5zWQ2pNy-2VTMVI@z> (raw)
In-Reply-To: <20190514101856.6otetd56n72t42bm@Air-de-Roger>
[-- Attachment #1.1: Type: text/plain, Size: 315 bytes --]
Am Tue, 14 May 2019 12:18:56 +0200
schrieb Roger Pau Monné <roger.pau@citrix.com>:
> Why is it not fine to set the device model version in
> libxl__domain_build_info_setdefault?
Because it receives just build_info, which lacks all the data to decide
if a device type needs a device model or not.
Olaf
[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-14 10:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 7:27 [PATCH v1] libxl: add helper function to set device_model_version Olaf Hering
2019-05-14 7:27 ` [Xen-devel] " Olaf Hering
2019-05-14 10:18 ` Roger Pau Monné
2019-05-14 10:18 ` [Xen-devel] " Roger Pau Monné
2019-05-14 10:31 ` Olaf Hering [this message]
2019-05-14 10:31 ` Olaf Hering
2019-05-14 10:39 ` Roger Pau Monné
2019-05-14 10:39 ` [Xen-devel] " Roger Pau Monné
2019-05-14 14:32 ` Wei Liu
2019-05-14 14:32 ` [Xen-devel] " Wei Liu
2019-05-15 9:13 ` Olaf Hering
2019-05-15 9:13 ` [Xen-devel] " Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514123118.6c9ecbf7.olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).