From: Wei Liu <wei.liu2@citrix.com> To: "Roger Pau Monné" <roger.pau@citrix.com> Cc: xen-devel@lists.xenproject.org, Olaf Hering <olaf@aepfle.de>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com> Subject: Re: [PATCH v1] libxl: add helper function to set device_model_version Date: Tue, 14 May 2019 15:32:27 +0100 [thread overview] Message-ID: <20190514143227.GG2798@zion.uk.xensource.com> (raw) In-Reply-To: <20190514103907.2fc6pf7p64m3c7fh@Air-de-Roger> On Tue, May 14, 2019 at 12:39:07PM +0200, Roger Pau Monné wrote: > On Tue, May 14, 2019 at 12:31:18PM +0200, Olaf Hering wrote: > > Am Tue, 14 May 2019 12:18:56 +0200 > > schrieb Roger Pau Monné <roger.pau@citrix.com>: > > > > > Why is it not fine to set the device model version in > > > libxl__domain_build_info_setdefault? > > > > Because it receives just build_info, which lacks all the data to decide > > if a device type needs a device model or not. > > Gah, thanks. Could you please add this to the commit message? Or else > it's likely I will ask again. > > With that: > > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> Acked-by: Wei Liu <wei.liu2@citrix.com> Olaf, if you can provide me with an updated version of the commit message I can fold that in while committing. No need to resend this patch. Wei. > > Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Wei Liu <wei.liu2@citrix.com> To: "Roger Pau Monné" <roger.pau@citrix.com> Cc: xen-devel@lists.xenproject.org, Olaf Hering <olaf@aepfle.de>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com> Subject: Re: [Xen-devel] [PATCH v1] libxl: add helper function to set device_model_version Date: Tue, 14 May 2019 15:32:27 +0100 [thread overview] Message-ID: <20190514143227.GG2798@zion.uk.xensource.com> (raw) Message-ID: <20190514143227.09uabRlacGGbgkqsWHqaNwEpWauRujMZELA3YYb7Rxo@z> (raw) In-Reply-To: <20190514103907.2fc6pf7p64m3c7fh@Air-de-Roger> On Tue, May 14, 2019 at 12:39:07PM +0200, Roger Pau Monné wrote: > On Tue, May 14, 2019 at 12:31:18PM +0200, Olaf Hering wrote: > > Am Tue, 14 May 2019 12:18:56 +0200 > > schrieb Roger Pau Monné <roger.pau@citrix.com>: > > > > > Why is it not fine to set the device model version in > > > libxl__domain_build_info_setdefault? > > > > Because it receives just build_info, which lacks all the data to decide > > if a device type needs a device model or not. > > Gah, thanks. Could you please add this to the commit message? Or else > it's likely I will ask again. > > With that: > > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> Acked-by: Wei Liu <wei.liu2@citrix.com> Olaf, if you can provide me with an updated version of the commit message I can fold that in while committing. No need to resend this patch. Wei. > > Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-14 14:32 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-14 7:27 [PATCH v1] libxl: add helper function to set device_model_version Olaf Hering 2019-05-14 7:27 ` [Xen-devel] " Olaf Hering 2019-05-14 10:18 ` Roger Pau Monné 2019-05-14 10:18 ` [Xen-devel] " Roger Pau Monné 2019-05-14 10:31 ` Olaf Hering 2019-05-14 10:31 ` [Xen-devel] " Olaf Hering 2019-05-14 10:39 ` Roger Pau Monné 2019-05-14 10:39 ` [Xen-devel] " Roger Pau Monné 2019-05-14 14:32 ` Wei Liu [this message] 2019-05-14 14:32 ` Wei Liu 2019-05-15 9:13 ` Olaf Hering 2019-05-15 9:13 ` [Xen-devel] " Olaf Hering
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190514143227.GG2798@zion.uk.xensource.com \ --to=wei.liu2@citrix.com \ --cc=ian.jackson@eu.citrix.com \ --cc=olaf@aepfle.de \ --cc=roger.pau@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).