xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair.francis@wdc.com>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
	konrad.wilk@oracle.com, George.Dunlap@eu.citrix.com,
	ian.jackson@eu.citrix.com, tim@xen.org, julien.grall@arm.com,
	Alistair Francis <alistair.francis@wdc.com>,
	jbeulich@suse.com, andrew.cooper3@citrix.com,
	alistair23@gmail.com
Subject: [Xen-devel] [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include
Date: Tue, 21 May 2019 15:24:18 -0700	[thread overview]
Message-ID: <20190521222418.27107-1-alistair.francis@wdc.com> (raw)
Message-ID: <20190521222418.bJSf_iyB57r7uEhGzS81UO8yMrMNN8Ckr-xl1R6f_l4@z> (raw)

The only use of asm/vpl011.h is protected by the CONFIG_SBSA_VUART_CONSOLE
define so lets protect the include as well.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 v3:
  - Rework commit title and message
  - Split it into a seperate ifdef

 xen/drivers/char/console.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 38ecd9c015..d728e737d1 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -36,7 +36,8 @@
 #ifdef CONFIG_X86
 #include <xen/consoled.h>
 #include <asm/guest.h>
-#else
+#endif
+#ifdef CONFIG_SBSA_VUART_CONSOLE
 #include <asm/vpl011.h>
 #endif
 
-- 
2.21.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

             reply	other threads:[~2019-05-21 22:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 22:24 Alistair Francis [this message]
2019-05-21 22:24 ` [Xen-devel] [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include Alistair Francis
2019-05-22  8:41 ` Jan Beulich
2019-05-22  8:41   ` [Xen-devel] " Jan Beulich
2019-05-22 20:24 ` Stefano Stabellini
2019-05-22 20:24   ` [Xen-devel] " Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521222418.27107-1-alistair.francis@wdc.com \
    --to=alistair.francis@wdc.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=alistair23@gmail.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).