* [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include
@ 2019-05-21 22:24 Alistair Francis
2019-05-21 22:24 ` [Xen-devel] " Alistair Francis
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alistair Francis @ 2019-05-21 22:24 UTC (permalink / raw)
To: xen-devel
Cc: sstabellini, wei.liu2, konrad.wilk, George.Dunlap, ian.jackson,
tim, julien.grall, Alistair Francis, jbeulich, andrew.cooper3,
alistair23
The only use of asm/vpl011.h is protected by the CONFIG_SBSA_VUART_CONSOLE
define so lets protect the include as well.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
v3:
- Rework commit title and message
- Split it into a seperate ifdef
xen/drivers/char/console.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 38ecd9c015..d728e737d1 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -36,7 +36,8 @@
#ifdef CONFIG_X86
#include <xen/consoled.h>
#include <asm/guest.h>
-#else
+#endif
+#ifdef CONFIG_SBSA_VUART_CONSOLE
#include <asm/vpl011.h>
#endif
--
2.21.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Xen-devel] [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include
2019-05-21 22:24 [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include Alistair Francis
@ 2019-05-21 22:24 ` Alistair Francis
2019-05-22 8:41 ` Jan Beulich
2019-05-22 20:24 ` Stefano Stabellini
2 siblings, 0 replies; 6+ messages in thread
From: Alistair Francis @ 2019-05-21 22:24 UTC (permalink / raw)
To: xen-devel
Cc: sstabellini, wei.liu2, konrad.wilk, George.Dunlap, ian.jackson,
tim, julien.grall, Alistair Francis, jbeulich, andrew.cooper3,
alistair23
The only use of asm/vpl011.h is protected by the CONFIG_SBSA_VUART_CONSOLE
define so lets protect the include as well.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
v3:
- Rework commit title and message
- Split it into a seperate ifdef
xen/drivers/char/console.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 38ecd9c015..d728e737d1 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -36,7 +36,8 @@
#ifdef CONFIG_X86
#include <xen/consoled.h>
#include <asm/guest.h>
-#else
+#endif
+#ifdef CONFIG_SBSA_VUART_CONSOLE
#include <asm/vpl011.h>
#endif
--
2.21.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include
2019-05-21 22:24 [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include Alistair Francis
2019-05-21 22:24 ` [Xen-devel] " Alistair Francis
@ 2019-05-22 8:41 ` Jan Beulich
2019-05-22 8:41 ` [Xen-devel] " Jan Beulich
2019-05-22 20:24 ` Stefano Stabellini
2 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2019-05-22 8:41 UTC (permalink / raw)
To: Alistair Francis
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, xen-devel, alistair23
>>> On 22.05.19 at 00:24, <alistair.francis@wdc.com> wrote:
> The only use of asm/vpl011.h is protected by the CONFIG_SBSA_VUART_CONSOLE
> define so lets protect the include as well.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include
2019-05-22 8:41 ` Jan Beulich
@ 2019-05-22 8:41 ` Jan Beulich
0 siblings, 0 replies; 6+ messages in thread
From: Jan Beulich @ 2019-05-22 8:41 UTC (permalink / raw)
To: Alistair Francis
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, xen-devel, alistair23
>>> On 22.05.19 at 00:24, <alistair.francis@wdc.com> wrote:
> The only use of asm/vpl011.h is protected by the CONFIG_SBSA_VUART_CONSOLE
> define so lets protect the include as well.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include
2019-05-21 22:24 [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include Alistair Francis
2019-05-21 22:24 ` [Xen-devel] " Alistair Francis
2019-05-22 8:41 ` Jan Beulich
@ 2019-05-22 20:24 ` Stefano Stabellini
2019-05-22 20:24 ` [Xen-devel] " Stefano Stabellini
2 siblings, 1 reply; 6+ messages in thread
From: Stefano Stabellini @ 2019-05-22 20:24 UTC (permalink / raw)
To: Alistair Francis
Cc: sstabellini, wei.liu2, konrad.wilk, George.Dunlap, ian.jackson,
tim, alistair23, julien.grall, jbeulich, andrew.cooper3,
xen-devel
On Tue, 21 May 2019, Alistair Francis wrote:
> The only use of asm/vpl011.h is protected by the CONFIG_SBSA_VUART_CONSOLE
> define so lets protect the include as well.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> v3:
> - Rework commit title and message
> - Split it into a seperate ifdef
>
> xen/drivers/char/console.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
> index 38ecd9c015..d728e737d1 100644
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -36,7 +36,8 @@
> #ifdef CONFIG_X86
> #include <xen/consoled.h>
> #include <asm/guest.h>
> -#else
> +#endif
> +#ifdef CONFIG_SBSA_VUART_CONSOLE
> #include <asm/vpl011.h>
> #endif
>
> --
> 2.21.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include
2019-05-22 20:24 ` Stefano Stabellini
@ 2019-05-22 20:24 ` Stefano Stabellini
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Stabellini @ 2019-05-22 20:24 UTC (permalink / raw)
To: Alistair Francis
Cc: sstabellini, wei.liu2, konrad.wilk, George.Dunlap, ian.jackson,
tim, alistair23, julien.grall, jbeulich, andrew.cooper3,
xen-devel
On Tue, 21 May 2019, Alistair Francis wrote:
> The only use of asm/vpl011.h is protected by the CONFIG_SBSA_VUART_CONSOLE
> define so lets protect the include as well.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> v3:
> - Rework commit title and message
> - Split it into a seperate ifdef
>
> xen/drivers/char/console.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
> index 38ecd9c015..d728e737d1 100644
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -36,7 +36,8 @@
> #ifdef CONFIG_X86
> #include <xen/consoled.h>
> #include <asm/guest.h>
> -#else
> +#endif
> +#ifdef CONFIG_SBSA_VUART_CONSOLE
> #include <asm/vpl011.h>
> #endif
>
> --
> 2.21.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-22 20:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 22:24 [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include Alistair Francis
2019-05-21 22:24 ` [Xen-devel] " Alistair Francis
2019-05-22 8:41 ` Jan Beulich
2019-05-22 8:41 ` [Xen-devel] " Jan Beulich
2019-05-22 20:24 ` Stefano Stabellini
2019-05-22 20:24 ` [Xen-devel] " Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).