From: Wei Liu <wl@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Wei Liu" <liuwe@microsoft.com>, "Wei Liu" <wl@xen.org>,
"Paul Durrant" <paul@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Michael Kelley" <mikelley@microsoft.com>,
"Xen Development List" <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v3 2/5] x86/hyperv: provide Hyper-V hypercall functions
Date: Tue, 7 Jan 2020 16:21:08 +0000 [thread overview]
Message-ID: <20200107162108.ucmszmuin4ky2vog@debian> (raw)
In-Reply-To: <f6f79ad5-4d71-d4fd-7ee6-4f2e7c4aba71@suse.com>
On Mon, Jan 06, 2020 at 10:38:23AM +0100, Jan Beulich wrote:
[...]
> > +
> > +static inline uint64_t hv_do_rep_hypercall(uint16_t code, uint16_t rep_count,
> > + uint16_t varhead_size,
> > + paddr_t input, paddr_t output)
> > +{
> > + uint64_t control = code;
> > + uint64_t status;
> > + uint16_t rep_comp;
> > +
> > + control |= (uint64_t)varhead_size << HV_HYPERCALL_VARHEAD_OFFSET;
> > + control |= (uint64_t)rep_count << HV_HYPERCALL_REP_COMP_OFFSET;
> > +
> > + do {
> > + status = hv_do_hypercall(control, input, output);
> > + if ( (status & HV_HYPERCALL_RESULT_MASK) != HV_STATUS_SUCCESS )
> > + break;
> > +
> > + rep_comp = (status & HV_HYPERCALL_REP_COMP_MASK) >>
> > + HV_HYPERCALL_REP_COMP_OFFSET;
>
> MASK_EXTR()? (I then also wonder whether MASK_INSR() would better be
> used with some of the other constructs here.)
Sure, I can see if that can be used.
>
> What's worse though - looking at the definition of
> HV_HYPERCALL_REP_COMP_MASK I notice that it and a few others use
> GENMASK_ULL(), when it was clearly said during review (perhaps of
> another but related patch) that this macro should not be used
> outside of Arm-specific code until it gets put into better shape:
> https://lists.xenproject.org/archives/html/xen-devel/2019-12/msg00705.html
That's a straight import from Linux. I only made the header build
without further inspection.
That can be fixed, of course.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-07 16:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 16:47 [Xen-devel] [PATCH v3 0/5] More Hyper-V infrastructure Wei Liu
2020-01-05 16:47 ` [Xen-devel] [PATCH v3 1/5] x86/hyperv: setup hypercall page Wei Liu
2020-01-05 17:37 ` Andrew Cooper
2020-01-05 21:45 ` Wei Liu
2020-01-05 21:57 ` Andrew Cooper
2020-01-07 15:42 ` Wei Liu
2020-01-08 17:43 ` Wei Liu
2020-01-08 17:53 ` Andrew Cooper
2020-01-09 13:48 ` Wei Liu
2020-01-05 16:47 ` [Xen-devel] [PATCH v3 2/5] x86/hyperv: provide Hyper-V hypercall functions Wei Liu
2020-01-05 19:08 ` Andrew Cooper
2020-01-05 21:22 ` Wei Liu
2020-01-05 22:06 ` Andrew Cooper
2020-01-07 16:17 ` Wei Liu
2020-01-16 19:14 ` Andrew Cooper
2020-01-16 14:54 ` Wei Liu
2020-01-06 9:38 ` Jan Beulich
2020-01-07 16:21 ` Wei Liu [this message]
2020-01-05 16:47 ` [Xen-devel] [PATCH v3 3/5] x86/hyperv: provide percpu hypercall input page Wei Liu
2020-01-06 10:27 ` Jan Beulich
2020-01-07 16:33 ` Wei Liu
2020-01-07 16:45 ` Michael Kelley
2020-01-08 10:57 ` Jan Beulich
2020-01-07 17:08 ` Jan Beulich
2020-01-07 17:27 ` Wei Liu
2020-01-08 10:55 ` Jan Beulich
2020-01-08 15:54 ` Wei Liu
2020-01-05 16:48 ` [Xen-devel] [PATCH v3 4/5] x86/hyperv: retrieve vp_index from Hyper-V Wei Liu
2020-01-06 9:59 ` Paul Durrant
2020-01-06 10:31 ` Jan Beulich
2020-01-07 16:34 ` Wei Liu
2020-01-05 16:48 ` [Xen-devel] [PATCH v3 5/5] x86/hyperv: setup VP assist page Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107162108.ucmszmuin4ky2vog@debian \
--to=wl@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=liuwe@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).