From: Jan Beulich <jbeulich@suse.com>
To: Wei Liu <wl@xen.org>
Cc: "Wei Liu" <liuwe@microsoft.com>, "Paul Durrant" <paul@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Michael Kelley" <mikelley@microsoft.com>,
"Xen Development List" <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v3 4/5] x86/hyperv: retrieve vp_index from Hyper-V
Date: Mon, 6 Jan 2020 11:31:50 +0100 [thread overview]
Message-ID: <775b79b4-4b12-62ad-63c3-04cc8179256c@suse.com> (raw)
In-Reply-To: <20200105164801.26278-5-liuwe@microsoft.com>
On 05.01.2020 17:48, Wei Liu wrote:
> --- a/xen/include/asm-x86/guest/hyperv.h
> +++ b/xen/include/asm-x86/guest/hyperv.h
> @@ -66,6 +66,7 @@ struct ms_hyperv_info {
> extern struct ms_hyperv_info ms_hyperv;
>
> DECLARE_PER_CPU(void *, hv_pcpu_input_arg);
> +DECLARE_PER_CPU(unsigned int, hv_vp_index);
Same question here - will this need to be visible outside of the
file defining the variable? In the other patch as well as here,
if the answer is yes, the next question would be whether it needs
to be visible outside of xen/arch/x86/guest/hyperv/ (i.e. whether
it shouldn't live in a private header).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-06 10:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 16:47 [Xen-devel] [PATCH v3 0/5] More Hyper-V infrastructure Wei Liu
2020-01-05 16:47 ` [Xen-devel] [PATCH v3 1/5] x86/hyperv: setup hypercall page Wei Liu
2020-01-05 17:37 ` Andrew Cooper
2020-01-05 21:45 ` Wei Liu
2020-01-05 21:57 ` Andrew Cooper
2020-01-07 15:42 ` Wei Liu
2020-01-08 17:43 ` Wei Liu
2020-01-08 17:53 ` Andrew Cooper
2020-01-09 13:48 ` Wei Liu
2020-01-05 16:47 ` [Xen-devel] [PATCH v3 2/5] x86/hyperv: provide Hyper-V hypercall functions Wei Liu
2020-01-05 19:08 ` Andrew Cooper
2020-01-05 21:22 ` Wei Liu
2020-01-05 22:06 ` Andrew Cooper
2020-01-07 16:17 ` Wei Liu
2020-01-16 19:14 ` Andrew Cooper
2020-01-16 14:54 ` Wei Liu
2020-01-06 9:38 ` Jan Beulich
2020-01-07 16:21 ` Wei Liu
2020-01-05 16:47 ` [Xen-devel] [PATCH v3 3/5] x86/hyperv: provide percpu hypercall input page Wei Liu
2020-01-06 10:27 ` Jan Beulich
2020-01-07 16:33 ` Wei Liu
2020-01-07 16:45 ` Michael Kelley
2020-01-08 10:57 ` Jan Beulich
2020-01-07 17:08 ` Jan Beulich
2020-01-07 17:27 ` Wei Liu
2020-01-08 10:55 ` Jan Beulich
2020-01-08 15:54 ` Wei Liu
2020-01-05 16:48 ` [Xen-devel] [PATCH v3 4/5] x86/hyperv: retrieve vp_index from Hyper-V Wei Liu
2020-01-06 9:59 ` Paul Durrant
2020-01-06 10:31 ` Jan Beulich [this message]
2020-01-07 16:34 ` Wei Liu
2020-01-05 16:48 ` [Xen-devel] [PATCH v3 5/5] x86/hyperv: setup VP assist page Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=775b79b4-4b12-62ad-63c3-04cc8179256c@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=liuwe@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).