From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com> To: Rich Persaud <persaur@gmail.com> Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xenproject.org Subject: Re: [Xen-devel] [PATCH v4 11/16] tools: add simple vchan-socket-proxy Date: Fri, 17 Jan 2020 19:56:39 +0100 Message-ID: <20200117185639.GA1314@mail-itl> (raw) In-Reply-To: <887B9537-ABB7-459E-9E99-50AD4DDDBFE2@gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 1327 bytes --] On Fri, Jan 17, 2020 at 01:44:20PM -0500, Rich Persaud wrote: > On Jan 14, 2020, at 21:42, Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> wrote: > > @@ -66,6 +70,7 @@ install: all > > $(INSTALL_PROG) libxenvchan.so.$(MAJOR).$(MINOR) $(DESTDIR)$(libdir) > > ln -sf libxenvchan.so.$(MAJOR).$(MINOR) $(DESTDIR)$(libdir)/libxenvchan.so.$(MAJOR) > > ln -sf libxenvchan.so.$(MAJOR) $(DESTDIR)$(libdir)/libxenvchan.so > > + $(INSTALL_PROG) vchan-socket-proxy $(DESTDIR)$(bindir) > > Does this need directory creation, to avoid vchan binary being named "bin"? > + $(INSTALL_DIR) $(DESTDIR)$(bindir) I guess it depends on makefile execution order. I'll add it to be on the safe side. > > +int main(int argc, char **argv) > > +{ > > + int is_server = 0; > > + int socket_fd; > > When compiled for OpenEmbedded / OpenXT, gcc complained about socket_fd being uninitialized before possible use. I think gcc is wrong here - in all the paths socket_fd is used, it is initialized under the same conditions (socket_path != "-" and !is_server). But I'll add initializer to mute this warning. -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 157 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply index Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-15 2:39 [Xen-devel] [PATCH v4 00/16] Add support for qemu-xen runnning in a Linux-based stubdomain Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 01/16] Document ioemu MiniOS stubdomain protocol Marek Marczykowski-Górecki 2020-01-20 18:30 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 02/16] Document ioemu Linux " Marek Marczykowski-Górecki 2020-01-20 18:54 ` Jason Andryuk 2020-01-21 21:08 ` Marek Marczykowski-Górecki 2020-01-22 14:04 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 03/16] libxl: fix qemu-trad cmdline for no sdl/vnc case Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 04/16] libxl: Allow running qemu-xen in stubdomain Marek Marczykowski-Górecki 2020-01-20 18:56 ` Jason Andryuk 2020-01-21 21:12 ` Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 05/16] libxl: Handle Linux stubdomain specific QEMU options Marek Marczykowski-Górecki 2020-01-20 19:24 ` Jason Andryuk 2020-01-21 21:18 ` Marek Marczykowski-Górecki 2020-01-22 14:25 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 06/16] libxl: write qemu arguments into separate xenstore keys Marek Marczykowski-Górecki 2020-01-20 19:36 ` Jason Andryuk 2020-01-21 21:19 ` Marek Marczykowski-Górecki 2020-01-22 14:39 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 07/16] xl: add stubdomain related options to xl config parser Marek Marczykowski-Górecki 2020-01-20 19:41 ` Jason Andryuk 2020-01-21 21:22 ` Marek Marczykowski-Górecki 2020-01-22 14:39 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 08/16] tools/libvchan: notify server when client is connected Marek Marczykowski-Górecki 2020-01-20 19:44 ` Jason Andryuk 2020-01-21 21:28 ` Marek Marczykowski-Górecki 2020-01-22 14:43 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 09/16] libxl: add save/restore support for qemu-xen in stubdomain Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 10/16] tools: add missing libxenvchan cflags Marek Marczykowski-Górecki 2020-01-20 19:58 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 11/16] tools: add simple vchan-socket-proxy Marek Marczykowski-Górecki 2020-01-15 11:02 ` Jan Beulich 2020-01-16 17:11 ` Marek Marczykowski-Górecki 2020-01-17 8:13 ` Jan Beulich 2020-01-17 18:44 ` Rich Persaud 2020-01-17 18:56 ` Marek Marczykowski-Górecki [this message] 2020-01-21 19:43 ` Jason Andryuk 2020-01-21 23:09 ` Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 12/16] libxl: use vchan for QMP access with Linux stubdomain Marek Marczykowski-Górecki 2020-01-21 20:17 ` Jason Andryuk 2020-01-21 23:46 ` Marek Marczykowski-Górecki 2020-01-24 14:05 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 13/16] Regenerate autotools files Marek Marczykowski-Górecki 2020-01-15 21:57 ` Rich Persaud 2020-01-21 20:56 ` Marek Marczykowski-Górecki 2020-01-21 21:28 ` Rich Persaud 2020-01-22 8:57 ` Lars Kurth 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 14/16] libxl: require qemu in dom0 even if stubdomain is in use Marek Marczykowski-Górecki 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 15/16] libxl: ignore emulated IDE disks beyond the first 4 Marek Marczykowski-Górecki 2020-01-21 20:24 ` Jason Andryuk 2020-01-15 2:39 ` [Xen-devel] [PATCH v4 16/16] libxl: consider also qemu in stubdomain in libxl__dm_active check Marek Marczykowski-Górecki 2020-01-21 20:25 ` Jason Andryuk 2020-01-22 16:50 ` [Xen-devel] [PATCH v4 00/16] Add support for qemu-xen runnning in a Linux-based stubdomain Jason Andryuk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200117185639.GA1314@mail-itl \ --to=marmarek@invisiblethingslab.com \ --cc=Andrew.Cooper3@citrix.com \ --cc=George.Dunlap@eu.citrix.com \ --cc=Ian.Jackson@eu.citrix.com \ --cc=JBeulich@suse.com \ --cc=julien@xen.org \ --cc=konrad.wilk@oracle.com \ --cc=persaur@gmail.com \ --cc=sstabellini@kernel.org \ --cc=wl@xen.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Xen-Devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \ xen-devel@lists.xenproject.org xen-devel@lists.xen.org public-inbox-index xen-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git