From: Andrew Cooper <andrew.cooper3@citrix.com> To: Xen-devel <xen-devel@lists.xenproject.org> Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>, "Jan Beulich" <JBeulich@suse.com>, "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org> Subject: [PATCH 2/7] x86/shim: Fix compilation at -Og Date: Mon, 19 Apr 2021 15:01:27 +0100 [thread overview] Message-ID: <20210419140132.16909-3-andrew.cooper3@citrix.com> (raw) In-Reply-To: <20210419140132.16909-1-andrew.cooper3@citrix.com> When compiling at -Og: shim.c: In function ‘write_start_info’: shim.c:288:22: error: ‘param’ may be used uninitialized in this function[-Werror=maybe-uninitialized] si->store_evtchn = param; ~~~~~~~~~~~~~~~~~^~~~~~~ and a slew of knock-on failures. All are caused by xen_hypercall_hvm_get_param(), and presumably insufficient analysis to observe that *value is always written on the ret=0 path. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Jan Beulich <JBeulich@suse.com> CC: Roger Pau Monné <roger.pau@citrix.com> CC: Wei Liu <wl@xen.org> --- xen/arch/x86/pv/shim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c index d16c0048c0..a05aaa7bcc 100644 --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -282,7 +282,7 @@ static void write_start_info(struct domain *d) struct cpu_user_regs *regs = guest_cpu_user_regs(); start_info_t *si = map_domain_page(_mfn(is_pv_32bit_domain(d) ? regs->edx : regs->rdx)); - uint64_t param; + uint64_t param = 0; snprintf(si->magic, sizeof(si->magic), "xen-3.0-x86_%s", is_pv_32bit_domain(d) ? "32p" : "64"); @@ -311,8 +311,8 @@ int pv_shim_shutdown(uint8_t reason) struct domain *d = current->domain; struct vcpu *v; unsigned int i; - uint64_t old_store_pfn, old_console_pfn = 0, store_pfn, console_pfn; - uint64_t store_evtchn, console_evtchn; + uint64_t old_store_pfn = 0, old_console_pfn = 0, store_pfn = 0, console_pfn = 0; + uint64_t store_evtchn = 0, console_evtchn = 0; long rc; if ( reason != SHUTDOWN_suspend ) -- 2.11.0
next prev parent reply other threads:[~2021-04-19 14:02 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-19 14:01 [PATCH 0/7] xen: Switch to using -Og for debug builds Andrew Cooper 2021-04-19 14:01 ` [PATCH 1/7] xen/arm: Make make_cpus_node() compile at -Og Andrew Cooper 2021-04-22 18:20 ` Julien Grall 2021-04-19 14:01 ` Andrew Cooper [this message] 2021-04-19 14:01 ` [PATCH 3/7] x86/sysctl: Make arch_do_sysctl() " Andrew Cooper 2021-04-19 14:01 ` [PATCH 4/7] x86/irq: Make create_irq() " Andrew Cooper 2021-04-19 14:01 ` [PATCH 5/7] xen/efi: Make efi_start() " Andrew Cooper 2021-04-19 14:01 ` [PATCH 6/7] x86/shadow: Make _shadow_prealloc() " Andrew Cooper 2021-04-22 7:52 ` Tim Deegan 2021-04-19 14:01 ` [PATCH 7/7] xen: Use -Og for debug builds when available Andrew Cooper 2021-04-19 15:45 ` [PATCH 0/7] xen: Switch to using -Og for debug builds Jan Beulich 2021-04-21 9:31 ` Andrew Cooper 2021-04-21 9:51 ` Jan Beulich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210419140132.16909-3-andrew.cooper3@citrix.com \ --to=andrew.cooper3@citrix.com \ --cc=JBeulich@suse.com \ --cc=roger.pau@citrix.com \ --cc=wl@xen.org \ --cc=xen-devel@lists.xenproject.org \ --subject='Re: [PATCH 2/7] x86/shim: Fix compilation at -Og' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).