From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Bobby Eshleman <bobbyeshleman@gmail.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>
Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console
Date: Fri, 6 Jan 2023 17:16:31 +0000 [thread overview]
Message-ID: <320cc1b3-f03f-ad87-205f-d3c5db446f7d@citrix.com> (raw)
In-Reply-To: <Y6FUy/F0mbrvRP3e@bullseye>
On 20/12/2022 6:23 am, Bobby Eshleman wrote:
> On Fri, Jan 06, 2023 at 03:14:25PM +0200, Oleksii Kurochko wrote:
>> The patch introduce sbi_putchar() SBI call which is necessary
>> to implement initial early_printk
>>
> I think that it might be wise to start off with an alternative to
> sbi_putchar() since it is already planned for deprecation. I realize
> that this will require rework, but it is almost guaranteed that
> early_printk() will break on future SBI implementations if using this
> SBI call. IIRC, Xen/ARM's early printk looked like a reasonable analogy
> for how it could work on RISC-V, IMHO.
Hmm, we're using it as a stopgap right now in CI so we can break
"upstream RISC-V support" into manageable chunks.
So perhaps we want to forgo plumbing sbi_putchar() into early_printk()
(to avoid giving the impression that this will stay around in the
future) and use sbi_putchar() directly for the hello world print.
Next, we focus on getting the real uart driver working along with real
printk (rather than focusing on exceptions which was going to be the
next task), and we can drop sbi_putchar() entirely.
Thoughts?
~Andrew
next prev parent reply other threads:[~2023-01-06 17:17 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 13:14 [PATCH v1 0/8] Basic early_printk and smoke test implementation Oleksii Kurochko
2023-01-06 13:14 ` [PATCH v1 1/8] xen/riscv: introduce dummy asm/init.h Oleksii Kurochko
2023-01-06 13:42 ` Julien Grall
2023-01-09 8:53 ` Oleksii
2023-01-06 13:14 ` [PATCH v1 2/8] xen/riscv: introduce asm/types.h header file Oleksii Kurochko
2023-01-06 14:12 ` Jan Beulich
2023-01-09 8:55 ` Oleksii
2023-01-06 13:14 ` [PATCH v1 3/8] xen/riscv: introduce stack stuff Oleksii Kurochko
2023-01-06 13:54 ` Julien Grall
2023-01-09 9:00 ` Oleksii
2023-01-06 14:15 ` Jan Beulich
2023-01-09 8:57 ` Oleksii
2023-01-06 14:55 ` Andrew Cooper
2023-01-06 13:14 ` [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Oleksii Kurochko
2022-12-20 6:23 ` Bobby Eshleman
2023-01-06 17:16 ` Andrew Cooper [this message]
2022-12-20 6:50 ` Bobby Eshleman
2023-01-09 13:01 ` Oleksii
2023-01-06 13:40 ` Julien Grall
2023-01-06 15:19 ` Andrew Cooper
2023-01-06 15:39 ` Julien Grall
2023-01-09 9:04 ` Oleksii
2023-01-09 11:11 ` Julien Grall
2023-01-06 15:19 ` Michal Orzel
2023-01-09 9:06 ` Oleksii
2023-01-06 13:14 ` [PATCH v1 5/8] xen/include: include <asm/types.h> in <xen/early_printk.h> Oleksii Kurochko
2023-01-06 13:45 ` Julien Grall
2023-01-06 13:14 ` [PATCH v1 6/8] xen/riscv: introduce early_printk basic stuff Oleksii Kurochko
2023-01-06 13:51 ` Julien Grall
2023-01-09 9:10 ` Oleksii
2023-01-09 11:14 ` Julien Grall
2023-01-06 13:14 ` [PATCH v1 7/8] xen/riscv: print hello message from C env Oleksii Kurochko
2023-01-06 13:14 ` [PATCH v1 8/8] automation: add RISC-V smoke test Oleksii Kurochko
2023-01-06 15:05 ` Andrew Cooper
2023-01-09 9:11 ` Oleksii
2023-01-06 13:51 ` [PATCH v1 0/8] Basic early_printk and smoke test implementation Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=320cc1b3-f03f-ad87-205f-d3c5db446f7d@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=alistair.francis@wdc.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).