From: Oleksii <oleksii.kurochko@gmail.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>
Subject: Re: [PATCH v1 6/8] xen/riscv: introduce early_printk basic stuff
Date: Mon, 09 Jan 2023 11:10:07 +0200 [thread overview]
Message-ID: <c197037c48921c3bbfd797172829ffa5d01609c2.camel@gmail.com> (raw)
In-Reply-To: <e7e66208-5a4f-f37a-6368-29489e93aad9@xen.org>
Hi,
On Fri, 2023-01-06 at 13:51 +0000, Julien Grall wrote:
> Hi,
>
> On 06/01/2023 13:14, Oleksii Kurochko wrote:
> > The patch introduces a basic stuff of early_printk functionality
> > which will be enough to print 'hello from C environment"
> >
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> > ---
> > xen/arch/riscv/Kconfig.debug | 7 ++++++
> > xen/arch/riscv/Makefile | 1 +
> > xen/arch/riscv/early_printk.c | 27
> > +++++++++++++++++++++++
> > xen/arch/riscv/include/asm/early_printk.h | 12 ++++++++++
> > 4 files changed, 47 insertions(+)
> > create mode 100644 xen/arch/riscv/early_printk.c
> > create mode 100644 xen/arch/riscv/include/asm/early_printk.h
> >
> > diff --git a/xen/arch/riscv/Kconfig.debug
> > b/xen/arch/riscv/Kconfig.debug
> > index e69de29bb2..940630fd62 100644
> > --- a/xen/arch/riscv/Kconfig.debug
> > +++ b/xen/arch/riscv/Kconfig.debug
> > @@ -0,0 +1,7 @@
> > +config EARLY_PRINTK
> > + bool "Enable early printk config"
> > + default DEBUG
> > + depends on RISCV_64
>
> OOI, why can't this be used for RISCV_32?
>
We can. It's my fault we wanted to start from RISCV_64 support so I
totally forgot about RISCV_32 =)
> > + help
> > +
> > + Enables early printk debug messages
> > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile
> > index 60db415654..e8630fe68d 100644
> > --- a/xen/arch/riscv/Makefile
> > +++ b/xen/arch/riscv/Makefile
> > @@ -1,6 +1,7 @@
> > obj-$(CONFIG_RISCV_64) += riscv64/
> > obj-y += setup.o
> > obj-y += sbi.o
> > +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
>
> Please order the files alphabetically.
>
> >
> > $(TARGET): $(TARGET)-syms
> > $(OBJCOPY) -O binary -S $< $@
> > diff --git a/xen/arch/riscv/early_printk.c
> > b/xen/arch/riscv/early_printk.c
> > new file mode 100644
> > index 0000000000..f357f3220b
> > --- /dev/null
> > +++ b/xen/arch/riscv/early_printk.c
> > @@ -0,0 +1,27 @@
>
> Please add an SPDX license (the default for Xen is GPLv2).
>
> > +/*
> > + * RISC-V early printk using SBI
> > + *
> > + * Copyright (C) 2021 Bobby Eshleman <bobbyeshleman@gmail.com>
>
> So the copyright here is from Bobby. But I don't see any mention in
> the
> commit message. Where is this coming from?
>
Could you please share with me an example how it should be look like?
Signed-off: ... ? Or "this file was taken from patch series ..."?
> > + */
> > +#include <asm/sbi.h>
> > +#include <asm/early_printk.h>
>
> Please order the files alphabetically.
>
> > +
> > +void early_puts(const char *s, size_t nr)
> > +{
> > + while ( nr-- > 0 )
> > + {
> > + if (*s == '\n')
> > + sbi_console_putchar('\r');
> > + sbi_console_putchar(*s);
> > + s++;
> > + }
> > +}
> > +
> > +void early_printk(const char *str)
> > +{
> > + while (*str)
> > + {
> > + early_puts(str, 1);
> > + str++;
> > + }
> > +}
> > diff --git a/xen/arch/riscv/include/asm/early_printk.h
> > b/xen/arch/riscv/include/asm/early_printk.h
> > new file mode 100644
> > index 0000000000..05106e160d
> > --- /dev/null
> > +++ b/xen/arch/riscv/include/asm/early_printk.h
> > @@ -0,0 +1,12 @@
> > +#ifndef __EARLY_PRINTK_H__
> > +#define __EARLY_PRINTK_H__
> > +
> > +#include <xen/early_printk.h>
> > +
> > +#ifdef CONFIG_EARLY_PRINTK
> > +void early_printk(const char *str);
> > +#else
> > +static inline void early_printk(const char *s) {};
> > +#endif
> > +
> > +#endif /* __EARLY_PRINTK_H__ */
>
next prev parent reply other threads:[~2023-01-09 9:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 13:14 [PATCH v1 0/8] Basic early_printk and smoke test implementation Oleksii Kurochko
2023-01-06 13:14 ` [PATCH v1 1/8] xen/riscv: introduce dummy asm/init.h Oleksii Kurochko
2023-01-06 13:42 ` Julien Grall
2023-01-09 8:53 ` Oleksii
2023-01-06 13:14 ` [PATCH v1 2/8] xen/riscv: introduce asm/types.h header file Oleksii Kurochko
2023-01-06 14:12 ` Jan Beulich
2023-01-09 8:55 ` Oleksii
2023-01-06 13:14 ` [PATCH v1 3/8] xen/riscv: introduce stack stuff Oleksii Kurochko
2023-01-06 13:54 ` Julien Grall
2023-01-09 9:00 ` Oleksii
2023-01-06 14:15 ` Jan Beulich
2023-01-09 8:57 ` Oleksii
2023-01-06 14:55 ` Andrew Cooper
2023-01-06 13:14 ` [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Oleksii Kurochko
2022-12-20 6:23 ` Bobby Eshleman
2023-01-06 17:16 ` Andrew Cooper
2022-12-20 6:50 ` Bobby Eshleman
2023-01-09 13:01 ` Oleksii
2023-01-06 13:40 ` Julien Grall
2023-01-06 15:19 ` Andrew Cooper
2023-01-06 15:39 ` Julien Grall
2023-01-09 9:04 ` Oleksii
2023-01-09 11:11 ` Julien Grall
2023-01-06 15:19 ` Michal Orzel
2023-01-09 9:06 ` Oleksii
2023-01-06 13:14 ` [PATCH v1 5/8] xen/include: include <asm/types.h> in <xen/early_printk.h> Oleksii Kurochko
2023-01-06 13:45 ` Julien Grall
2023-01-06 13:14 ` [PATCH v1 6/8] xen/riscv: introduce early_printk basic stuff Oleksii Kurochko
2023-01-06 13:51 ` Julien Grall
2023-01-09 9:10 ` Oleksii [this message]
2023-01-09 11:14 ` Julien Grall
2023-01-06 13:14 ` [PATCH v1 7/8] xen/riscv: print hello message from C env Oleksii Kurochko
2023-01-06 13:14 ` [PATCH v1 8/8] automation: add RISC-V smoke test Oleksii Kurochko
2023-01-06 15:05 ` Andrew Cooper
2023-01-09 9:11 ` Oleksii
2023-01-06 13:51 ` [PATCH v1 0/8] Basic early_printk and smoke test implementation Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c197037c48921c3bbfd797172829ffa5d01609c2.camel@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).