From: Oleksii <oleksii.kurochko@gmail.com>
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>
Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console
Date: Mon, 09 Jan 2023 11:06:22 +0200 [thread overview]
Message-ID: <ce77619047e452bd7950bdc4e3c772f98464bf1f.camel@gmail.com> (raw)
In-Reply-To: <420e9747-09ba-b6e4-d3c5-14f0f174c1d7@amd.com>
Hi Michal,
On Fri, 2023-01-06 at 16:19 +0100, Michal Orzel wrote:
> Hi Oleksii,
>
> On 06/01/2023 14:14, Oleksii Kurochko wrote:
> >
> >
> > The patch introduce sbi_putchar() SBI call which is necessary
> > to implement initial early_printk
> >
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> > ---
> > xen/arch/riscv/Makefile | 1 +
> > xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++
> > xen/arch/riscv/sbi.c | 44
> > ++++++++++++++++++++++++++++++++
> > 3 files changed, 79 insertions(+)
> > create mode 100644 xen/arch/riscv/include/asm/sbi.h
> > create mode 100644 xen/arch/riscv/sbi.c
> >
> > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile
> > index 5a67a3f493..60db415654 100644
> > --- a/xen/arch/riscv/Makefile
> > +++ b/xen/arch/riscv/Makefile
> > @@ -1,5 +1,6 @@
> > obj-$(CONFIG_RISCV_64) += riscv64/
> > obj-y += setup.o
> > +obj-y += sbi.o
> >
> > $(TARGET): $(TARGET)-syms
> > $(OBJCOPY) -O binary -S $< $@
> > diff --git a/xen/arch/riscv/include/asm/sbi.h
> > b/xen/arch/riscv/include/asm/sbi.h
> > new file mode 100644
> > index 0000000000..34b53f8eaf
> > --- /dev/null
> > +++ b/xen/arch/riscv/include/asm/sbi.h
> > @@ -0,0 +1,34 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-or-later) */
> > +/*
> > + * Copyright (c) 2021 Vates SAS.
> > + *
> > + * Taken from xvisor, modified by Bobby Eshleman
> > (bobby.eshleman@gmail.com).
> > + *
> > + * Taken/modified from Xvisor project with the following
> > copyright:
> > + *
> > + * Copyright (c) 2019 Western Digital Corporation or its
> > affiliates.
> > + */
> > +
> > +#ifndef __CPU_SBI_H__
> > +#define __CPU_SBI_H__
> I wonder where does CPU come from. Shouldn't this be called
> __ASM_RISCV_SBI_H__ ?
>
I missed that when get this files from Bobby's patch series.
It makes sense to rename the define.
Thanks.
> > +
> > +#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1
> > +
> > +struct sbiret {
> > + long error;
> > + long value;
> > +};
> > +
> > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid,
> > unsigned long arg0,
> > + unsigned long arg1, unsigned long arg2,
> > + unsigned long arg3, unsigned long arg4,
> > + unsigned long arg5);
> The arguments needs to be aligned.
>
> > +
> > +/**
> > + * Writes given character to the console device.
> > + *
> > + * @param ch The data to be written to the console.
> > + */
> > +void sbi_console_putchar(int ch);
> > +
> > +#endif // __CPU_SBI_H__
> // should be replaced with /* */
>
> > diff --git a/xen/arch/riscv/sbi.c b/xen/arch/riscv/sbi.c
> > new file mode 100644
> > index 0000000000..67cf5dd982
> > --- /dev/null
> > +++ b/xen/arch/riscv/sbi.c
> > @@ -0,0 +1,44 @@
> > +/* SPDX-License-Identifier: GPL-2.0-or-later */
> > +/*
> > + * Taken and modified from the xvisor project with the copyright
> > Copyright (c)
> > + * 2019 Western Digital Corporation or its affiliates and author
> > Anup Patel
> > + * (anup.patel@wdc.com).
> > + *
> > + * Modified by Bobby Eshleman (bobby.eshleman@gmail.com).
> > + *
> > + * Copyright (c) 2019 Western Digital Corporation or its
> > affiliates.
> > + * Copyright (c) 2021 Vates SAS.
> > + */
> > +
> > +#include <xen/errno.h>
> > +#include <asm/sbi.h>
> > +
> > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid,
> > unsigned long arg0,
> > + unsigned long arg1, unsigned long arg2,
> > + unsigned long arg3, unsigned long arg4,
> > + unsigned long arg5)
> The arguments needs to be aligned.
>
It looks that I mixed tabs with space or vice versa.
Will double check.
Thanks.
> > +{
> > + struct sbiret ret;
> Could you please add an empty line here.
>
> > + register unsigned long a0 asm ("a0") = arg0;
> > + register unsigned long a1 asm ("a1") = arg1;
> > + register unsigned long a2 asm ("a2") = arg2;
> > + register unsigned long a3 asm ("a3") = arg3;
> > + register unsigned long a4 asm ("a4") = arg4;
> > + register unsigned long a5 asm ("a5") = arg5;
> > + register unsigned long a6 asm ("a6") = fid;
> > + register unsigned long a7 asm ("a7") = ext;
> > +
> > + asm volatile ("ecall"
> > + : "+r" (a0), "+r" (a1)
> > + : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r" (a6),
> > "r" (a7)
> > + : "memory");
> > + ret.error = a0;
> > + ret.value = a1;
> > +
> > + return ret;
> > +}
> > +
> > +void sbi_console_putchar(int ch)
> > +{
> > + sbi_ecall(SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, ch, 0, 0, 0, 0, 0);
> > +}
> > --
> > 2.38.1
> >
> >
>
> ~Michal
~Oleksii
next prev parent reply other threads:[~2023-01-09 9:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 13:14 [PATCH v1 0/8] Basic early_printk and smoke test implementation Oleksii Kurochko
2023-01-06 13:14 ` [PATCH v1 1/8] xen/riscv: introduce dummy asm/init.h Oleksii Kurochko
2023-01-06 13:42 ` Julien Grall
2023-01-09 8:53 ` Oleksii
2023-01-06 13:14 ` [PATCH v1 2/8] xen/riscv: introduce asm/types.h header file Oleksii Kurochko
2023-01-06 14:12 ` Jan Beulich
2023-01-09 8:55 ` Oleksii
2023-01-06 13:14 ` [PATCH v1 3/8] xen/riscv: introduce stack stuff Oleksii Kurochko
2023-01-06 13:54 ` Julien Grall
2023-01-09 9:00 ` Oleksii
2023-01-06 14:15 ` Jan Beulich
2023-01-09 8:57 ` Oleksii
2023-01-06 14:55 ` Andrew Cooper
2023-01-06 13:14 ` [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Oleksii Kurochko
2022-12-20 6:23 ` Bobby Eshleman
2023-01-06 17:16 ` Andrew Cooper
2022-12-20 6:50 ` Bobby Eshleman
2023-01-09 13:01 ` Oleksii
2023-01-06 13:40 ` Julien Grall
2023-01-06 15:19 ` Andrew Cooper
2023-01-06 15:39 ` Julien Grall
2023-01-09 9:04 ` Oleksii
2023-01-09 11:11 ` Julien Grall
2023-01-06 15:19 ` Michal Orzel
2023-01-09 9:06 ` Oleksii [this message]
2023-01-06 13:14 ` [PATCH v1 5/8] xen/include: include <asm/types.h> in <xen/early_printk.h> Oleksii Kurochko
2023-01-06 13:45 ` Julien Grall
2023-01-06 13:14 ` [PATCH v1 6/8] xen/riscv: introduce early_printk basic stuff Oleksii Kurochko
2023-01-06 13:51 ` Julien Grall
2023-01-09 9:10 ` Oleksii
2023-01-09 11:14 ` Julien Grall
2023-01-06 13:14 ` [PATCH v1 7/8] xen/riscv: print hello message from C env Oleksii Kurochko
2023-01-06 13:14 ` [PATCH v1 8/8] automation: add RISC-V smoke test Oleksii Kurochko
2023-01-06 15:05 ` Andrew Cooper
2023-01-09 9:11 ` Oleksii
2023-01-06 13:51 ` [PATCH v1 0/8] Basic early_printk and smoke test implementation Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce77619047e452bd7950bdc4e3c772f98464bf1f.camel@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).