From: Julien Grall <julien@xen.org>
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
bertrand.marquis@arm.com, wei.chen@arm.com
Subject: Re: [PATCH] xen/arm: Fix compilation error when early printk is enabled
Date: Thu, 21 Jan 2021 09:35:18 +0000 [thread overview]
Message-ID: <42ca88cc-8535-f8c4-2441-a8d3a3308f32@xen.org> (raw)
In-Reply-To: <20210121093041.21537-1-michal.orzel@arm.com>
Hi Michal,
On 21/01/2021 09:30, Michal Orzel wrote:
> Fix compilation error when enabling early printk, introduced
> by commit aa4b9d1ee6538b5cbe218d4d3fcdf9548130a063:
> ```
> debug.S: Assembler messages:
> debug.S:31: Error: constant expression expected at operand 2 -- `ldr x15,=((0x00400000+(0)*PAGE_SIZE)+(0x1c090000&~PAGE_MASK))`
> debug.S:38: Error: constant expression expected at operand 2 -- `ldr x15,=((0x00400000+(0)*PAGE_SIZE)+(0x1c090000&~PAGE_MASK))`
> ```
>
> The fix is to include header <xen/page-size.h> which now contains
> definitions for page/size/mask etc.
>
Fixes: aa4b9d1ee653 ("include: don't use asm/page.h from common headers")
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
> ---
> xen/include/asm-arm/early_printk.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/include/asm-arm/early_printk.h b/xen/include/asm-arm/early_printk.h
> index d5485decfa..8dc911cf48 100644
> --- a/xen/include/asm-arm/early_printk.h
> +++ b/xen/include/asm-arm/early_printk.h
> @@ -10,6 +10,7 @@
> #ifndef __ARM_EARLY_PRINTK_H__
> #define __ARM_EARLY_PRINTK_H__
>
> +#include <xen/page-size.h>
>
> #ifdef CONFIG_EARLY_PRINTK
>
>
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2021-01-21 9:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 9:30 [PATCH] xen/arm: Fix compilation error when early printk is enabled Michal Orzel
2021-01-21 9:35 ` Julien Grall [this message]
2021-01-21 9:43 ` Jan Beulich
2021-01-21 9:52 ` Michal Orzel
2021-01-21 9:56 ` Julien Grall
2021-01-21 10:24 ` Jan Beulich
2021-01-21 18:47 ` Julien Grall
2021-01-22 9:07 ` Jan Beulich
2021-01-21 9:47 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ca88cc-8535-f8c4-2441-a8d3a3308f32@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=michal.orzel@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).