From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
bertrand.marquis@arm.com, wei.chen@arm.com,
xen-devel@lists.xenproject.org,
Michal Orzel <michal.orzel@arm.com>
Subject: Re: [PATCH] xen/arm: Fix compilation error when early printk is enabled
Date: Fri, 22 Jan 2021 10:07:21 +0100 [thread overview]
Message-ID: <558c9176-9804-41ec-6199-382f3d1aec02@suse.com> (raw)
In-Reply-To: <96e5720d-81ae-061e-d378-7cae6ad04415@xen.org>
On 21.01.2021 19:47, Julien Grall wrote:
> On 21/01/2021 10:24, Jan Beulich wrote:
>> On 21.01.2021 10:56, Julien Grall wrote:
>>> On 21/01/2021 09:43, Jan Beulich wrote:
>>>> On 21.01.2021 10:30, Michal Orzel wrote:
>>>>> --- a/xen/include/asm-arm/early_printk.h
>>>>> +++ b/xen/include/asm-arm/early_printk.h
>>>>> @@ -10,6 +10,7 @@
>>>>> #ifndef __ARM_EARLY_PRINTK_H__
>>>>> #define __ARM_EARLY_PRINTK_H__
>>>>>
>>>>> +#include <xen/page-size.h>
>>>>>
>>>>> #ifdef CONFIG_EARLY_PRINTK
>>>>
>>>> ... a respective Kconfig setting, i.e. it's not like I simply
>>>> failed to enable it.
>>>
>>> EARLY_PRINTK is defined in arch/arm/Kconfig.debug and is selected when
>>> you specify the UART to use.
>>>
>>> Assuming you are only build testing, you could add the following for
>>> testing EARLY_PRINTK:
>>>
>>> CONFIG_DEBUG=y
>>> CONFIG_EARLY_UART_CHOICE_8250=y
>>> CONFIG_EARLY_UART_8250=y
>>> CONFIG_EARLY_PRINTK=y
>>> CONFIG_EARLY_UART_BASE_ADDRESS=
>>> CONFIG_EARLY_UART_8250_REG_SHIFT=0
>>> CONFIG_EARLY_PRINTK_INC="debug-8250.inc"
>>
>> Ah yes, this works, thanks. The "optional" on the choice isn't
>> very helpful I suppose, because when going from an existing
>> .config one would neither find a setting presently turned off
>> in that .config, nor will there be a prompt.
>
> Do you have a suggestion how the "choice" can appear in the .config?
Drop the "optional" attribute from it? Of course I ask without any
knowledge on why it may have been put there in the first place.
Jan
next prev parent reply other threads:[~2021-01-22 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 9:30 [PATCH] xen/arm: Fix compilation error when early printk is enabled Michal Orzel
2021-01-21 9:35 ` Julien Grall
2021-01-21 9:43 ` Jan Beulich
2021-01-21 9:52 ` Michal Orzel
2021-01-21 9:56 ` Julien Grall
2021-01-21 10:24 ` Jan Beulich
2021-01-21 18:47 ` Julien Grall
2021-01-22 9:07 ` Jan Beulich [this message]
2021-01-21 9:47 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558c9176-9804-41ec-6199-382f3d1aec02@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=michal.orzel@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).