From: Michal Orzel <michal.orzel@arm.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
bertrand.marquis@arm.com, wei.chen@arm.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/arm: Fix compilation error when early printk is enabled
Date: Thu, 21 Jan 2021 10:52:08 +0100 [thread overview]
Message-ID: <e50fe7a0-f30e-d059-3a5a-730b039f4606@arm.com> (raw)
In-Reply-To: <6f317514-110a-9c5c-8732-60c0a1f58d31@suse.com>
Hi Jan,
On 21.01.2021 10:43, Jan Beulich wrote:
> On 21.01.2021 10:30, Michal Orzel wrote:
>> Fix compilation error when enabling early printk, introduced
>> by commit aa4b9d1ee6538b5cbe218d4d3fcdf9548130a063:
>> ```
>> debug.S: Assembler messages:
>> debug.S:31: Error: constant expression expected at operand 2 -- `ldr x15,=((0x00400000+(0)*PAGE_SIZE)+(0x1c090000&~PAGE_MASK))`
>> debug.S:38: Error: constant expression expected at operand 2 -- `ldr x15,=((0x00400000+(0)*PAGE_SIZE)+(0x1c090000&~PAGE_MASK))`
>> ```
>>
>> The fix is to include header <xen/page-size.h> which now contains
>> definitions for page/size/mask etc.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>
> I'm sorry for the breakage, but I wonder how I should have noticed
> the issue. In all the Arm .config-s I'm routinely building I can't
> even see ...
>
This is not your fault. Nowadays it is becoming harder and harder to try all the possible combinations.
>> --- a/xen/include/asm-arm/early_printk.h
>> +++ b/xen/include/asm-arm/early_printk.h
>> @@ -10,6 +10,7 @@
>> #ifndef __ARM_EARLY_PRINTK_H__
>> #define __ARM_EARLY_PRINTK_H__
>>
>> +#include <xen/page-size.h>
>>
>> #ifdef CONFIG_EARLY_PRINTK
>
> ... a respective Kconfig setting, i.e. it's not like I simply
> failed to enable it.
>
> Jan
>
Cheers,
Michal
next prev parent reply other threads:[~2021-01-21 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 9:30 [PATCH] xen/arm: Fix compilation error when early printk is enabled Michal Orzel
2021-01-21 9:35 ` Julien Grall
2021-01-21 9:43 ` Jan Beulich
2021-01-21 9:52 ` Michal Orzel [this message]
2021-01-21 9:56 ` Julien Grall
2021-01-21 10:24 ` Jan Beulich
2021-01-21 18:47 ` Julien Grall
2021-01-22 9:07 ` Jan Beulich
2021-01-21 9:47 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e50fe7a0-f30e-d059-3a5a-730b039f4606@arm.com \
--to=michal.orzel@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).