From: "Jan Beulich" <JBeulich@suse.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
Chong Li <lichong659@gmail.com>
Cc: Chong Li <chong.li@wustl.edu>, Wei Liu <wei.liu2@citrix.com>,
Sisu Xi <xisisu@gmail.com>,
GeorgeDunlap <george.dunlap@eu.citrix.com>,
xen-devel <xen-devel@lists.xen.org>,
Meng Xu <mengxu@cis.upenn.edu>,
Dagaen Golomb <dgolomb@seas.upenn.edu>
Subject: Re: [PATCH v6 for Xen 4.7 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler
Date: Mon, 14 Mar 2016 03:15:46 -0600 [thread overview]
Message-ID: <56E68F5202000078000DBF46@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1457946623.3102.636.camel@citrix.com>
>>> On 14.03.16 at 10:10, <dario.faggioli@citrix.com> wrote:
> On Mon, 2016-03-14 at 02:37 -0600, Jan Beulich wrote:
>> > > > On 13.03.16 at 18:05, <lichong659@gmail.com> wrote:
> About this:
>
>> > 3) Use printk(XENLOG_G_WARNING ...) here, because of its rate limit
>> > feature.
>> I'd say XENLOG_G_DEBUG, and even that only if you really think
>> the message is useful.
>>
> I think it has some value to have this in the logs. In fact, someone
> that ended up with small values --either by bug/chance, or in general
> without a specific need for them-- and is seeing performance/scheduling
> issues will still be able to find this.
>
> And printing it somewhere else than in Xen is impractical (see my reply
> to Wei).
>
> However, we may well print it just once, as soon as the first vcpu with
> potentially problematic parameters is hit, and then silence it.
>
> Linux has things like WARN_ON_ONCE to do this:
> http://lxr.free-electrons.com/source/include/asm-generic/bug.h#L109
>
> I don't see anything like it in Xen, so you'd need to either implement
> it, or arrange for something with the same effect locally.
One of the reasons we don't (yet) have this is because commonly
(like is the case here) printing such once globally isn't really what
you want - you'd much rather see it once per domain.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-14 9:15 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 17:55 [PATCH v6 for Xen 4.7 0/4] Enable per-VCPU parameter settings for RTDS scheduler Chong Li
2016-03-06 17:55 ` [PATCH v6 for Xen 4.7 1/4] xen: enable " Chong Li
2016-03-07 12:59 ` Jan Beulich
2016-03-07 16:28 ` Chong Li
2016-03-07 16:40 ` Jan Beulich
2016-03-07 17:53 ` Dario Faggioli
2016-03-07 22:16 ` Chong Li
2016-03-08 9:10 ` Jan Beulich
2016-03-08 10:34 ` Dario Faggioli
2016-03-08 11:47 ` Jan Beulich
2016-03-08 19:09 ` Wei Liu
2016-03-09 16:10 ` Dario Faggioli
2016-03-09 16:38 ` Jan Beulich
2016-03-13 17:05 ` Chong Li
2016-03-14 8:37 ` Jan Beulich
2016-03-14 9:10 ` Dario Faggioli
2016-03-14 9:15 ` Jan Beulich [this message]
2016-03-14 10:05 ` Dario Faggioli
2016-03-15 16:22 ` Chong Li
2016-03-15 16:41 ` Dario Faggioli
2016-03-15 17:22 ` Chong Li
2016-03-16 3:14 ` Meng Xu
2016-03-16 3:32 ` Chong Li
2016-03-16 3:43 ` Meng Xu
2016-03-16 8:23 ` Dario Faggioli
2016-03-16 14:37 ` Meng Xu
2016-03-16 14:46 ` Chong Li
2016-03-16 14:53 ` Dario Faggioli
2016-03-16 14:46 ` Chong Li
2016-03-16 14:54 ` Dario Faggioli
2016-03-16 10:48 ` Jan Beulich
2016-03-10 22:35 ` Chong Li
2016-03-10 22:50 ` Wei Liu
2016-03-14 9:07 ` Dario Faggioli
2016-03-06 17:55 ` [PATCH v6 for Xen 4.7 2/4] libxc: " Chong Li
2016-03-08 19:09 ` Wei Liu
2016-03-08 19:32 ` Chong Li
2016-03-08 19:36 ` Wei Liu
2016-03-06 17:55 ` [PATCH v6 for Xen 4.7 3/4] libxl: " Chong Li
2016-03-08 19:12 ` Wei Liu
2016-03-09 0:38 ` Chong Li
2016-03-09 14:01 ` Wei Liu
2016-03-09 17:28 ` Dario Faggioli
2016-03-09 21:57 ` Chong Li
2016-03-09 17:09 ` Dario Faggioli
2016-03-09 17:28 ` Dario Faggioli
2016-03-06 17:55 ` [PATCH v6 for Xen 4.7 4/4] xl: " Chong Li
2016-03-08 19:12 ` Wei Liu
2016-03-08 21:24 ` Chong Li
2016-03-09 14:01 ` Wei Liu
2016-03-09 14:09 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E68F5202000078000DBF46@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=chong.li@wustl.edu \
--cc=dario.faggioli@citrix.com \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=mengxu@cis.upenn.edu \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xisisu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).