Re: [PATCH v6 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

From: Chong Li <lichong659@gmail.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Chong Li <chong.li@wustl.edu>, Wei Liu <wei.liu2@citrix.com>,
	Sisu Xi <xisisu@gmail.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xen.org>,
	Meng Xu <mengxu@cis.upenn.edu>,
	Dagaen Golomb <dgolomb@seas.upenn.edu>
Subject: Re: [PATCH v6 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler
Date: Wed, 9 Mar 2016 15:57:56 -0600	[thread overview]
Message-ID: <CAGHO-ioB-VUh5FjDCYy=ZScQs-WtkN6HfzqviKXp_sqYE2_dtw@mail.gmail.com> (raw)
In-Reply-To: <1457544535.3102.453.camel@citrix.com>

On Wed, Mar 9, 2016 at 11:28 AM, Dario Faggioli
<dario.faggioli@citrix.com> wrote:
> On Tue, 2016-03-08 at 19:12 +0000, Wei Liu wrote:
>
>> Overall I think the patch is moving towards the right direction.
>>
> I also think so. Thanks a lot Wei for the review, BTW.
>
>> Just
>> that there are too many places where indentation need fixing.  Please
>> fix them in the next iteration. I really don't like holding back
>> patches
>> just because of indentation issues.
>>
> Exactly. Trying to elaborate a bit more, this series does not include
> any complex algorithm or similar, so one may thing that it is not that
> hard to review. But it is indeed complex and hard to review, because
> the patches are rather big and because the API and the command line
> syntax we want to support is complex.
>
> If there are too many style issue, any review will likely end up
> focusing mostly, if not only, on them, for various reasons. E.g., when
> one finds a stile issue, avoiding commenting on it (e.g., because one
> wants to focus on "more important" aspects) means risking forgetting
> about it and, in the end, letting it hit the repository (if others also
> miss it or does the same). Also, we're all used to look at code that
> (well, mostly :-D) conforms to coding style, so it's harder to focus on
> code that does not. And more.
>
> Add to this that the most difficult part of the tools side of this
> series (like API and data structures) is actually ok.
>
> So, Chong, for us to be able to quickly and effectively help you
> forward, we need to ask you to do your best and get rid of (ideally)
> all coding style problems.
>
> Once that's done, we're not far from calling this all a done deal. :-)
>
> Thanks and Regards,
> Dario

Wei and Dario, thanks for your help reviewing this post. I'm now
working on the coding style issues and will send out the next version
when
all problems are figured out.

Chong

> --
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
>

-- 
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel