From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
David Vrabel <david.vrabel@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] tools: fix xen-detect to correctly identify domU type
Date: Wed, 23 Mar 2016 08:50:53 -0400 [thread overview]
Message-ID: <56F2912D.1060009@oracle.com> (raw)
In-Reply-To: <56F27F00.8060600@suse.com>
On 03/23/2016 07:33 AM, Juergen Gross wrote:
> On 23/03/16 11:55, Andrew Cooper wrote:
>> On 23/03/16 10:52, Juergen Gross wrote:
>>> On 23/03/16 11:32, David Vrabel wrote:
>>>> On 23/03/16 10:25, Jan Beulich wrote:
>>>>>>>> On 23.03.16 at 11:14, <JGross@suse.com> wrote:
>>>>>> 7. Report type according to features found (this is a little bit
>>>>>> ugly: we have to rely on the current hypervisor implementation
>>>>>> regarding the bits set for the different guest types).
>>>>> Well, in some of the cases feature flags only make sense for one
>>>>> kind of guest, so if such a flag is set it could be used as positive
>>>>> indication (while it being clear may then still mean nothing).
>>>>>
>>>>>> Would it make sense to add another file to /sys/hypervisor/properties?
>>>>>> Something like guest_type, containing "pv", "hvm" or "pvh"? If existing
>>>>>> this could be used to report the guest type.
>>>>> That would seem a good idea to me. What do others, namely
>>>>> Linux maintainers, think?
>>>> What's the use case for user space knowing if it's in a PV or HVM domain?
>>> The first thing coming to my mind would be diagnostic tools.
>> Having the admin able to tell for informational purposes is useful.
>> They can find out by looking at the top of `dmesg`, but a hypervisor
>> sysfs node is cleaner than requiring the admin to know every printk()
>> variant that Xen puts out.
> Especially on a long running guest this information might be not
> available in case of trouble.
What about dmidecode?
Unprivileged PV guests will return nothing:
[root@dhcp-burlington7-2nd-B-east-10-152-55-140 ~]# dmidecode
# dmidecode 2.11
# No SMBIOS nor DMI entry point found, sorry.
[root@dhcp-burlington7-2nd-B-east-10-152-55-140 ~]#
HVM guests will say something like:
System Information
Manufacturer: Xen
Product Name: HVM domU
and dom0 will report actual info.
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-23 12:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 7:50 [PATCH] tools: fix xen-detect to correctly identify domU type Juergen Gross
2016-03-23 9:10 ` Jan Beulich
[not found] ` <56F26B7C02000078000DF896@suse.com>
2016-03-23 9:19 ` Juergen Gross
2016-03-23 9:29 ` Jan Beulich
[not found] ` <56F26FF602000078000DF8C8@suse.com>
2016-03-23 10:14 ` Juergen Gross
2016-03-23 10:25 ` Jan Beulich
2016-03-23 10:32 ` David Vrabel
2016-03-23 10:52 ` Juergen Gross
2016-03-23 10:55 ` Andrew Cooper
2016-03-23 10:59 ` David Vrabel
2016-03-23 11:12 ` Andrew Cooper
2016-03-23 11:18 ` David Vrabel
2016-03-23 11:25 ` Andrew Cooper
2016-03-23 19:03 ` Juergen Gross
2016-03-24 10:22 ` David Vrabel
2016-03-24 10:58 ` Juergen Gross
2016-03-24 11:23 ` Andrew Cooper
2016-03-24 11:38 ` George Dunlap
2016-03-25 8:54 ` Juergen Gross
2016-03-29 6:49 ` Jan Beulich
2016-03-29 13:54 ` George Dunlap
2016-03-29 14:00 ` Juergen Gross
2016-03-29 14:05 ` George Dunlap
2016-03-23 11:33 ` Juergen Gross
2016-03-23 12:50 ` Boris Ostrovsky [this message]
2016-03-23 10:34 ` Andrew Cooper
2016-03-23 10:48 ` Juergen Gross
2016-03-23 10:29 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F2912D.1060009@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).