From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen/init: Annotate all command line parameter infrastructure as const
Date: Thu, 09 Jun 2016 06:39:07 -0600 [thread overview]
Message-ID: <57597F8B02000078000F3769@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1465466335-19761-1-git-send-email-andrew.cooper3@citrix.com>
>>> On 09.06.16 at 11:58, <andrew.cooper3@citrix.com> wrote:
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -135,6 +135,12 @@ SECTIONS
> *(.init.rodata)
> *(.init.rodata.rel)
> *(.init.rodata.str*)
> +
> + . = ALIGN(POINTER_ALIGN);
> + __setup_start = .;
> + *(.init.setup)
> + __setup_end = .;
> +
> *(.init.data)
> *(.init.data.rel)
> *(.init.data.rel.*)
> @@ -145,11 +151,6 @@ SECTIONS
> __ctors_end = .;
> } :text
> . = ALIGN(32);
> - .init.setup : {
> - __setup_start = .;
> - *(.init.setup)
> - __setup_end = .;
> - } :text
> .init.proc.info : {
Surely that ALIGN() then has no reason to retain the 32 (similar
for x86)?
> --- a/xen/include/xen/init.h
> +++ b/xen/include/xen/init.h
> @@ -86,10 +86,11 @@ struct kernel_param {
> void *var;
> };
>
> -extern struct kernel_param __setup_start, __setup_end;
> +extern struct kernel_param __setup_start[], __setup_end[];
I thought your respective remark in the commit message would
also implied making these const now that they are.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-09 12:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 9:58 [PATCH] xen/init: Annotate all command line parameter infrastructure as const Andrew Cooper
2016-06-09 9:58 ` [PATCH] xen/xsm: Annotate xsm_initcall() data " Andrew Cooper
2016-06-09 12:40 ` Jan Beulich
2016-06-09 14:26 ` Daniel De Graaf
2016-06-09 14:28 ` Andrew Cooper
2016-06-09 9:58 ` [PATCH] x86/boot: copy/clear sections more efficiently Andrew Cooper
2016-06-09 12:42 ` Jan Beulich
2016-06-09 10:03 ` [PATCH] xen/init: Annotate all command line parameter infrastructure as const Andrew Cooper
2016-06-09 12:39 ` Jan Beulich [this message]
2016-06-09 13:45 ` Andrew Cooper
2016-06-09 14:19 ` Julien Grall
2016-06-09 14:20 ` Julien Grall
2016-06-09 14:28 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57597F8B02000078000F3769@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).