* [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible
@ 2016-07-07 8:06 Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2016-07-07 8:06 UTC (permalink / raw)
To: Roger Pau Monne, Konrad Rzeszutek Wilk; +Cc: xen-devel, linux-kernel
... as being the simpler variant.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
drivers/block/xen-blkfront.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c
+++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c
@@ -1825,14 +1825,13 @@ again:
}
kfree(path);
}
- err = xenbus_printf(xbt, dev->nodename, "protocol", "%s",
- XEN_IO_PROTO_ABI_NATIVE);
+ err = xenbus_write(xbt, dev->nodename, "protocol",
+ XEN_IO_PROTO_ABI_NATIVE);
if (err) {
message = "writing protocol";
goto abort_transaction;
}
- err = xenbus_printf(xbt, dev->nodename,
- "feature-persistent", "%u", 1);
+ err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1");
if (err)
dev_warn(&dev->dev,
"writing persistent grants feature to xenbus");
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <577E29A902000078000FBF28@prv-mh.provo.novell.com>]
* Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible
[not found] <577E29A902000078000FBF28@prv-mh.provo.novell.com>
@ 2016-07-07 9:44 ` Roger Pau Monne
[not found] ` <20160707094405.mgv6uykxmqsq4fi2@mac>
1 sibling, 0 replies; 3+ messages in thread
From: Roger Pau Monne @ 2016-07-07 9:44 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, linux-kernel
On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote:
> ... as being the simpler variant.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> drivers/block/xen-blkfront.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c
> +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c
> @@ -1825,14 +1825,13 @@ again:
> }
> kfree(path);
> }
> - err = xenbus_printf(xbt, dev->nodename, "protocol", "%s",
> - XEN_IO_PROTO_ABI_NATIVE);
> + err = xenbus_write(xbt, dev->nodename, "protocol",
> + XEN_IO_PROTO_ABI_NATIVE);
> if (err) {
> message = "writing protocol";
> goto abort_transaction;
> }
> - err = xenbus_printf(xbt, dev->nodename,
> - "feature-persistent", "%u", 1);
> + err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1");
AFAICT you forgot to replace xenbus_printf with xenbus_write here.
Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <20160707094405.mgv6uykxmqsq4fi2@mac>]
* Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible
[not found] ` <20160707094405.mgv6uykxmqsq4fi2@mac>
@ 2016-07-07 10:00 ` Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2016-07-07 10:00 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, linux-kernel
>>> On 07.07.16 at 11:44, <roger.pau@citrix.com> wrote:
> On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote:
>> ... as being the simpler variant.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> drivers/block/xen-blkfront.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c
>> +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c
>> @@ -1825,14 +1825,13 @@ again:
>> }
>> kfree(path);
>> }
>> - err = xenbus_printf(xbt, dev->nodename, "protocol", "%s",
>> - XEN_IO_PROTO_ABI_NATIVE);
>> + err = xenbus_write(xbt, dev->nodename, "protocol",
>> + XEN_IO_PROTO_ABI_NATIVE);
>> if (err) {
>> message = "writing protocol";
>> goto abort_transaction;
>> }
>> - err = xenbus_printf(xbt, dev->nodename,
>> - "feature-persistent", "%u", 1);
>> + err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1");
>
> AFAICT you forgot to replace xenbus_printf with xenbus_write here.
Oops, indeed - thanks for noticing.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-07 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-07 8:06 [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible Jan Beulich
[not found] <577E29A902000078000FBF28@prv-mh.provo.novell.com>
2016-07-07 9:44 ` Roger Pau Monne
[not found] ` <20160707094405.mgv6uykxmqsq4fi2@mac>
2016-07-07 10:00 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).