* fix vbd rd_sects stat
@ 2021-07-09 8:09 Richard Kojedzinszky
2021-07-09 8:59 ` Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Richard Kojedzinszky @ 2021-07-09 8:09 UTC (permalink / raw)
To: xen-devel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-xenstat_linux.c-fix-populating-vbd.rd_sect.patch --]
[-- Type: text/x-diff; name=0001-xenstat_linux.c-fix-populating-vbd.rd_sect.patch, Size: 1130 bytes --]
From d09d27e40cfbdd2dbf5aefaa40a4f46ccb268056 Mon Sep 17 00:00:00 2001
Message-Id: <d09d27e40cfbdd2dbf5aefaa40a4f46ccb268056.1625818025.git.richard@kojedz.in>
From: Richard Kojedzinszky <richard@kojedz.in>
Date: Fri, 9 Jul 2021 10:06:45 +0200
Subject: [PATCH] xenstat_linux.c: fix populating vbd.rd_sect
---
tools/libs/stat/xenstat_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libs/stat/xenstat_linux.c b/tools/libs/stat/xenstat_linux.c
index 875a0617ad..8939cf3bcd 100644
--- a/tools/libs/stat/xenstat_linux.c
+++ b/tools/libs/stat/xenstat_linux.c
@@ -475,7 +475,7 @@ int xenstat_collect_vbds(xenstat_node * node)
(read_attributes_vbd(dp->d_name, "statistics/wr_req", buf, 256)<=0) ||
((ret = sscanf(buf, "%llu", &vbd.wr_reqs)) != 1) ||
(read_attributes_vbd(dp->d_name, "statistics/rd_sect", buf, 256)<=0) ||
- ((ret = sscanf(buf, "%llu", &vbd.wr_sects)) != 1) ||
+ ((ret = sscanf(buf, "%llu", &vbd.rd_sect)) != 1) ||
(read_attributes_vbd(dp->d_name, "statistics/wr_sect", buf, 256)<=0) ||
((ret = sscanf(buf, "%llu", &vbd.wr_sects)) != 1))
{
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: fix vbd rd_sects stat
2021-07-09 8:09 fix vbd rd_sects stat Richard Kojedzinszky
@ 2021-07-09 8:59 ` Andrew Cooper
2021-07-09 9:32 ` Richard Kojedzinszky
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2021-07-09 8:59 UTC (permalink / raw)
To: Richard Kojedzinszky, xen-devel
On 09/07/2021 09:09, Richard Kojedzinszky wrote:
Thankyou for the patch. That is quite an embarrassing bug.
However, for copyright reasons, we require all submissions to contain a
Signed-off-by line, as per the Developer's Certificate of Origin,
https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Signed-off-by
Given how trivial this patch is, feel free to just reply to this email
with confirmation and I can sort it out on commit.
However, for future patches, please include directly. (Also, if you are
able to use git-send-email, and the get_maintainers.pl script, that
would be even better.)
~Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: fix vbd rd_sects stat
2021-07-09 8:59 ` Andrew Cooper
@ 2021-07-09 9:32 ` Richard Kojedzinszky
2021-07-09 11:30 ` Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Richard Kojedzinszky @ 2021-07-09 9:32 UTC (permalink / raw)
To: Andrew Cooper, xen-devel
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
Then please add signed-by headers. :)
Thanks
2021. július 9. 10:59:54 CEST, Andrew Cooper <andrew.cooper3@citrix.com> írta:
>On 09/07/2021 09:09, Richard Kojedzinszky wrote:
>
>Thankyou for the patch. That is quite an embarrassing bug.
>
>However, for copyright reasons, we require all submissions to contain a
>Signed-off-by line, as per the Developer's Certificate of Origin,
>https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Signed-off-by
>
>Given how trivial this patch is, feel free to just reply to this email
>with confirmation and I can sort it out on commit.
>
>However, for future patches, please include directly. (Also, if you
>are
>able to use git-send-email, and the get_maintainers.pl script, that
>would be even better.)
>
>~Andrew
--
Ezt a levelet az Android készülékemről küldtem K-9 Mail-el. Elnézést a tömörségemért.
[-- Attachment #2: Type: text/html, Size: 1274 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-09 12:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 8:09 fix vbd rd_sects stat Richard Kojedzinszky
2021-07-09 8:59 ` Andrew Cooper
2021-07-09 9:32 ` Richard Kojedzinszky
2021-07-09 11:30 ` Andrew Cooper
2021-07-09 11:37 ` Richard Kojedzinszky
2021-07-09 12:18 ` xenstat-exporter: [Was Re: fix vbd rd_sects stat] Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).