[PATCH 1/6] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries

[PATCH 1/6] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries

[George Dunlap]

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Ian Jackson <ian.jackson@citrix.com>
CC: Tamas K Lengyel <tamas.lengyel@zentific.com>
---
 CHANGELOG.md | 1 +
 SUPPORT.md   | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c407f6bb2f..7f03e85bd7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
  - ARM IOREQ servers (device emulation etc.) (Tech Preview)
  - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview)
  - ARM SMMUv3 (Tech Preview)
+ - Intel Processor Trace support (Tech Preview)
 
 ## Removed / support downgraded
 
diff --git a/SUPPORT.md b/SUPPORT.md
index a1efd8fcfd..966ddf89c8 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -247,6 +247,13 @@ Export hypervisor coverage data suitable for analysis by gcov or lcov.
 
     Status: Supported, Not security supported
 
+### Processor trace support
+
+Support for using Intel Processor Trace technology to trace guests
+from dom0.
+
+    Status: Tech Preview
+
 ## Memory Management
 
 ### Dynamic memory control
-- 
2.30.2

[PATCH 2/6] CHANGELOG.md: Add named PCI devices

[George Dunlap]

Signed-off-by: George Dunlap <george.dunlap@citrix.coM>
---
CC: Ian Jackson <ian.jackson@citrix.com>
CC: Paul Durrant <paul@xen.org>
---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7f03e85bd7..8c89212f14 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
  - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview)
  - ARM SMMUv3 (Tech Preview)
  - Intel Processor Trace support (Tech Preview)
+ - Named PCI devices for xl/libxl
 
 ## Removed / support downgraded
 
-- 
2.30.2

Re: [PATCH 2/6] CHANGELOG.md: Add named PCI devices

[Paul Durrant]

On 24/03/2021 16:44, George Dunlap wrote:
> Signed-off-by: George Dunlap <george.dunlap@citrix.coM>
> ---
> CC: Ian Jackson <ian.jackson@citrix.com>
> CC: Paul Durrant <paul@xen.org>

Reviewed-by: Paul Durrant <paul@xen.org>

> ---
>   CHANGELOG.md | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index 7f03e85bd7..8c89212f14 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>    - Renesas IPMMU-VMSA (Supported, not security supported; was Tech Preview)
>    - ARM SMMUv3 (Tech Preview)
>    - Intel Processor Trace support (Tech Preview)
> + - Named PCI devices for xl/libxl
>   
>   ## Removed / support downgraded
>   
> 

[PATCH 3/6] CHANGELOG.md: Add dom0 zstd compression support

[George Dunlap]

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
CC: Jan Beulich <jbeulich@suse.com>
CC: Ian Jackson <ian.jackson@citrix.com>
---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8c89212f14..354f213e81 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
  - ARM SMMUv3 (Tech Preview)
  - Intel Processor Trace support (Tech Preview)
  - Named PCI devices for xl/libxl
+ - Support for zstd-compressed dom0 kernels
 
 ## Removed / support downgraded
 
-- 
2.30.2

Re: [PATCH 3/6] CHANGELOG.md: Add dom0 zstd compression support

[Andrew Cooper]

On 24/03/2021 16:44, George Dunlap wrote:
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
> ---
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Ian Jackson <ian.jackson@citrix.com>
> ---
>  CHANGELOG.md | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index 8c89212f14..354f213e81 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>   - ARM SMMUv3 (Tech Preview)
>   - Intel Processor Trace support (Tech Preview)
>   - Named PCI devices for xl/libxl
> + - Support for zstd-compressed dom0 kernels

All kernels, I think?

The support for domU went in separately to support for dom0, but both
are present now.

Talking of, I don't recall a patch to the README package list or to the
CI containers, so I bet domU support is untested right now...

~Andrew

Re: [PATCH 3/6] CHANGELOG.md: Add dom0 zstd compression support

[George Dunlap]

> On Mar 24, 2021, at 4:56 PM, Andrew Cooper <Andrew.Cooper3@citrix.com> wrote:
> 
> On 24/03/2021 16:44, George Dunlap wrote:
>> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
>> ---
>> CC: Jan Beulich <jbeulich@suse.com>
>> CC: Ian Jackson <ian.jackson@citrix.com>
>> ---
>> CHANGELOG.md | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/CHANGELOG.md b/CHANGELOG.md
>> index 8c89212f14..354f213e81 100644
>> --- a/CHANGELOG.md
>> +++ b/CHANGELOG.md
>> @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>>  - ARM SMMUv3 (Tech Preview)
>>  - Intel Processor Trace support (Tech Preview)
>>  - Named PCI devices for xl/libxl
>> + - Support for zstd-compressed dom0 kernels
> 
> All kernels, I think?
> 
> The support for domU went in separately to support for dom0, but both
> are present now.

Oh, good.  I only happened to see the commit that introduced dom0 support.

> Talking of, I don't recall a patch to the README package list or to the
> CI containers, so I bet domU support is untested right now…

If you could send a patch, or prod someone to do it, that would be helpful.

 -George

[PATCH 4/6] CHANGELOG.md: NetBSD lib/gnttab support

[George Dunlap]

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
CC: Manuel Bouyer <bouyer@netbsd.org>
CC: Ian Jackson <ian.jackson@citrix.com>
CC: Roger Pau Monne <roger.pau@citrix.com>
---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 354f213e81..3f4eed1d98 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
  - Intel Processor Trace support (Tech Preview)
  - Named PCI devices for xl/libxl
  - Support for zstd-compressed dom0 kernels
+ - Library improvements from NetBSD ports upstreamed
 
 ## Removed / support downgraded
 
-- 
2.30.2

Re: [PATCH 4/6] CHANGELOG.md: NetBSD lib/gnttab support

[Roger Pau Monné]

On Wed, Mar 24, 2021 at 04:44:05PM +0000, George Dunlap wrote:
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>

LGTM, maybe Manuel has something else to add.

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.

Re: [PATCH 4/6] CHANGELOG.md: NetBSD lib/gnttab support

[Manuel Bouyer]

On Thu, Mar 25, 2021 at 10:13:11AM +0100, Roger Pau Monné wrote:
> On Wed, Mar 24, 2021 at 04:44:05PM +0000, George Dunlap wrote:
> > Signed-off-by: George Dunlap <george.dunlap@citrix.com>
> 
> LGTM, maybe Manuel has something else to add.

no, it's OK for me too

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--

[PATCH 5/6] CHANGELOG.md: Add entries for emulation

[George Dunlap]

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
CC: Jan Beulich <jbeulich@suse.com>
CC: Ian Jackson <ian.jackson@citrix.com>
---
 CHANGELOG.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3f4eed1d98..df6c638152 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
  - Named PCI devices for xl/libxl
  - Support for zstd-compressed dom0 kernels
  - Library improvements from NetBSD ports upstreamed
+ - x86_emulate: Support AVX-VNNI instructions
+ - x86_emulate: Expanded testing for several instruction classes
 
 ## Removed / support downgraded
 
-- 
2.30.2

Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation

[Jan Beulich]

On 24.03.2021 17:44, George Dunlap wrote:
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>   - Named PCI devices for xl/libxl
>   - Support for zstd-compressed dom0 kernels
>   - Library improvements from NetBSD ports upstreamed
> + - x86_emulate: Support AVX-VNNI instructions
> + - x86_emulate: Expanded testing for several instruction classes

TBH both seem too minor to me to be mentioned here. If I was to pick
just one, I'd keep the former and drop the latter.

Jan

Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation

[George Dunlap]

> On Mar 25, 2021, at 7:57 AM, Jan Beulich <jbeulich@suse.com> wrote:
> 
> On 24.03.2021 17:44, George Dunlap wrote:
>> --- a/CHANGELOG.md
>> +++ b/CHANGELOG.md
>> @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>>  - Named PCI devices for xl/libxl
>>  - Support for zstd-compressed dom0 kernels
>>  - Library improvements from NetBSD ports upstreamed
>> + - x86_emulate: Support AVX-VNNI instructions
>> + - x86_emulate: Expanded testing for several instruction classes
> 
> TBH both seem too minor to me to be mentioned here. If I was to pick
> just one, I'd keep the former and drop the latter.

It’s always quite difficult in these releases to help express to people exactly what’s happened.  We’ve got over 1000 changesets — what have we been doing?  If my star chart is correct, the latter represents nearly 1700 extra lines of codes in tools/tests/x86_emulator/predicates.c.  It’s actually a reasonable chunk of code churn, which I think is worth highlighting.

Re the former, I think letting someone know that a new instruction is emulated is worthwhile.

Ian is the maintainer, so ultimately I think it’s his call?

 -George

Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation

[Andrew Cooper]

On 25/03/2021 09:04, George Dunlap wrote:
>
>> On Mar 25, 2021, at 7:57 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 24.03.2021 17:44, George Dunlap wrote:
>>> --- a/CHANGELOG.md
>>> +++ b/CHANGELOG.md
>>> @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>>>  - Named PCI devices for xl/libxl
>>>  - Support for zstd-compressed dom0 kernels
>>>  - Library improvements from NetBSD ports upstreamed
>>> + - x86_emulate: Support AVX-VNNI instructions
>>> + - x86_emulate: Expanded testing for several instruction classes
>> TBH both seem too minor to me to be mentioned here. If I was to pick
>> just one, I'd keep the former and drop the latter.
> It’s always quite difficult in these releases to help express to people exactly what’s happened.  We’ve got over 1000 changesets — what have we been doing?  If my star chart is correct, the latter represents nearly 1700 extra lines of codes in tools/tests/x86_emulator/predicates.c.  It’s actually a reasonable chunk of code churn, which I think is worth highlighting.

I agree with Jan.  New concrete instruction groups are useful for an end
user to read.  "We refactored some internal of a test harness" isn't,
especially when it would most likely be repeated every release.

I'd drop the latter line and just keep the former.

~Andrew

Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation

[Jan Beulich]

On 25.03.2021 10:37, Andrew Cooper wrote:
> On 25/03/2021 09:04, George Dunlap wrote:
>>> On Mar 25, 2021, at 7:57 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>> On 24.03.2021 17:44, George Dunlap wrote:
>>>> --- a/CHANGELOG.md
>>>> +++ b/CHANGELOG.md
>>>> @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>>>>  - Named PCI devices for xl/libxl
>>>>  - Support for zstd-compressed dom0 kernels
>>>>  - Library improvements from NetBSD ports upstreamed
>>>> + - x86_emulate: Support AVX-VNNI instructions
>>>> + - x86_emulate: Expanded testing for several instruction classes
>>> TBH both seem too minor to me to be mentioned here. If I was to pick
>>> just one, I'd keep the former and drop the latter.
>> It’s always quite difficult in these releases to help express to people exactly what’s happened.  We’ve got over 1000 changesets — what have we been doing?  If my star chart is correct, the latter represents nearly 1700 extra lines of codes in tools/tests/x86_emulator/predicates.c.  It’s actually a reasonable chunk of code churn, which I think is worth highlighting.
> 
> I agree with Jan.  New concrete instruction groups are useful for an end
> user to read.  "We refactored some internal of a test harness" isn't,
> especially when it would most likely be repeated every release.
> 
> I'd drop the latter line and just keep the former.

And then perhaps also not focus on the emulator, but merely on the
fact that guests now can use that ISA extension (for which the
emulator change is a [the only] prereq)?

Jan

Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation

[George Dunlap]

> On Mar 25, 2021, at 1:58 PM, Jan Beulich <JBeulich@suse.com> wrote:
> 
> On 25.03.2021 10:37, Andrew Cooper wrote:
>> On 25/03/2021 09:04, George Dunlap wrote:
>>>> On Mar 25, 2021, at 7:57 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 24.03.2021 17:44, George Dunlap wrote:
>>>>> --- a/CHANGELOG.md
>>>>> +++ b/CHANGELOG.md
>>>>> @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>>>>> - Named PCI devices for xl/libxl
>>>>> - Support for zstd-compressed dom0 kernels
>>>>> - Library improvements from NetBSD ports upstreamed
>>>>> + - x86_emulate: Support AVX-VNNI instructions
>>>>> + - x86_emulate: Expanded testing for several instruction classes
>>>> TBH both seem too minor to me to be mentioned here. If I was to pick
>>>> just one, I'd keep the former and drop the latter.
>>> It’s always quite difficult in these releases to help express to people exactly what’s happened.  We’ve got over 1000 changesets — what have we been doing?  If my star chart is correct, the latter represents nearly 1700 extra lines of codes in tools/tests/x86_emulator/predicates.c.  It’s actually a reasonable chunk of code churn, which I think is worth highlighting.
>> 
>> I agree with Jan.  New concrete instruction groups are useful for an end
>> user to read.  "We refactored some internal of a test harness" isn't,
>> especially when it would most likely be repeated every release.
>> 
>> I'd drop the latter line and just keep the former.
> 
> And then perhaps also not focus on the emulator, but merely on the
> fact that guests now can use that ISA extension (for which the
> emulator change is a [the only] prereq)?

Would you mind giving a concrete suggestion?

Thanks,
 -George

Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation

[Jan Beulich]

On 29.03.2021 18:06, George Dunlap wrote:
> 
> 
>> On Mar 25, 2021, at 1:58 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>
>> On 25.03.2021 10:37, Andrew Cooper wrote:
>>> On 25/03/2021 09:04, George Dunlap wrote:
>>>>> On Mar 25, 2021, at 7:57 AM, Jan Beulich <jbeulich@suse.com> wrote:
>>>>> On 24.03.2021 17:44, George Dunlap wrote:
>>>>>> --- a/CHANGELOG.md
>>>>>> +++ b/CHANGELOG.md
>>>>>> @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>>>>>> - Named PCI devices for xl/libxl
>>>>>> - Support for zstd-compressed dom0 kernels
>>>>>> - Library improvements from NetBSD ports upstreamed
>>>>>> + - x86_emulate: Support AVX-VNNI instructions
>>>>>> + - x86_emulate: Expanded testing for several instruction classes
>>>>> TBH both seem too minor to me to be mentioned here. If I was to pick
>>>>> just one, I'd keep the former and drop the latter.
>>>> It’s always quite difficult in these releases to help express to people exactly what’s happened.  We’ve got over 1000 changesets — what have we been doing?  If my star chart is correct, the latter represents nearly 1700 extra lines of codes in tools/tests/x86_emulator/predicates.c.  It’s actually a reasonable chunk of code churn, which I think is worth highlighting.
>>>
>>> I agree with Jan.  New concrete instruction groups are useful for an end
>>> user to read.  "We refactored some internal of a test harness" isn't,
>>> especially when it would most likely be repeated every release.
>>>
>>> I'd drop the latter line and just keep the former.
>>
>> And then perhaps also not focus on the emulator, but merely on the
>> fact that guests now can use that ISA extension (for which the
>> emulator change is a [the only] prereq)?
> 
> Would you mind giving a concrete suggestion?

x86: Allow domains to use AVX-VNNI instructions

Jan

[PATCH 6/6] CHANGELOG.md: Add entries for CI loop

[George Dunlap]

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Doug Goldstein <cardoe@cardoe.com>
---
 CHANGELOG.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index df6c638152..15a22d6bde 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,6 +16,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
  - Library improvements from NetBSD ports upstreamed
  - x86_emulate: Support AVX-VNNI instructions
  - x86_emulate: Expanded testing for several instruction classes
+ - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6
+ - CI loop: Add dom0less aarch64 smoke test
 
 ## Removed / support downgraded
 
-- 
2.30.2

Re: [PATCH 6/6] CHANGELOG.md: Add entries for CI loop

[Stefano Stabellini]

On Wed, 24 Mar 2021, George Dunlap wrote:
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
> ---
> CC: Wei Liu <wl@xen.org>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Doug Goldstein <cardoe@cardoe.com>
> ---
>  CHANGELOG.md | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index df6c638152..15a22d6bde 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -16,6 +16,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>   - Library improvements from NetBSD ports upstreamed
>   - x86_emulate: Support AVX-VNNI instructions
>   - x86_emulate: Expanded testing for several instruction classes
> + - CI loop: Add Alpine Linux, Ubuntu Focal targets; drop CentOS 6
> + - CI loop: Add dom0less aarch64 smoke test

We also have a full Dom0+DomU test on ARM using xl to create the guest,
see automation/scripts/qemu-alpine-arm64.sh

Re: [PATCH 1/6] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries

[Jan Beulich]

On 24.03.2021 17:44, George Dunlap wrote:
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -247,6 +247,13 @@ Export hypervisor coverage data suitable for analysis by gcov or lcov.
>  
>      Status: Supported, Not security supported
>  
> +### Processor trace support
> +
> +Support for using Intel Processor Trace technology to trace guests
> +from dom0.
> +
> +    Status: Tech Preview

While it may not strictly be needed here, perhaps for consistency with
other entries

    Status, x86: Tech Preview

?

This minor aspect aside,
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan

Re: [PATCH 1/6] Intel Processor Trace Support: Add CHANGELOG.md and SUPPORT.md entries

[George Dunlap]

> On Mar 25, 2021, at 7:53 AM, Jan Beulich <jbeulich@suse.com> wrote:
> 
> On 24.03.2021 17:44, George Dunlap wrote:
>> --- a/SUPPORT.md
>> +++ b/SUPPORT.md
>> @@ -247,6 +247,13 @@ Export hypervisor coverage data suitable for analysis by gcov or lcov.
>> 
>>     Status: Supported, Not security supported
>> 
>> +### Processor trace support
>> +
>> +Support for using Intel Processor Trace technology to trace guests
>> +from dom0.
>> +
>> +    Status: Tech Preview
> 
> While it may not strictly be needed here, perhaps for consistency with
> other entries
> 
>    Status, x86: Tech Preview

Yes, that sounds good.

 -George