From: Pu Wen <puwen@hygon.cn>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] SVM: Add union intstat_t for offset 68h in vmcb struct
Date: Wed, 25 Mar 2020 23:23:36 +0800 [thread overview]
Message-ID: <772e041d-a91a-e67c-1243-530065b2f628@hygon.cn> (raw)
In-Reply-To: <20200325103054.GA28601@Air-de-Roger>
On 2020/3/25 18:30, Roger Pau Monné wrote:
> On Tue, Mar 24, 2020 at 06:37:26PM +0800, Pu Wen wrote:
>> diff --git a/xen/include/asm-x86/hvm/svm/vmcb.h b/xen/include/asm-x86/hvm/svm/vmcb.h
>> index b9e389d481..d8a3285752 100644
>> --- a/xen/include/asm-x86/hvm/svm/vmcb.h
>> +++ b/xen/include/asm-x86/hvm/svm/vmcb.h
>> @@ -316,6 +316,17 @@ typedef union
>> uint64_t raw;
>> } intinfo_t;
>>
>> +typedef union
>> +{
>> + struct
>> + {
>> + u64 intr_shadow: 1;
>> + u64 guest_intr_mask:1;
>> + u64 resvd: 62;
>
> Could you also use uint64_t for the fields, like you do below for
> raw?
Ok, thanks. Maybe bool for intr_shadow and guest_intr_mask is better?
--
Regards,
Pu Wen
next prev parent reply other threads:[~2020-03-25 15:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 10:37 [Xen-devel] [PATCH v2] SVM: Add union intstat_t for offset 68h in vmcb struct Pu Wen
2020-03-24 11:55 ` Jan Beulich
2020-03-25 15:21 ` Pu Wen
2020-03-24 12:28 ` Andrew Cooper
2020-03-25 15:22 ` Pu Wen
2020-03-25 15:56 ` Andrew Cooper
2020-03-26 10:16 ` Wen Pu
2020-03-25 10:30 ` Roger Pau Monné
2020-03-25 15:23 ` Pu Wen [this message]
2020-03-25 16:03 ` Andrew Cooper
2020-03-26 10:16 ` Wen Pu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=772e041d-a91a-e67c-1243-530065b2f628@hygon.cn \
--to=puwen@hygon.cn \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).