From: Pu Wen <puwen@hygon.cn>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
<xen-devel@lists.xenproject.org>
Cc: "Wei Liu" <wl@xen.org>, "Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] SVM: Add union intstat_t for offset 68h in vmcb struct
Date: Wed, 25 Mar 2020 23:22:37 +0800 [thread overview]
Message-ID: <ee018b0a-6b92-4e87-1d22-c8839393f800@hygon.cn> (raw)
In-Reply-To: <f82b6a33-6af6-8c9d-2876-b518167eb832@citrix.com>
On 2020/3/24 20:28, Andrew Cooper wrote:
> Hmm - this field doesn't appear to be part of AVIC, which makes me
> wonder what we're doing without it.
>
> It appears to be a shadow copy of EFLAGS.IF which is only written on
> vmexit, and never consumed, but this is based on Appendix B which is the
> only reference I can find to the field at all. Neither the
> VMRUN/#VMEXIT descriptions discuss it at all.
>
> Given its position next to the (ambiguous) INTERRUPT_SHADOW, it just
> might actually distinguish the STI shadow from the MovSS shadow, but it
> could only do that by not behaving as described, and being asymmetric
> with EFLAGS. I don't have time to investigate this right now.
>
> We need the field described in Xen to set it appropriately for virtual
> vmexit, but I think that is the extent of what we need to do.
We encountered problem while running xen with new firmware which
implement the bit[1] of the VMCB offset 68h: the DomU stopped when
running seabios. We debugged the seabios code and found that the
seabios hung after call16_int10().
Then we debugged the xen code, and found the cause at this place in
svm_get_interrupt_shadow():
if ( vmcb->interrupt_shadow )
intr_shadow |= HVM_INTR_SHADOW_MOV_SS | HVM_INTR_SHADOW_STI;
the conditional is true if bit[1] is 1 even though bit[0] is zero.
If just only use bit[0] in the conditional, the problem is solved, DomU
will run successfully.
--
Regards,
Pu Wen
next prev parent reply other threads:[~2020-03-25 15:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 10:37 [Xen-devel] [PATCH v2] SVM: Add union intstat_t for offset 68h in vmcb struct Pu Wen
2020-03-24 11:55 ` Jan Beulich
2020-03-25 15:21 ` Pu Wen
2020-03-24 12:28 ` Andrew Cooper
2020-03-25 15:22 ` Pu Wen [this message]
2020-03-25 15:56 ` Andrew Cooper
2020-03-26 10:16 ` Wen Pu
2020-03-25 10:30 ` Roger Pau Monné
2020-03-25 15:23 ` Pu Wen
2020-03-25 16:03 ` Andrew Cooper
2020-03-26 10:16 ` Wen Pu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee018b0a-6b92-4e87-1d22-c8839393f800@hygon.cn \
--to=puwen@hygon.cn \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).