From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: pbonzini@redhat.com, f4bug@amsat.org, qemu-devel@nongnu.org,
xen-devel@lists.xen.org
Subject: Re: [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit
Date: Wed, 07 Jun 2017 17:20:59 +0000 [thread overview]
Message-ID: <CAJ+F1CLEJeeQqHRA5=P+_0wri-cXffi4SSkuTeF1LBzACB_8bw@mail.gmail.com> (raw)
In-Reply-To: <20170607164115.GE1919@perard.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1325 bytes --]
Hi
On Wed, Jun 7, 2017 at 8:57 PM Anthony PERARD <anthony.perard@citrix.com>
wrote:
> On Mon, May 29, 2017 at 12:45:43PM +0400, Marc-André Lureau wrote:
> > Move all the fronted struct and methods to a seperate unit. This avoids
> > accidentally mixing backend and frontend calls, and helps with
> readibilty.
> >
> > Make qemu_chr_replay() a macro shared by both char and char-fe.
> >
> > Export qemu_chr_write(), and use a macro for qemu_chr_write_all()
> >
> > (nb: yes, CharBackend is for char frontend :)
>
> Hi Marc-André,
>
> Following this patch, we are not able anymore to launch QEMU with
> -monitor /dev/null.
> > qemu-system-i386: -monitor /dev/null: 'tty' is not a valid char driver
> name
>
> FYI, the full command line used:
> /usr/lib/xen/bin/qemu-system-i386 -xen-domid 0 \
> -xen-attach -name dom0 -nographic -M xenpv -daemonize \
> -monitor /dev/null -serial /dev/null -parallel /dev/null \
> -nodefaults -no-user-config \
> -pidfile /var/run/xen/qemu-dom0.pid
>
>
My bad, and the worse is that CI actually gave me some hints of the
regression because the ChardevAlias array was empty.
I dropped char-serial.h and char-parellel.h in this patch, it shouldn't be.
I'll send fixes and add some tests.
Thanks for the report!
--
Marc-André Lureau
[-- Attachment #1.2: Type: text/html, Size: 1814 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-06-07 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170529084546.26500-1-marcandre.lureau@redhat.com>
[not found] ` <20170529084546.26500-12-marcandre.lureau@redhat.com>
2017-06-07 16:41 ` [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit Anthony PERARD
2017-06-07 17:20 ` Marc-André Lureau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1CLEJeeQqHRA5=P+_0wri-cXffi4SSkuTeF1LBzACB_8bw@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).