* Re: [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit [not found] ` <20170529084546.26500-12-marcandre.lureau@redhat.com> @ 2017-06-07 16:41 ` Anthony PERARD 2017-06-07 17:20 ` Marc-André Lureau 0 siblings, 1 reply; 2+ messages in thread From: Anthony PERARD @ 2017-06-07 16:41 UTC (permalink / raw) To: Marc-André Lureau; +Cc: pbonzini, xen-devel, qemu-devel, f4bug On Mon, May 29, 2017 at 12:45:43PM +0400, Marc-André Lureau wrote: > Move all the fronted struct and methods to a seperate unit. This avoids > accidentally mixing backend and frontend calls, and helps with readibilty. > > Make qemu_chr_replay() a macro shared by both char and char-fe. > > Export qemu_chr_write(), and use a macro for qemu_chr_write_all() > > (nb: yes, CharBackend is for char frontend :) Hi Marc-André, Following this patch, we are not able anymore to launch QEMU with -monitor /dev/null. > qemu-system-i386: -monitor /dev/null: 'tty' is not a valid char driver name FYI, the full command line used: /usr/lib/xen/bin/qemu-system-i386 -xen-domid 0 \ -xen-attach -name dom0 -nographic -M xenpv -daemonize \ -monitor /dev/null -serial /dev/null -parallel /dev/null \ -nodefaults -no-user-config \ -pidfile /var/run/xen/qemu-dom0.pid Regards, -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit 2017-06-07 16:41 ` [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit Anthony PERARD @ 2017-06-07 17:20 ` Marc-André Lureau 0 siblings, 0 replies; 2+ messages in thread From: Marc-André Lureau @ 2017-06-07 17:20 UTC (permalink / raw) To: Anthony PERARD; +Cc: pbonzini, f4bug, qemu-devel, xen-devel [-- Attachment #1.1: Type: text/plain, Size: 1325 bytes --] Hi On Wed, Jun 7, 2017 at 8:57 PM Anthony PERARD <anthony.perard@citrix.com> wrote: > On Mon, May 29, 2017 at 12:45:43PM +0400, Marc-André Lureau wrote: > > Move all the fronted struct and methods to a seperate unit. This avoids > > accidentally mixing backend and frontend calls, and helps with > readibilty. > > > > Make qemu_chr_replay() a macro shared by both char and char-fe. > > > > Export qemu_chr_write(), and use a macro for qemu_chr_write_all() > > > > (nb: yes, CharBackend is for char frontend :) > > Hi Marc-André, > > Following this patch, we are not able anymore to launch QEMU with > -monitor /dev/null. > > qemu-system-i386: -monitor /dev/null: 'tty' is not a valid char driver > name > > FYI, the full command line used: > /usr/lib/xen/bin/qemu-system-i386 -xen-domid 0 \ > -xen-attach -name dom0 -nographic -M xenpv -daemonize \ > -monitor /dev/null -serial /dev/null -parallel /dev/null \ > -nodefaults -no-user-config \ > -pidfile /var/run/xen/qemu-dom0.pid > > My bad, and the worse is that CI actually gave me some hints of the regression because the ChardevAlias array was empty. I dropped char-serial.h and char-parellel.h in this patch, it shouldn't be. I'll send fixes and add some tests. Thanks for the report! -- Marc-André Lureau [-- Attachment #1.2: Type: text/html, Size: 1814 bytes --] [-- Attachment #2: Type: text/plain, Size: 127 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-07 17:20 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20170529084546.26500-1-marcandre.lureau@redhat.com> [not found] ` <20170529084546.26500-12-marcandre.lureau@redhat.com> 2017-06-07 16:41 ` [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit Anthony PERARD 2017-06-07 17:20 ` Marc-André Lureau
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).