From: Anthony PERARD <anthony.perard@citrix.com>
To: Nick Rosbrook <rosbrookn@gmail.com>
Cc: <xen-devel@lists.xenproject.org>, <george.dunlap@citrix.com>,
"Nick Rosbrook" <rosbrookn@ainfosec.com>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [RFC v2 5/7] libxl: add device function definitions to libxl_types.idl
Date: Tue, 4 May 2021 16:43:27 +0100 [thread overview]
Message-ID: <YJFrn7+4AQt7K2Fa@perard> (raw)
In-Reply-To: <2cd96b7e884c6f0c2667ef7499ff7179b99ea635.1614734296.git.rosbrookn@ainfosec.com>
On Tue, Mar 02, 2021 at 08:46:17PM -0500, Nick Rosbrook wrote:
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 5b85a7419f..550af7a1c7 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -666,6 +668,24 @@ libxl_device_vfb = Struct("device_vfb", [
> ("keymap", string),
> ])
>
> +libxl_device_vfb_add = DeviceAddFunction("device_vfb_add",
> + device_param=("vfb", libxl_device_vfb),
> + extra_params=[("ao_how", libxl_asyncop_how)],
> + return_type=libxl_error
> +)
> +
> +libxl_device_vfb_remove = DeviceRemoveFunction("device_vfb_remove",
> + device_param=("vfb", libxl_device_vfb),
> + extra_params=[("ao_how", libxl_asyncop_how)],
> + return_type=libxl_error
> +)
> +
> +libxl_device_vfb_destroy = DeviceDestroyFunction("device_vfb_destroy",
> + device_param=("vfb", libxl_device_vfb),
> + extra_params=[("ao_how", libxl_asyncop_how)],
> + return_type=libxl_error
> +)
> +
> libxl_device_vkb = Struct("device_vkb", [
> ("backend_domid", libxl_domid),
> ("backend_domname", string),
In future version of the series that is deem ready, I think it would be
useful to have this change in libxl_types.idl and the change that remove
the macro call from the C file in the same patch. It would make it
possible to review discrepancies.
The change in the idl for vfb is different that the change in the C
file:
> --- a/tools/libs/light/libxl_console.c
> +++ b/tools/libs/light/libxl_console.c
> @@ -723,8 +723,6 @@ static LIBXL_DEFINE_UPDATE_DEVID(vfb)
> static LIBXL_DEFINE_DEVICE_FROM_TYPE(vfb)
>
> /* vfb */
> -LIBXL_DEFINE_DEVICE_REMOVE(vfb)
> -
> DEFINE_DEVICE_TYPE_STRUCT(vfb, VFB, vfbs,
> .skip_attach = 1,
> .set_xenstore_config = (device_set_xenstore_config_fn_t)
No add function ;-)
And libxl doesn't build anymore with the last patch applied. They are
maybe also issues with functions that are static and thus are not
accessible from other c files.
Cheers,
--
Anthony PERARD
next prev parent reply other threads:[~2021-05-04 15:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 1:46 [RFC v2 0/7] add function support to IDL Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 1/7] libxl: remove extra whitespace from gentypes.py Nick Rosbrook
2021-05-04 14:39 ` Anthony PERARD
2021-03-03 1:46 ` [RFC v2 2/7] libxl: add Function class to IDL Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 3/7] libxl: add PASS_BY_CONST_REFERENCE to idl Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 4/7] libxl: add DeviceFunction classes to IDL Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 5/7] libxl: add device function definitions to libxl_types.idl Nick Rosbrook
2021-05-04 15:43 ` Anthony PERARD [this message]
2021-05-04 17:26 ` Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 6/7] libxl: implement device add/remove/destroy functions generation Nick Rosbrook
2021-05-04 15:02 ` Anthony PERARD
2021-05-04 17:29 ` Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 7/7] libxl: replace LIBXL_DEFINE_DEVICE* macro usage with generated code Nick Rosbrook
2021-03-03 9:48 ` [RFC v2 0/7] add function support to IDL Ian Jackson
2021-03-03 13:41 ` Nick Rosbrook
2021-04-21 21:28 ` Nick Rosbrook
2021-05-04 15:46 ` Anthony PERARD
2021-05-04 17:31 ` Nick Rosbrook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJFrn7+4AQt7K2Fa@perard \
--to=anthony.perard@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=rosbrookn@ainfosec.com \
--cc=rosbrookn@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).