* [PATCH v1] tools: fix incorrect suggestions for XENCONSOLED_TRACE on FreeBSD
@ 2021-05-04 13:50 Olaf Hering
2021-05-04 17:47 ` Andrew Cooper
0 siblings, 1 reply; 4+ messages in thread
From: Olaf Hering @ 2021-05-04 13:50 UTC (permalink / raw)
To: xen-devel; +Cc: Olaf Hering, Ian Jackson, Wei Liu
--log does not take a file, it specifies what is supposed to be logged.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
tools/hotplug/FreeBSD/rc.d/xencommons.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in b/tools/hotplug/FreeBSD/rc.d/xencommons.in
index ccd5a9b055..36dd717944 100644
--- a/tools/hotplug/FreeBSD/rc.d/xencommons.in
+++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in
@@ -23,7 +23,7 @@ required_files="/dev/xen/xenstored"
XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
-#XENCONSOLED_TRACE="@XEN_LOG_DIR@/xenconsole-trace.log"
+#XENCONSOLED_TRACE="none|guest|hv|all"
#XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"
load_rc_config $name
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] tools: fix incorrect suggestions for XENCONSOLED_TRACE on FreeBSD
2021-05-04 13:50 [PATCH v1] tools: fix incorrect suggestions for XENCONSOLED_TRACE on FreeBSD Olaf Hering
@ 2021-05-04 17:47 ` Andrew Cooper
2021-05-06 14:36 ` Olaf Hering
2021-05-07 7:25 ` Roger Pau Monné
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Cooper @ 2021-05-04 17:47 UTC (permalink / raw)
To: Olaf Hering, xen-devel; +Cc: Ian Jackson, Wei Liu, Roger Pau Monné
On 04/05/2021 14:50, Olaf Hering wrote:
> --log does not take a file, it specifies what is supposed to be logged.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>. That said, ...
> ---
> tools/hotplug/FreeBSD/rc.d/xencommons.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in b/tools/hotplug/FreeBSD/rc.d/xencommons.in
> index ccd5a9b055..36dd717944 100644
> --- a/tools/hotplug/FreeBSD/rc.d/xencommons.in
> +++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in
> @@ -23,7 +23,7 @@ required_files="/dev/xen/xenstored"
>
> XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
> XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
> -#XENCONSOLED_TRACE="@XEN_LOG_DIR@/xenconsole-trace.log"
> +#XENCONSOLED_TRACE="none|guest|hv|all"
> #XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"
It would probably be clearer to untangle these in one go, leaving the
result looking like:
XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
#XENCONSOLED_TRACE="none|guest|hv|all"
XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
#XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"
I'd also be tempted to fold this and the NetBSD change together. It's
not as if these bugfixes are distro-specific.
It looks like a bug in NetBSD in c/s 2e8644e1d90, which was copied into
FreeBSD by c/s 5dcdb2bf569. (P.S. Sorry Roger - both your bugs,
starting from a decade ago). It really is idiotic that we've got a
commonly named *_TRACE variable with totally different semantics for the
two daemons. Then again, its far too late to fix this :(
~Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] tools: fix incorrect suggestions for XENCONSOLED_TRACE on FreeBSD
2021-05-04 17:47 ` Andrew Cooper
@ 2021-05-06 14:36 ` Olaf Hering
2021-05-07 7:25 ` Roger Pau Monné
1 sibling, 0 replies; 4+ messages in thread
From: Olaf Hering @ 2021-05-06 14:36 UTC (permalink / raw)
To: Andrew Cooper; +Cc: xen-devel, Ian Jackson, Wei Liu, Roger Pau Monné
[-- Attachment #1: Type: text/plain, Size: 270 bytes --]
Am Tue, 4 May 2021 18:47:12 +0100
schrieb Andrew Cooper <andrew.cooper3@citrix.com>:
> I'd also be tempted to fold this and the NetBSD change together. It's
> not as if these bugfixes are distro-specific.
I will redo the BSD patches as you suggested.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] tools: fix incorrect suggestions for XENCONSOLED_TRACE on FreeBSD
2021-05-04 17:47 ` Andrew Cooper
2021-05-06 14:36 ` Olaf Hering
@ 2021-05-07 7:25 ` Roger Pau Monné
1 sibling, 0 replies; 4+ messages in thread
From: Roger Pau Monné @ 2021-05-07 7:25 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Olaf Hering, xen-devel, Ian Jackson, Wei Liu
On Tue, May 04, 2021 at 06:47:12PM +0100, Andrew Cooper wrote:
> On 04/05/2021 14:50, Olaf Hering wrote:
> > --log does not take a file, it specifies what is supposed to be logged.
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>. That said, ...
>
> > ---
> > tools/hotplug/FreeBSD/rc.d/xencommons.in | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in b/tools/hotplug/FreeBSD/rc.d/xencommons.in
> > index ccd5a9b055..36dd717944 100644
> > --- a/tools/hotplug/FreeBSD/rc.d/xencommons.in
> > +++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in
> > @@ -23,7 +23,7 @@ required_files="/dev/xen/xenstored"
> >
> > XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
> > XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
> > -#XENCONSOLED_TRACE="@XEN_LOG_DIR@/xenconsole-trace.log"
> > +#XENCONSOLED_TRACE="none|guest|hv|all"
> > #XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"
>
> It would probably be clearer to untangle these in one go, leaving the
> result looking like:
>
> XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
> #XENCONSOLED_TRACE="none|guest|hv|all"
>
> XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
> #XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"
>
> I'd also be tempted to fold this and the NetBSD change together. It's
> not as if these bugfixes are distro-specific.
>
>
> It looks like a bug in NetBSD in c/s 2e8644e1d90, which was copied into
> FreeBSD by c/s 5dcdb2bf569. (P.S. Sorry Roger - both your bugs,
> starting from a decade ago). It really is idiotic that we've got a
> commonly named *_TRACE variable with totally different semantics for the
> two daemons. Then again, its far too late to fix this :(
Ups, sorry. Feel free to fix those in one go, and add my:
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-07 7:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-04 13:50 [PATCH v1] tools: fix incorrect suggestions for XENCONSOLED_TRACE on FreeBSD Olaf Hering
2021-05-04 17:47 ` Andrew Cooper
2021-05-06 14:36 ` Olaf Hering
2021-05-07 7:25 ` Roger Pau Monné
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).