From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>, Hongyan Xia <hx242@xen.org>
Cc: xen-devel@lists.xenproject.org,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/6] x86_64/mm: map and unmap page tables in cleanup_frame_table
Date: Fri, 24 Apr 2020 13:12:59 +0200 [thread overview]
Message-ID: <aba8fe76-9a7a-7099-c04f-0ce36eaac1f8@suse.com> (raw)
In-Reply-To: <a1caa70d-9c7a-b0c2-d7cf-1893db8f0ac4@xen.org>
On 24.04.2020 11:02, Julien Grall wrote:
> On 17/04/2020 10:52, Hongyan Xia wrote:
>> @@ -763,10 +763,10 @@ static void cleanup_frame_table(struct mem_hotadd_info *info)
>> continue;
>> }
>> - ASSERT(l1e_get_flags(l2e_to_l1e(l2e)[l1_table_offset(sva)]) &
>> - _PAGE_PRESENT);
>> - sva = (sva & ~((1UL << PAGE_SHIFT) - 1)) +
>> - (1UL << PAGE_SHIFT);
>> + ASSERT(l1e_get_flags(l1e_from_l2e(l2e, l1_table_offset(sva))) &
>> + _PAGE_PRESENT);
>> +
>> + sva = (sva & ~((1UL << PAGE_SHIFT) - 1)) + (1UL << PAGE_SHIFT);
>
> NIT: While you are modifying the indentation. Couldn't we use PAGE_MASK and PAGE_SIZE here?
Oh, yes, this would be nice.
Jan
next prev parent reply other threads:[~2020-04-24 11:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 9:52 [PATCH 0/6] convert more Xen page table code to the new API Hongyan Xia
2020-04-17 9:52 ` [PATCH 1/6] x86_64/mm: map and unmap page tables in cleanup_frame_table Hongyan Xia
2020-04-24 8:58 ` Julien Grall
2020-04-24 8:59 ` Julien Grall
2020-04-24 8:59 ` Julien Grall
2020-04-24 9:21 ` Hongyan Xia
2020-04-24 9:24 ` Julien Grall
2020-04-24 9:02 ` Julien Grall
2020-04-24 11:12 ` Jan Beulich [this message]
2020-04-28 15:11 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 2/6] x86_64/mm: map and unmap page tables in subarch_init_memory Hongyan Xia
2020-04-24 9:04 ` Julien Grall
2020-04-28 15:12 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 3/6] x86_64/mm: map and unmap page tables in subarch_memory_op Hongyan Xia
2020-04-24 9:06 ` Julien Grall
2020-04-28 15:23 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 4/6] x86/smpboot: map and unmap page tables in cleanup_cpu_root_pgt Hongyan Xia
2020-04-24 9:13 ` Julien Grall
2020-04-28 15:26 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 5/6] x86/pv: map and unmap page tables in mark_pv_pt_pages_rdonly Hongyan Xia
2020-04-24 9:16 ` Julien Grall
2020-04-28 15:33 ` Jan Beulich
2020-04-28 15:49 ` Wei Liu
2020-04-28 15:55 ` Hongyan Xia
2020-04-28 15:59 ` Hongyan Xia
2020-04-29 9:26 ` Hongyan Xia
2020-04-29 11:04 ` Jan Beulich
2020-04-29 12:29 ` Hongyan Xia
2020-04-29 13:31 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 6/6] x86/pv: map and unmap page table in dom0_construct_pv Hongyan Xia
2020-04-24 9:18 ` Julien Grall
2020-04-28 15:34 ` Jan Beulich
2020-04-24 8:07 ` [PATCH 0/6] convert more Xen page table code to the new API Hongyan Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aba8fe76-9a7a-7099-c04f-0ce36eaac1f8@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=hx242@xen.org \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).