From: Hongyan Xia <hx242@xen.org>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 1/6] x86_64/mm: map and unmap page tables in cleanup_frame_table
Date: Fri, 24 Apr 2020 10:21:59 +0100 [thread overview]
Message-ID: <ba87751e66decae06118bbdf607a89d1406cb3e8.camel@xen.org> (raw)
In-Reply-To: <ca9b1554-2c91-35f4-2e6b-b7d4985b638d@xen.org>
Hi Julien,
On Fri, 2020-04-24 at 09:59 +0100, Julien Grall wrote:
> (resending)
>
> On 17/04/2020 10:52, Hongyan Xia wrote:
> > From: Wei Liu <wei.liu2@citrix.com>
> >
> > Also fix a weird indentation.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > Signed-off-by: Hongyan Xia <hongyxia@amazon.com>
> > ---
> > xen/arch/x86/x86_64/mm.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c
> > index e85ef449f3..18210405f4 100644
> > --- a/xen/arch/x86/x86_64/mm.c
> > +++ b/xen/arch/x86/x86_64/mm.c
> > @@ -737,8 +737,8 @@ static void cleanup_frame_table(struct
> > mem_hotadd_info *info)
> >
> > while (sva < eva)
> > {
> > - l3e = l4e_to_l3e(idle_pg_table[l4_table_offset(sva)])[
> > - l3_table_offset(sva)];
> > + l3e = l3e_from_l4e(idle_pg_table[l4_table_offset(sva)],
> > + l3_table_offset(sva));
>
> This macro doesn't exist yet in the tree. It would be good to spell
> out
> the dependencies in the cover letter so this doesn't get merged
> before
> the dependency is merged.
I believe the introduction of the new macros has been merged in staging
as 6c8afe5aadb33761431b24157d99b25eac15fc7e.
> Reviewed-by: Julien Grall <jgrall@amazon.com>
Thanks!
Hongyan
next prev parent reply other threads:[~2020-04-24 9:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 9:52 [PATCH 0/6] convert more Xen page table code to the new API Hongyan Xia
2020-04-17 9:52 ` [PATCH 1/6] x86_64/mm: map and unmap page tables in cleanup_frame_table Hongyan Xia
2020-04-24 8:58 ` Julien Grall
2020-04-24 8:59 ` Julien Grall
2020-04-24 8:59 ` Julien Grall
2020-04-24 9:21 ` Hongyan Xia [this message]
2020-04-24 9:24 ` Julien Grall
2020-04-24 9:02 ` Julien Grall
2020-04-24 11:12 ` Jan Beulich
2020-04-28 15:11 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 2/6] x86_64/mm: map and unmap page tables in subarch_init_memory Hongyan Xia
2020-04-24 9:04 ` Julien Grall
2020-04-28 15:12 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 3/6] x86_64/mm: map and unmap page tables in subarch_memory_op Hongyan Xia
2020-04-24 9:06 ` Julien Grall
2020-04-28 15:23 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 4/6] x86/smpboot: map and unmap page tables in cleanup_cpu_root_pgt Hongyan Xia
2020-04-24 9:13 ` Julien Grall
2020-04-28 15:26 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 5/6] x86/pv: map and unmap page tables in mark_pv_pt_pages_rdonly Hongyan Xia
2020-04-24 9:16 ` Julien Grall
2020-04-28 15:33 ` Jan Beulich
2020-04-28 15:49 ` Wei Liu
2020-04-28 15:55 ` Hongyan Xia
2020-04-28 15:59 ` Hongyan Xia
2020-04-29 9:26 ` Hongyan Xia
2020-04-29 11:04 ` Jan Beulich
2020-04-29 12:29 ` Hongyan Xia
2020-04-29 13:31 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 6/6] x86/pv: map and unmap page table in dom0_construct_pv Hongyan Xia
2020-04-24 9:18 ` Julien Grall
2020-04-28 15:34 ` Jan Beulich
2020-04-24 8:07 ` [PATCH 0/6] convert more Xen page table code to the new API Hongyan Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba87751e66decae06118bbdf607a89d1406cb3e8.camel@xen.org \
--to=hx242@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).