From: Jan Beulich <jbeulich@suse.com>
To: Hongyan Xia <hx242@xen.org>, Wei Liu <wl@xen.org>
Cc: xen-devel@lists.xenproject.org,
"Roger Pau Monné" <roger.pau@citrix.com>,
julien@xen.org, "Andrew Cooper" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 5/6] x86/pv: map and unmap page tables in mark_pv_pt_pages_rdonly
Date: Tue, 28 Apr 2020 17:33:29 +0200 [thread overview]
Message-ID: <fbb4a755-c450-77dd-2aa5-44c01b42a5ff@suse.com> (raw)
In-Reply-To: <9287363e13924f4a633b47b53c23b3466e26e4a8.1587116799.git.hongyxia@amazon.com>
On 17.04.2020 11:52, Hongyan Xia wrote:
> --- a/xen/arch/x86/pv/dom0_build.c
> +++ b/xen/arch/x86/pv/dom0_build.c
> @@ -50,17 +50,17 @@ static __init void mark_pv_pt_pages_rdonly(struct domain *d,
> unsigned long count;
> struct page_info *page;
> l4_pgentry_t *pl4e;
> - l3_pgentry_t *pl3e;
> - l2_pgentry_t *pl2e;
> - l1_pgentry_t *pl1e;
> + l3_pgentry_t *pl3e, *l3t;
> + l2_pgentry_t *pl2e, *l2t;
> + l1_pgentry_t *pl1e, *l1t;
I don't quite see why the new local variables get introduced:
unmap_domain_page(), iirc, is quite fine with a non-page-
aligned argument.
Jan
next prev parent reply other threads:[~2020-04-28 15:33 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 9:52 [PATCH 0/6] convert more Xen page table code to the new API Hongyan Xia
2020-04-17 9:52 ` [PATCH 1/6] x86_64/mm: map and unmap page tables in cleanup_frame_table Hongyan Xia
2020-04-24 8:58 ` Julien Grall
2020-04-24 8:59 ` Julien Grall
2020-04-24 8:59 ` Julien Grall
2020-04-24 9:21 ` Hongyan Xia
2020-04-24 9:24 ` Julien Grall
2020-04-24 9:02 ` Julien Grall
2020-04-24 11:12 ` Jan Beulich
2020-04-28 15:11 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 2/6] x86_64/mm: map and unmap page tables in subarch_init_memory Hongyan Xia
2020-04-24 9:04 ` Julien Grall
2020-04-28 15:12 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 3/6] x86_64/mm: map and unmap page tables in subarch_memory_op Hongyan Xia
2020-04-24 9:06 ` Julien Grall
2020-04-28 15:23 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 4/6] x86/smpboot: map and unmap page tables in cleanup_cpu_root_pgt Hongyan Xia
2020-04-24 9:13 ` Julien Grall
2020-04-28 15:26 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 5/6] x86/pv: map and unmap page tables in mark_pv_pt_pages_rdonly Hongyan Xia
2020-04-24 9:16 ` Julien Grall
2020-04-28 15:33 ` Jan Beulich [this message]
2020-04-28 15:49 ` Wei Liu
2020-04-28 15:55 ` Hongyan Xia
2020-04-28 15:59 ` Hongyan Xia
2020-04-29 9:26 ` Hongyan Xia
2020-04-29 11:04 ` Jan Beulich
2020-04-29 12:29 ` Hongyan Xia
2020-04-29 13:31 ` Jan Beulich
2020-04-17 9:52 ` [PATCH 6/6] x86/pv: map and unmap page table in dom0_construct_pv Hongyan Xia
2020-04-24 9:18 ` Julien Grall
2020-04-28 15:34 ` Jan Beulich
2020-04-24 8:07 ` [PATCH 0/6] convert more Xen page table code to the new API Hongyan Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbb4a755-c450-77dd-2aa5-44c01b42a5ff@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=hx242@xen.org \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).