From: Stefano Stabellini <sstabellini@kernel.org>
To: George Dunlap <george.dunlap@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH raisin 1/4] components/xen: Actually disable rombios
Date: Tue, 14 Jun 2016 10:32:31 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.10.1606141032230.2878@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <1465829063-22291-2-git-send-email-george.dunlap@citrix.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1872 bytes --]
On Mon, 13 Jun 2016, George Dunlap wrote:
> Commit 5fe3855 meant to disable rombios, but didn't. This causes the following
> build failure:
>
> gcc -O2 -fomit-frame-pointer -m32 -march=i686 -fno-strict-aliasing
> -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement
> -Wno-unused-but-set-variable -Wno-unused-local-typedefs
> -D__XEN_TOOLS__ -MMD -MF .rombios.o.d -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE -mno-tls-direct-seg-refs -DNDEBUG -Werror
> -fno-stack-protector -fno-exceptions -fno-builtin -msoft-float
> -I/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware/hvmloader/../../../tools/include
> -U__XEN_TOOLS__
> -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__
> -DENABLE_OVMF -DENABLE_ROMBIOS -DENABLE_SEABIOS -c -o rombios.o rombios.c
> rombios.c: In function ‘rombios_load_roms’:
> rombios.c:103:39: error: ‘etherboot’ undeclared (first use in this function)
> etherboot);
>
> Disable rombios instead.
>
> Reported-by: Holger Schramm <lists@schramm.by>
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> ---
> components/xen | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/components/xen b/components/xen
> index 894d119..ea290aa 100644
> --- a/components/xen
> +++ b/components/xen
> @@ -45,7 +45,7 @@ function xen_build() {
> export ETHERBOOT_NICS=""
> ./configure --prefix=$PREFIX --with-system-qemu=$PREFIX/lib/xen/bin/qemu-system-i386 \
> --disable-stubdom --disable-qemu-traditional \
> - --enable-rombios $seabios_opt $ovmf_opt
> + --disable-rombios $seabios_opt $ovmf_opt
> $RAISIN_MAKE
> $RAISIN_MAKE install DESTDIR="$INST_DIR"
> unset ETHERBOOT_NICS
> --
> 2.1.4
>
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-14 9:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 14:44 [PATCH raisin 0/4] Fixes for 4.6, update to 4.7 George Dunlap
2016-06-13 14:44 ` [PATCH raisin 1/4] components/xen: Actually disable rombios George Dunlap
2016-06-14 9:32 ` Stefano Stabellini [this message]
2016-06-13 14:44 ` [PATCH raisin 2/4] config: Separate config urls into a separate file George Dunlap
2016-06-14 9:34 ` Stefano Stabellini
2016-06-13 14:44 ` [PATCH raisin 3/4] Update config-4.6 and config-4.5 to point to stable branches George Dunlap
2016-06-14 9:40 ` Stefano Stabellini
2016-06-14 9:57 ` George Dunlap
2016-06-14 10:01 ` Stefano Stabellini
2016-06-14 10:10 ` George Dunlap
2016-06-15 10:24 ` Stefano Stabellini
2016-06-15 10:38 ` George Dunlap
2016-06-15 10:53 ` Stefano Stabellini
2016-06-15 11:13 ` George Dunlap
2016-06-15 14:02 ` Stefano Stabellini
2016-06-15 16:11 ` George Dunlap
2016-06-13 14:44 ` [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes George Dunlap
2016-06-14 9:46 ` Stefano Stabellini
2016-06-14 10:03 ` George Dunlap
2016-06-14 10:08 ` Stefano Stabellini
2016-06-14 10:17 ` George Dunlap
2016-06-14 10:31 ` Stefano Stabellini
2016-06-14 10:34 ` George Dunlap
2016-06-14 13:53 ` Anthony PERARD
2016-06-14 14:00 ` George Dunlap
2016-06-14 14:23 ` Anthony PERARD
2016-06-14 14:38 ` George Dunlap
2016-06-15 10:39 ` Stefano Stabellini
2016-06-15 10:42 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1606141032230.2878@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).