From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Paul Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
Cc: Paul Durrant <pdurrant@amazon.com>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 05/23] libxl: s/detatched/detached in libxl_pci.c
Date: Tue, 1 Dec 2020 15:15:22 +0200 [thread overview]
Message-ID: <f9f05409-a0aa-abfc-ef98-c1012d242b2a@gmail.com> (raw)
In-Reply-To: <20201124080159.11912-6-paul@xen.org>
Hi, Paul!
On 11/24/20 10:01 AM, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@amazon.com>
>
> Simply spelling correction. Purely cosmetic fix.
>
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Thank you,
Oleksandr
> ---
> Cc: Ian Jackson <iwj@xenproject.org>
> Cc: Wei Liu <wl@xen.org>
> ---
> tools/libs/light/libxl_pci.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
> index 50c96cbfa6..de617e95eb 100644
> --- a/tools/libs/light/libxl_pci.c
> +++ b/tools/libs/light/libxl_pci.c
> @@ -1864,7 +1864,7 @@ static void pci_remove_qmp_query_cb(libxl__egc *egc,
> libxl__ev_qmp *qmp, const libxl__json_object *response, int rc);
> static void pci_remove_timeout(libxl__egc *egc,
> libxl__ev_time *ev, const struct timeval *requested_abs, int rc);
> -static void pci_remove_detatched(libxl__egc *egc,
> +static void pci_remove_detached(libxl__egc *egc,
> pci_remove_state *prs, int rc);
> static void pci_remove_stubdom_done(libxl__egc *egc,
> libxl__ao_device *aodev);
> @@ -1978,7 +1978,7 @@ skip1:
> skip_irq:
> rc = 0;
> out_fail:
> - pci_remove_detatched(egc, prs, rc); /* must be last */
> + pci_remove_detached(egc, prs, rc); /* must be last */
> }
>
> static void pci_remove_qemu_trad_watch_state_cb(libxl__egc *egc,
> @@ -2002,7 +2002,7 @@ static void pci_remove_qemu_trad_watch_state_cb(libxl__egc *egc,
> rc = qemu_pci_remove_xenstore(gc, domid, pci, prs->force);
>
> out:
> - pci_remove_detatched(egc, prs, rc);
> + pci_remove_detached(egc, prs, rc);
> }
>
> static void pci_remove_qmp_device_del(libxl__egc *egc,
> @@ -2028,7 +2028,7 @@ static void pci_remove_qmp_device_del(libxl__egc *egc,
> return;
>
> out:
> - pci_remove_detatched(egc, prs, rc);
> + pci_remove_detached(egc, prs, rc);
> }
>
> static void pci_remove_qmp_device_del_cb(libxl__egc *egc,
> @@ -2051,7 +2051,7 @@ static void pci_remove_qmp_device_del_cb(libxl__egc *egc,
> return;
>
> out:
> - pci_remove_detatched(egc, prs, rc);
> + pci_remove_detached(egc, prs, rc);
> }
>
> static void pci_remove_qmp_retry_timer_cb(libxl__egc *egc, libxl__ev_time *ev,
> @@ -2067,7 +2067,7 @@ static void pci_remove_qmp_retry_timer_cb(libxl__egc *egc, libxl__ev_time *ev,
> return;
>
> out:
> - pci_remove_detatched(egc, prs, rc);
> + pci_remove_detached(egc, prs, rc);
> }
>
> static void pci_remove_qmp_query_cb(libxl__egc *egc,
> @@ -2127,7 +2127,7 @@ static void pci_remove_qmp_query_cb(libxl__egc *egc,
> }
>
> out:
> - pci_remove_detatched(egc, prs, rc); /* must be last */
> + pci_remove_detached(egc, prs, rc); /* must be last */
> }
>
> static void pci_remove_timeout(libxl__egc *egc, libxl__ev_time *ev,
> @@ -2146,12 +2146,12 @@ static void pci_remove_timeout(libxl__egc *egc, libxl__ev_time *ev,
> /* If we timed out, we might still want to keep destroying the device
> * (when force==true), so let the next function decide what to do on
> * error */
> - pci_remove_detatched(egc, prs, rc);
> + pci_remove_detached(egc, prs, rc);
> }
>
> -static void pci_remove_detatched(libxl__egc *egc,
> - pci_remove_state *prs,
> - int rc)
> +static void pci_remove_detached(libxl__egc *egc,
> + pci_remove_state *prs,
> + int rc)
> {
> STATE_AO_GC(prs->aodev->ao);
> int stubdomid = 0;
next prev parent reply other threads:[~2020-12-01 13:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 8:01 [PATCH v4 00/23] xl / libxl: named PCI pass-through devices Paul Durrant
2020-11-24 8:01 ` [PATCH v4 01/23] xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X Paul Durrant
2020-12-01 12:32 ` Oleksandr Andrushchenko
2020-12-03 13:00 ` Paul Durrant
2020-11-24 8:01 ` [PATCH v4 02/23] libxl: make libxl__device_list() work correctly for LIBXL__DEVICE_KIND_PCI Paul Durrant
2020-12-01 12:50 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 03/23] libxl: Make sure devices added by pci-attach are reflected in the config Paul Durrant
2020-12-01 13:12 ` Oleksandr Andrushchenko
2020-12-03 13:17 ` Paul Durrant
2020-12-03 13:20 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 04/23] libxl: add/recover 'rdm_policy' to/from PCI backend in xenstore Paul Durrant
2020-12-01 13:13 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 05/23] libxl: s/detatched/detached in libxl_pci.c Paul Durrant
2020-12-01 13:15 ` Oleksandr Andrushchenko [this message]
2020-11-24 8:01 ` [PATCH v4 06/23] libxl: remove extraneous arguments to do_pci_remove() " Paul Durrant
2020-12-01 13:41 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 07/23] libxl: stop using aodev->device_config in libxl__device_pci_add() Paul Durrant
2020-12-01 13:42 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 08/23] libxl: generalise 'driver_path' xenstore access functions in libxl_pci.c Paul Durrant
2020-12-01 13:48 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 09/23] libxl: remove unnecessary check from libxl__device_pci_add() Paul Durrant
2020-12-01 13:51 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 10/23] libxl: remove get_all_assigned_devices() from libxl_pci.c Paul Durrant
2020-12-01 14:18 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 11/23] libxl: make sure callers of libxl_device_pci_list() free the list after use Paul Durrant
2020-12-01 15:10 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 12/23] libxl: add libxl_device_pci_assignable_list_free() Paul Durrant
2020-12-01 15:17 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 13/23] libxl: use COMPARE_PCI() macro is_pci_in_array() Paul Durrant
2020-12-01 15:20 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 14/23] docs/man: extract documentation of PCI_SPEC_STRING from the xl.cfg manpage Paul Durrant
2020-12-01 15:25 ` Oleksandr Andrushchenko
2020-11-24 8:01 ` [PATCH v4 15/23] docs/man: improve documentation of PCI_SPEC_STRING Paul Durrant
2020-11-24 8:01 ` [PATCH v4 16/23] docs/man: fix xl(1) documentation for 'pci' operations Paul Durrant
2020-11-24 8:01 ` [PATCH v4 17/23] libxl: introduce 'libxl_pci_bdf' in the idl Paul Durrant
2020-11-24 8:01 ` [PATCH v4 18/23] libxlu: introduce xlu_pci_parse_spec_string() Paul Durrant
2020-11-24 8:01 ` [PATCH v4 19/23] libxl: modify libxl_device_pci_assignable_add/remove/list/list_free() Paul Durrant
2020-11-24 8:01 ` [PATCH v4 20/23] docs/man: modify xl(1) in preparation for naming of assignable devices Paul Durrant
2020-11-24 8:01 ` [PATCH v4 21/23] xl / libxl: support " Paul Durrant
2020-11-24 8:01 ` [PATCH v4 22/23] docs/man: modify xl-pci-configuration(5) to add 'name' field to PCI_SPEC_STRING Paul Durrant
2020-11-24 8:01 ` [PATCH v4 23/23] xl / libxl: support 'xl pci-attach/detach' by name Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9f05409-a0aa-abfc-ef98-c1012d242b2a@gmail.com \
--to=andr2000@gmail.com \
--cc=iwj@xenproject.org \
--cc=paul@xen.org \
--cc=pdurrant@amazon.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).