From: kgene@kernel.org
To: 'Naveen Krishna Chatradhi' <ch.naveen@samsung.com>,
linux-arm-kernel@lists.infradead.org
Cc: naveenkrishna.ch@gmail.com, linux-samsung-soc@vger.kernel.org,
catalin.marinas@arm.com, robh@kernel.org,
devicetree@vger.kernel.org, t.figa@samsung.com
Subject: RE: [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7
Date: Tue, 09 Sep 2014 12:28:37 +0900 [thread overview]
Message-ID: <02f801cfcbde$24a40160$6dec0420$@kernel.org> (raw)
In-Reply-To: <1409672143-8574-6-git-send-email-ch.naveen@samsung.com>
Naveen Krishna Chatradhi wrote:
>
> Add initial device tree nodes for EXYNOS7 SoC and board dts file
> to support Espresso board based on Exynos7 SoC.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> ---
> arch/arm64/boot/dts/Makefile | 1 +
> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 31 +++++
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 168 +++++++++++++++++++++++
> 3 files changed, 200 insertions(+)
> create mode 100644 arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> create mode 100644 arch/arm64/boot/dts/exynos/exynos7.dtsi
[...]
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> new file mode 100644
> index 0000000..e593af55
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -0,0 +1,168 @@
> +/*
> + * SAMSUNG EXYNOS7 SoC device tree source
> + *
> + * Copyright (c) 2014 Samsung Electronics Co., Ltd.
> + * http://www.samsung.com
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#include <dt-bindings/clock/exynos7-clk.h>
> +
> +/ {
> + compatible = "samsung,exynos7";
> + interrupt-parent = <&gic>;
> + #address-cells = <2>;
+ #address-cells = <1>; ?
Hmm...I can't see any 64-bit address here.
> + #size-cells = <2>;
> +
[...]
> +
> + soc: soc {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0 0 0x18000000>;
> +
> + chipid@10000000 {
> + compatible = "samsung,exynos4210-chipid";
> + reg = <0x10000000 0x100>;
> + };
Maybe this is not required? There is no check chipid in arm/arm64.
[...]
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <1 13 0xff01>,
> + <1 14 0xff01>,
> + <1 11 0xff01>,
> + <1 10 0xff01>;
clock-frequency ?
[...]
- Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (kgene at kernel.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7
Date: Tue, 09 Sep 2014 12:28:37 +0900 [thread overview]
Message-ID: <02f801cfcbde$24a40160$6dec0420$@kernel.org> (raw)
In-Reply-To: <1409672143-8574-6-git-send-email-ch.naveen@samsung.com>
Naveen Krishna Chatradhi wrote:
>
> Add initial device tree nodes for EXYNOS7 SoC and board dts file
> to support Espresso board based on Exynos7 SoC.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> ---
> arch/arm64/boot/dts/Makefile | 1 +
> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 31 +++++
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 168 +++++++++++++++++++++++
> 3 files changed, 200 insertions(+)
> create mode 100644 arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> create mode 100644 arch/arm64/boot/dts/exynos/exynos7.dtsi
[...]
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> new file mode 100644
> index 0000000..e593af55
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -0,0 +1,168 @@
> +/*
> + * SAMSUNG EXYNOS7 SoC device tree source
> + *
> + * Copyright (c) 2014 Samsung Electronics Co., Ltd.
> + * http://www.samsung.com
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#include <dt-bindings/clock/exynos7-clk.h>
> +
> +/ {
> + compatible = "samsung,exynos7";
> + interrupt-parent = <&gic>;
> + #address-cells = <2>;
+ #address-cells = <1>; ?
Hmm...I can't see any 64-bit address here.
> + #size-cells = <2>;
> +
[...]
> +
> + soc: soc {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0 0 0x18000000>;
> +
> + chipid at 10000000 {
> + compatible = "samsung,exynos4210-chipid";
> + reg = <0x10000000 0x100>;
> + };
Maybe this is not required? There is no check chipid in arm/arm64.
[...]
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <1 13 0xff01>,
> + <1 14 0xff01>,
> + <1 11 0xff01>,
> + <1 10 0xff01>;
clock-frequency ?
[...]
- Kukjin
next prev parent reply other threads:[~2014-09-09 3:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 15:35 [PATCH v2 0/7] arch: arm64: enable support for Samsung Exynos7 SoC Naveen Krishna Chatradhi
2014-09-02 15:35 ` Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 1/7] clk: samsung: add support for 145xx and 1460x PLLs Naveen Krishna Chatradhi
2014-09-02 15:35 ` Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 2/7] clk: samsung: Factor out the common code to clk.c Naveen Krishna Chatradhi
2014-09-02 15:35 ` Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 3/7] clk: samsung: Add fixed_factor_clocks field to struct exynos_cmu_info Naveen Krishna Chatradhi
2014-09-02 15:35 ` Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 4/7] clk: samsung: add initial clock support for Exynos7 SoC Naveen Krishna Chatradhi
2014-09-02 15:35 ` Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7 Naveen Krishna Chatradhi
2014-09-02 15:35 ` Naveen Krishna Chatradhi
2014-09-03 16:15 ` Kukjin Kim
2014-09-03 16:15 ` Kukjin Kim
2014-09-03 16:22 ` Arnd Bergmann
2014-09-03 16:22 ` Arnd Bergmann
2014-09-03 16:31 ` Kukjin Kim
2014-09-03 16:31 ` Kukjin Kim
2014-09-03 18:28 ` Arnd Bergmann
2014-09-03 18:28 ` Arnd Bergmann
2014-09-09 3:06 ` kgene
2014-09-09 3:06 ` kgene at kernel.org
2014-09-09 3:28 ` kgene [this message]
2014-09-09 3:28 ` kgene at kernel.org
2014-09-11 8:42 ` Naveen Krishna Ch
2014-09-11 8:42 ` Naveen Krishna Ch
2014-09-02 15:35 ` [PATCH v2 6/7] tty/serial: samsung: enable usage for 64-bit Exynos platforms Naveen Krishna Chatradhi
2014-09-02 15:35 ` Naveen Krishna Chatradhi
2014-09-02 15:35 ` [PATCH v2 7/7] arm64: exynos7: Enable ARMv8 based Exynos7 (SoC) support Naveen Krishna Chatradhi
2014-09-02 15:35 ` Naveen Krishna Chatradhi
2014-09-02 16:37 ` [PATCH v2 0/7] arch: arm64: enable support for Samsung Exynos7 SoC Tomasz Figa
2014-09-02 16:37 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02f801cfcbde$24a40160$6dec0420$@kernel.org' \
--to=kgene@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=ch.naveen@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=robh@kernel.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.