From: Kukjin Kim <kgene.kim@samsung.com> To: 'Naveen Krishna Chatradhi' <ch.naveen@samsung.com>, linux-arm-kernel@lists.infradead.org Cc: naveenkrishna.ch@gmail.com, linux-samsung-soc@vger.kernel.org, catalin.marinas@arm.com, robh@kernel.org, devicetree@vger.kernel.org, t.figa@samsung.com Subject: RE: [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7 Date: Thu, 04 Sep 2014 01:15:20 +0900 [thread overview] Message-ID: <036a01cfc792$422271e0$c66755a0$@samsung.com> (raw) In-Reply-To: <1409672143-8574-6-git-send-email-ch.naveen@samsung.com> Naveen Krishna Chatradhi wrote: > > Add initial device tree nodes for EXYNOS7 SoC and board dts file > to support Espresso board based on Exynos7 SoC. > > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Catalin Marinas <catalin.marinas@arm.com> NAK. There are several exynos7 SoCs which cannot be supported with one dt file. I mean just one exynos7 cannot represent all of exynos7 SoCs... > --- > arch/arm64/boot/dts/Makefile | 1 + > arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 31 +++++ > arch/arm64/boot/dts/exynos/exynos7.dtsi | 168 +++++++++++++++++++++++ > 3 files changed, 200 insertions(+) > create mode 100644 arch/arm64/boot/dts/exynos/exynos7-espresso.dts > create mode 100644 arch/arm64/boot/dts/exynos/exynos7.dtsi > > diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile > index c52bdb0..a3bc18a 100644 > --- a/arch/arm64/boot/dts/Makefile > +++ b/arch/arm64/boot/dts/Makefile > @@ -1,3 +1,4 @@ > +dtb-$(CONFIG_ARCH_EXYNOS7) += exynos/exynos7-espresso.dtb > dtb-$(CONFIG_ARCH_VEXPRESS) += rtsm_ve-aemv8a.dtb foundation-v8.dtb > dtb-$(CONFIG_ARCH_XGENE) += apm-mustang.dtb > > diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7- > espresso.dts > new file mode 100644 > index 0000000..f6a8879 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > @@ -0,0 +1,31 @@ > +/* > + * SAMSUNG Exynos7 Espresso board device tree source > + * > + * Copyright (c) 2014 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > +*/ > + > +/dts-v1/; > +#include "exynos7.dtsi" > + > +/ { > + model = "Samsung Exynos7 Espresso board based on EXYNOS7"; > + compatible = "samsung,exynos7-espresso", "samsung,exynos7"; > + > + chosen { > + linux,stdout-path = &serial_2; Well... > + }; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0x0 0x40000000 0x0 0xC0000000>; The base address of system memory is depending on each board, actually some of them are 0x20000000. > + }; > +}; > + > +&serial_2 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi > new file mode 100644 > index 0000000..e593af55 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi > @@ -0,0 +1,168 @@ > +/* > + * SAMSUNG EXYNOS7 SoC device tree source > + * > + * Copyright (c) 2014 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include <dt-bindings/clock/exynos7-clk.h> > + > +/ { > + compatible = "samsung,exynos7"; > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + aliases { > + serial0 = &serial_0; > + serial1 = &serial_1; > + serial2 = &serial_2; > + serial3 = &serial_3; There are exynos7 SoC is having 3 serial IPs... > + }; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a57", "arm,armv8"; > + enable-method = "psci"; > + reg = <0x0>; > + }; > + > + cpu@1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a57", "arm,armv8"; > + enable-method = "psci"; > + reg = <0x1>; > + }; > + > + cpu@2 { > + device_type = "cpu"; > + compatible = "arm,cortex-a57", "arm,armv8"; > + enable-method = "psci"; > + reg = <0x2>; > + }; > + > + cpu@3 { > + device_type = "cpu"; > + compatible = "arm,cortex-a57", "arm,armv8"; > + enable-method = "psci"; > + reg = <0x3>; > + }; > + }; Naveen, please don't assume all of exynos7 SoCs are having quad a57s... > + > + psci { > + compatible = "arm,psci-0.2"; > + method = "smc"; > + }; > + > + soc: soc { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0 0 0x18000000>; > + > + chipid@10000000 { > + compatible = "samsung,exynos4210-chipid"; > + reg = <0x10000000 0x100>; > + }; > + > + fin_pll: xxti { > + compatible = "fixed-clock"; > + clock-frequency = <24000000>; It's wrong on some exynos7 SoCs... > + clock-output-names = "fin_pll"; > + #clock-cells = <0>; > + }; > + Unfortunately the addresses are different on each exynos7 SoCs... > + gic: interrupt-controller@11001000 { > + compatible = "arm,gic-400"; > + #interrupt-cells = <3>; > + #address-cells = <0>; > + interrupt-controller; > + reg = <0x11001000 0x1000>, > + <0x11002000 0x1000>, > + <0x11004000 0x2000>, > + <0x11006000 0x2000>; > + }; > + > + clock_topc: clock-controller@10570000 { > + compatible = "samsung,exynos7-clock-topc"; > + reg = <0x10570000 0x10000>; > + #clock-cells = <1>; > + }; > + > + clock_top0: clock-controller@105d0000 { > + compatible = "samsung,exynos7-clock-top0"; > + reg = <0x105d0000 0xb000>; > + #clock-cells = <1>; > + }; > + > + clock_peric0: clock-controller@13610000 { > + compatible = "samsung,exynos7-clock-peric0"; > + reg = <0x13610000 0xd00>; > + #clock-cells = <1>; > + }; > + > + clock_peric1: clock-controller@14C80000 { > + compatible = "samsung,exynos7-clock-peric1"; > + reg = <0x14c80000 0xd00>; > + #clock-cells = <1>; > + }; > + > + clock_peris: clock-controller@10040000 { > + compatible = "samsung,exynos7-clock-peris"; > + reg = <0x10040000 0xd00>; > + #clock-cells = <1>; > + }; > + > + serial_0: serial@13630000 { > + compatible = "samsung,exynos4210-uart"; > + reg = <0x13630000 0x100>; > + interrupts = <0 440 0>; > + clocks = <&clock_peric0 PCLK_UART0>, <&clock_peric0 SCLK_UART0>; > + clock-names = "uart", "clk_uart_baud0"; > + status = "disabled"; > + }; > + > + serial_1: serial@14c20000 { > + compatible = "samsung,exynos4210-uart"; > + reg = <0x14c20000 0x100>; > + interrupts = <0 456 0>; > + clocks = <&clock_peric1 PCLK_UART1>, <&clock_peric1 SCLK_UART1>; > + clock-names = "uart", "clk_uart_baud0"; > + status = "disabled"; > + }; > + > + serial_2: serial@14c30000 { > + compatible = "samsung,exynos4210-uart"; > + reg = <0x14c30000 0x100>; > + interrupts = <0 457 0>; > + clocks = <&clock_peric1 PCLK_UART2>, <&clock_peric1 SCLK_UART2>; > + clock-names = "uart", "clk_uart_baud0"; > + status = "disabled"; > + }; > + > + serial_3: serial@14c40000 { > + compatible = "samsung,exynos4210-uart"; > + reg = <0x14c40000 0x100>; > + interrupts = <0 458 0>; > + clocks = <&clock_peric1 PCLK_UART3>, <&clock_peric1 SCLK_UART3>; > + clock-names = "uart", "clk_uart_baud0"; > + status = "disabled"; > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = <1 13 0xff01>, > + <1 14 0xff01>, > + <1 11 0xff01>, > + <1 10 0xff01>; > + }; > + }; > +}; > -- > 1.7.9.5 So this is not acceptable... - Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7 Date: Thu, 04 Sep 2014 01:15:20 +0900 [thread overview] Message-ID: <036a01cfc792$422271e0$c66755a0$@samsung.com> (raw) In-Reply-To: <1409672143-8574-6-git-send-email-ch.naveen@samsung.com> Naveen Krishna Chatradhi wrote: > > Add initial device tree nodes for EXYNOS7 SoC and board dts file > to support Espresso board based on Exynos7 SoC. > > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Catalin Marinas <catalin.marinas@arm.com> NAK. There are several exynos7 SoCs which cannot be supported with one dt file. I mean just one exynos7 cannot represent all of exynos7 SoCs... > --- > arch/arm64/boot/dts/Makefile | 1 + > arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 31 +++++ > arch/arm64/boot/dts/exynos/exynos7.dtsi | 168 +++++++++++++++++++++++ > 3 files changed, 200 insertions(+) > create mode 100644 arch/arm64/boot/dts/exynos/exynos7-espresso.dts > create mode 100644 arch/arm64/boot/dts/exynos/exynos7.dtsi > > diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile > index c52bdb0..a3bc18a 100644 > --- a/arch/arm64/boot/dts/Makefile > +++ b/arch/arm64/boot/dts/Makefile > @@ -1,3 +1,4 @@ > +dtb-$(CONFIG_ARCH_EXYNOS7) += exynos/exynos7-espresso.dtb > dtb-$(CONFIG_ARCH_VEXPRESS) += rtsm_ve-aemv8a.dtb foundation-v8.dtb > dtb-$(CONFIG_ARCH_XGENE) += apm-mustang.dtb > > diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7- > espresso.dts > new file mode 100644 > index 0000000..f6a8879 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > @@ -0,0 +1,31 @@ > +/* > + * SAMSUNG Exynos7 Espresso board device tree source > + * > + * Copyright (c) 2014 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > +*/ > + > +/dts-v1/; > +#include "exynos7.dtsi" > + > +/ { > + model = "Samsung Exynos7 Espresso board based on EXYNOS7"; > + compatible = "samsung,exynos7-espresso", "samsung,exynos7"; > + > + chosen { > + linux,stdout-path = &serial_2; Well... > + }; > + > + memory at 40000000 { > + device_type = "memory"; > + reg = <0x0 0x40000000 0x0 0xC0000000>; The base address of system memory is depending on each board, actually some of them are 0x20000000. > + }; > +}; > + > +&serial_2 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi > new file mode 100644 > index 0000000..e593af55 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi > @@ -0,0 +1,168 @@ > +/* > + * SAMSUNG EXYNOS7 SoC device tree source > + * > + * Copyright (c) 2014 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include <dt-bindings/clock/exynos7-clk.h> > + > +/ { > + compatible = "samsung,exynos7"; > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + aliases { > + serial0 = &serial_0; > + serial1 = &serial_1; > + serial2 = &serial_2; > + serial3 = &serial_3; There are exynos7 SoC is having 3 serial IPs... > + }; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu at 0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a57", "arm,armv8"; > + enable-method = "psci"; > + reg = <0x0>; > + }; > + > + cpu at 1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a57", "arm,armv8"; > + enable-method = "psci"; > + reg = <0x1>; > + }; > + > + cpu at 2 { > + device_type = "cpu"; > + compatible = "arm,cortex-a57", "arm,armv8"; > + enable-method = "psci"; > + reg = <0x2>; > + }; > + > + cpu at 3 { > + device_type = "cpu"; > + compatible = "arm,cortex-a57", "arm,armv8"; > + enable-method = "psci"; > + reg = <0x3>; > + }; > + }; Naveen, please don't assume all of exynos7 SoCs are having quad a57s... > + > + psci { > + compatible = "arm,psci-0.2"; > + method = "smc"; > + }; > + > + soc: soc { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0 0 0x18000000>; > + > + chipid at 10000000 { > + compatible = "samsung,exynos4210-chipid"; > + reg = <0x10000000 0x100>; > + }; > + > + fin_pll: xxti { > + compatible = "fixed-clock"; > + clock-frequency = <24000000>; It's wrong on some exynos7 SoCs... > + clock-output-names = "fin_pll"; > + #clock-cells = <0>; > + }; > + Unfortunately the addresses are different on each exynos7 SoCs... > + gic: interrupt-controller at 11001000 { > + compatible = "arm,gic-400"; > + #interrupt-cells = <3>; > + #address-cells = <0>; > + interrupt-controller; > + reg = <0x11001000 0x1000>, > + <0x11002000 0x1000>, > + <0x11004000 0x2000>, > + <0x11006000 0x2000>; > + }; > + > + clock_topc: clock-controller at 10570000 { > + compatible = "samsung,exynos7-clock-topc"; > + reg = <0x10570000 0x10000>; > + #clock-cells = <1>; > + }; > + > + clock_top0: clock-controller at 105d0000 { > + compatible = "samsung,exynos7-clock-top0"; > + reg = <0x105d0000 0xb000>; > + #clock-cells = <1>; > + }; > + > + clock_peric0: clock-controller at 13610000 { > + compatible = "samsung,exynos7-clock-peric0"; > + reg = <0x13610000 0xd00>; > + #clock-cells = <1>; > + }; > + > + clock_peric1: clock-controller at 14C80000 { > + compatible = "samsung,exynos7-clock-peric1"; > + reg = <0x14c80000 0xd00>; > + #clock-cells = <1>; > + }; > + > + clock_peris: clock-controller at 10040000 { > + compatible = "samsung,exynos7-clock-peris"; > + reg = <0x10040000 0xd00>; > + #clock-cells = <1>; > + }; > + > + serial_0: serial at 13630000 { > + compatible = "samsung,exynos4210-uart"; > + reg = <0x13630000 0x100>; > + interrupts = <0 440 0>; > + clocks = <&clock_peric0 PCLK_UART0>, <&clock_peric0 SCLK_UART0>; > + clock-names = "uart", "clk_uart_baud0"; > + status = "disabled"; > + }; > + > + serial_1: serial at 14c20000 { > + compatible = "samsung,exynos4210-uart"; > + reg = <0x14c20000 0x100>; > + interrupts = <0 456 0>; > + clocks = <&clock_peric1 PCLK_UART1>, <&clock_peric1 SCLK_UART1>; > + clock-names = "uart", "clk_uart_baud0"; > + status = "disabled"; > + }; > + > + serial_2: serial at 14c30000 { > + compatible = "samsung,exynos4210-uart"; > + reg = <0x14c30000 0x100>; > + interrupts = <0 457 0>; > + clocks = <&clock_peric1 PCLK_UART2>, <&clock_peric1 SCLK_UART2>; > + clock-names = "uart", "clk_uart_baud0"; > + status = "disabled"; > + }; > + > + serial_3: serial at 14c40000 { > + compatible = "samsung,exynos4210-uart"; > + reg = <0x14c40000 0x100>; > + interrupts = <0 458 0>; > + clocks = <&clock_peric1 PCLK_UART3>, <&clock_peric1 SCLK_UART3>; > + clock-names = "uart", "clk_uart_baud0"; > + status = "disabled"; > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = <1 13 0xff01>, > + <1 14 0xff01>, > + <1 11 0xff01>, > + <1 10 0xff01>; > + }; > + }; > +}; > -- > 1.7.9.5 So this is not acceptable... - Kukjin
next prev parent reply other threads:[~2014-09-03 16:15 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-02 15:35 [PATCH v2 0/7] arch: arm64: enable support for Samsung Exynos7 SoC Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 1/7] clk: samsung: add support for 145xx and 1460x PLLs Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 2/7] clk: samsung: Factor out the common code to clk.c Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 3/7] clk: samsung: Add fixed_factor_clocks field to struct exynos_cmu_info Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 4/7] clk: samsung: add initial clock support for Exynos7 SoC Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7 Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-03 16:15 ` Kukjin Kim [this message] 2014-09-03 16:15 ` Kukjin Kim 2014-09-03 16:22 ` Arnd Bergmann 2014-09-03 16:22 ` Arnd Bergmann 2014-09-03 16:31 ` Kukjin Kim 2014-09-03 16:31 ` Kukjin Kim 2014-09-03 18:28 ` Arnd Bergmann 2014-09-03 18:28 ` Arnd Bergmann 2014-09-09 3:06 ` kgene 2014-09-09 3:06 ` kgene at kernel.org 2014-09-09 3:28 ` kgene 2014-09-09 3:28 ` kgene at kernel.org 2014-09-11 8:42 ` Naveen Krishna Ch 2014-09-11 8:42 ` Naveen Krishna Ch 2014-09-02 15:35 ` [PATCH v2 6/7] tty/serial: samsung: enable usage for 64-bit Exynos platforms Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 7/7] arm64: exynos7: Enable ARMv8 based Exynos7 (SoC) support Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 16:37 ` [PATCH v2 0/7] arch: arm64: enable support for Samsung Exynos7 SoC Tomasz Figa 2014-09-02 16:37 ` Tomasz Figa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='036a01cfc792$422271e0$c66755a0$@samsung.com' \ --to=kgene.kim@samsung.com \ --cc=catalin.marinas@arm.com \ --cc=ch.naveen@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=naveenkrishna.ch@gmail.com \ --cc=robh@kernel.org \ --cc=t.figa@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.