From: Naveen Krishna Ch <naveenkrishna.ch@gmail.com> To: kgene@kernel.org Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, catalin.marinas@arm.com, robh@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7 Date: Thu, 11 Sep 2014 14:12:34 +0530 [thread overview] Message-ID: <CAHfPSqAJF4PNr8BAzY=pFNTKjivrkWUz2Ceg8a0z0w1ad-O14w@mail.gmail.com> (raw) In-Reply-To: <02f801cfcbde$24a40160$6dec0420$@kernel.org> On 9 September 2014 08:58, <kgene@kernel.org> wrote: > Naveen Krishna Chatradhi wrote: >> >> Add initial device tree nodes for EXYNOS7 SoC and board dts file >> to support Espresso board based on Exynos7 SoC. >> >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> --- >> arch/arm64/boot/dts/Makefile | 1 + >> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 31 +++++ >> arch/arm64/boot/dts/exynos/exynos7.dtsi | 168 +++++++++++++++++++++++ >> 3 files changed, 200 insertions(+) >> create mode 100644 arch/arm64/boot/dts/exynos/exynos7-espresso.dts >> create mode 100644 arch/arm64/boot/dts/exynos/exynos7.dtsi > > [...] > >> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi >> new file mode 100644 >> index 0000000..e593af55 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi >> @@ -0,0 +1,168 @@ >> +/* >> + * SAMSUNG EXYNOS7 SoC device tree source >> + * >> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +#include <dt-bindings/clock/exynos7-clk.h> >> + >> +/ { >> + compatible = "samsung,exynos7"; >> + interrupt-parent = <&gic>; >> + #address-cells = <2>; > > + #address-cells = <1>; ? > > Hmm...I can't see any 64-bit address here. All the SoC peripherals have been put into the soc node and ranges property in that node is used to convert 64-bit to 32-bit addresses. But since this is a 64-bit SoC, we use #address-cells as 2. > >> + #size-cells = <2>; >> + > > [...] > >> + >> + soc: soc { >> + compatible = "simple-bus"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0 0 0 0x18000000>; >> + >> + chipid@10000000 { >> + compatible = "samsung,exynos4210-chipid"; >> + reg = <0x10000000 0x100>; >> + }; > > Maybe this is not required? There is no check chipid in arm/arm64. This is only describing the hardware and it does not depend on linux using this information. And support for chip id can be used later for 64-bit Exynos platforms as well. > > [...] > >> + timer { >> + compatible = "arm,armv8-timer"; >> + interrupts = <1 13 0xff01>, >> + <1 14 0xff01>, >> + <1 11 0xff01>, >> + <1 10 0xff01>; > > clock-frequency ? That is programmed by the bootloader / firmware. > > [...] > > - Kukjin > Thanks, -- Shine bright, (: Nav :)
WARNING: multiple messages have this Message-ID (diff)
From: naveenkrishna.ch@gmail.com (Naveen Krishna Ch) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7 Date: Thu, 11 Sep 2014 14:12:34 +0530 [thread overview] Message-ID: <CAHfPSqAJF4PNr8BAzY=pFNTKjivrkWUz2Ceg8a0z0w1ad-O14w@mail.gmail.com> (raw) In-Reply-To: <02f801cfcbde$24a40160$6dec0420$@kernel.org> On 9 September 2014 08:58, <kgene@kernel.org> wrote: > Naveen Krishna Chatradhi wrote: >> >> Add initial device tree nodes for EXYNOS7 SoC and board dts file >> to support Espresso board based on Exynos7 SoC. >> >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> --- >> arch/arm64/boot/dts/Makefile | 1 + >> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 31 +++++ >> arch/arm64/boot/dts/exynos/exynos7.dtsi | 168 +++++++++++++++++++++++ >> 3 files changed, 200 insertions(+) >> create mode 100644 arch/arm64/boot/dts/exynos/exynos7-espresso.dts >> create mode 100644 arch/arm64/boot/dts/exynos/exynos7.dtsi > > [...] > >> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi >> new file mode 100644 >> index 0000000..e593af55 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi >> @@ -0,0 +1,168 @@ >> +/* >> + * SAMSUNG EXYNOS7 SoC device tree source >> + * >> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +#include <dt-bindings/clock/exynos7-clk.h> >> + >> +/ { >> + compatible = "samsung,exynos7"; >> + interrupt-parent = <&gic>; >> + #address-cells = <2>; > > + #address-cells = <1>; ? > > Hmm...I can't see any 64-bit address here. All the SoC peripherals have been put into the soc node and ranges property in that node is used to convert 64-bit to 32-bit addresses. But since this is a 64-bit SoC, we use #address-cells as 2. > >> + #size-cells = <2>; >> + > > [...] > >> + >> + soc: soc { >> + compatible = "simple-bus"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0 0 0 0x18000000>; >> + >> + chipid at 10000000 { >> + compatible = "samsung,exynos4210-chipid"; >> + reg = <0x10000000 0x100>; >> + }; > > Maybe this is not required? There is no check chipid in arm/arm64. This is only describing the hardware and it does not depend on linux using this information. And support for chip id can be used later for 64-bit Exynos platforms as well. > > [...] > >> + timer { >> + compatible = "arm,armv8-timer"; >> + interrupts = <1 13 0xff01>, >> + <1 14 0xff01>, >> + <1 11 0xff01>, >> + <1 10 0xff01>; > > clock-frequency ? That is programmed by the bootloader / firmware. > > [...] > > - Kukjin > Thanks, -- Shine bright, (: Nav :)
next prev parent reply other threads:[~2014-09-11 8:42 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-02 15:35 [PATCH v2 0/7] arch: arm64: enable support for Samsung Exynos7 SoC Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 1/7] clk: samsung: add support for 145xx and 1460x PLLs Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 2/7] clk: samsung: Factor out the common code to clk.c Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 3/7] clk: samsung: Add fixed_factor_clocks field to struct exynos_cmu_info Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 4/7] clk: samsung: add initial clock support for Exynos7 SoC Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 5/7] arm64: dts: Add initial device tree support for EXYNOS7 Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-03 16:15 ` Kukjin Kim 2014-09-03 16:15 ` Kukjin Kim 2014-09-03 16:22 ` Arnd Bergmann 2014-09-03 16:22 ` Arnd Bergmann 2014-09-03 16:31 ` Kukjin Kim 2014-09-03 16:31 ` Kukjin Kim 2014-09-03 18:28 ` Arnd Bergmann 2014-09-03 18:28 ` Arnd Bergmann 2014-09-09 3:06 ` kgene 2014-09-09 3:06 ` kgene at kernel.org 2014-09-09 3:28 ` kgene 2014-09-09 3:28 ` kgene at kernel.org 2014-09-11 8:42 ` Naveen Krishna Ch [this message] 2014-09-11 8:42 ` Naveen Krishna Ch 2014-09-02 15:35 ` [PATCH v2 6/7] tty/serial: samsung: enable usage for 64-bit Exynos platforms Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 15:35 ` [PATCH v2 7/7] arm64: exynos7: Enable ARMv8 based Exynos7 (SoC) support Naveen Krishna Chatradhi 2014-09-02 15:35 ` Naveen Krishna Chatradhi 2014-09-02 16:37 ` [PATCH v2 0/7] arch: arm64: enable support for Samsung Exynos7 SoC Tomasz Figa 2014-09-02 16:37 ` Tomasz Figa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHfPSqAJF4PNr8BAzY=pFNTKjivrkWUz2Ceg8a0z0w1ad-O14w@mail.gmail.com' \ --to=naveenkrishna.ch@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=ch.naveen@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=kgene@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.