From: Stephen Boyd <sboyd@kernel.org> To: "A.s. Dong" <aisheng.dong@nxp.com>, "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "mturquette@baylibre.com" <mturquette@baylibre.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, Fabio Estevam <fabio.estevam@nxp.com>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "A.s. Dong" <aisheng.dong@nxp.com> Subject: Re: [PATCH V4 08/11] clk: imx: scu: add scu clock gpr mux Date: Tue, 16 Oct 2018 14:30:40 -0700 [thread overview] Message-ID: <153972544065.5275.2030080128764662219@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <1539504194-28289-9-git-send-email-aisheng.dong@nxp.com> Quoting A.s. Dong (2018-10-14 01:08:06) > diff --git a/drivers/clk/imx/scu/clk-mux-gpr-scu.c b/drivers/clk/imx/scu/clk-mux-gpr-scu.c > new file mode 100644 > index 0000000..2ad7a80 > --- /dev/null > +++ b/drivers/clk/imx/scu/clk-mux-gpr-scu.c > @@ -0,0 +1,90 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2016 Freescale Semiconductor, Inc. > + * Copyright 2017~2018 NXP > + * Dong Aisheng <aisheng.dong@nxp.com> > + */ > + > +#include <linux/clk-provider.h> > +#include <linux/err.h> > +#include <linux/io.h> > +#include <linux/slab.h> > + > +#include "clk-scu.h" > + > +struct clk_mux_gpr_scu { > + struct clk_hw hw; > + u32 rsrc_id; > + u8 gpr_id; > +}; > + > +#define to_clk_mux_gpr_scu(_hw) container_of(_hw, struct clk_mux_gpr_scu, hw) > + > +static u8 clk_mux_gpr_scu_get_parent(struct clk_hw *hw) > +{ > + struct clk_mux_gpr_scu *gpr_mux = to_clk_mux_gpr_scu(hw); > + u32 val = 0; > + int ret; > + > + ret = imx_sc_misc_get_control(ccm_ipc_handle, gpr_mux->rsrc_id, > + gpr_mux->gpr_id, &val); > + if (ret) { > + pr_err("%s: failed to get clock parent %d\n", > + clk_hw_get_name(hw), ret); > + return 0; > + } > + > + return (u8)val; Nitpick: Please drop explicit casts. > +} > + > +static int clk_mux_gpr_scu_set_parent(struct clk_hw *hw, u8 index) > +{ > + struct clk_mux_gpr_scu *gpr_mux = to_clk_mux_gpr_scu(hw); > + int ret; > + > + ret = imx_sc_misc_set_control(ccm_ipc_handle, gpr_mux->rsrc_id, > + gpr_mux->gpr_id, index); > + if (ret) > + pr_err("%s: failed to set clock parent %d\n", > + clk_hw_get_name(hw), ret); Nitpick: These printks are cluttering the code, any chance they can be removed and you can rely on callers to care if something failed? > + > + return ret; > +} > + > +static const struct clk_ops clk_mux_gpr_scu_ops = { > + .get_parent = clk_mux_gpr_scu_get_parent, > + .set_parent = clk_mux_gpr_scu_set_parent, > +}; > + > +struct clk_hw *clk_register_mux_gpr_scu(const char *name, const char * const *parents,
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@kernel.org (Stephen Boyd) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V4 08/11] clk: imx: scu: add scu clock gpr mux Date: Tue, 16 Oct 2018 14:30:40 -0700 [thread overview] Message-ID: <153972544065.5275.2030080128764662219@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <1539504194-28289-9-git-send-email-aisheng.dong@nxp.com> Quoting A.s. Dong (2018-10-14 01:08:06) > diff --git a/drivers/clk/imx/scu/clk-mux-gpr-scu.c b/drivers/clk/imx/scu/clk-mux-gpr-scu.c > new file mode 100644 > index 0000000..2ad7a80 > --- /dev/null > +++ b/drivers/clk/imx/scu/clk-mux-gpr-scu.c > @@ -0,0 +1,90 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2016 Freescale Semiconductor, Inc. > + * Copyright 2017~2018 NXP > + * Dong Aisheng <aisheng.dong@nxp.com> > + */ > + > +#include <linux/clk-provider.h> > +#include <linux/err.h> > +#include <linux/io.h> > +#include <linux/slab.h> > + > +#include "clk-scu.h" > + > +struct clk_mux_gpr_scu { > + struct clk_hw hw; > + u32 rsrc_id; > + u8 gpr_id; > +}; > + > +#define to_clk_mux_gpr_scu(_hw) container_of(_hw, struct clk_mux_gpr_scu, hw) > + > +static u8 clk_mux_gpr_scu_get_parent(struct clk_hw *hw) > +{ > + struct clk_mux_gpr_scu *gpr_mux = to_clk_mux_gpr_scu(hw); > + u32 val = 0; > + int ret; > + > + ret = imx_sc_misc_get_control(ccm_ipc_handle, gpr_mux->rsrc_id, > + gpr_mux->gpr_id, &val); > + if (ret) { > + pr_err("%s: failed to get clock parent %d\n", > + clk_hw_get_name(hw), ret); > + return 0; > + } > + > + return (u8)val; Nitpick: Please drop explicit casts. > +} > + > +static int clk_mux_gpr_scu_set_parent(struct clk_hw *hw, u8 index) > +{ > + struct clk_mux_gpr_scu *gpr_mux = to_clk_mux_gpr_scu(hw); > + int ret; > + > + ret = imx_sc_misc_set_control(ccm_ipc_handle, gpr_mux->rsrc_id, > + gpr_mux->gpr_id, index); > + if (ret) > + pr_err("%s: failed to set clock parent %d\n", > + clk_hw_get_name(hw), ret); Nitpick: These printks are cluttering the code, any chance they can be removed and you can rely on callers to care if something failed? > + > + return ret; > +} > + > +static const struct clk_ops clk_mux_gpr_scu_ops = { > + .get_parent = clk_mux_gpr_scu_get_parent, > + .set_parent = clk_mux_gpr_scu_set_parent, > +}; > + > +struct clk_hw *clk_register_mux_gpr_scu(const char *name, const char * const *parents,
next prev parent reply other threads:[~2018-10-16 21:30 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-14 8:07 [PATCH V4 00/11] clk: imx: add imx8qxp clock support A.s. Dong 2018-10-14 8:07 ` A.s. Dong 2018-10-14 8:07 ` [PATCH V4 01/11] clk: imx: add configuration option for mmio clks A.s. Dong 2018-10-14 8:07 ` A.s. Dong 2018-10-14 8:07 ` [PATCH V4 02/11] clk: imx: scu: add scu clock common part A.s. Dong 2018-10-14 8:07 ` A.s. Dong 2018-10-16 21:31 ` Stephen Boyd 2018-10-16 21:31 ` Stephen Boyd 2018-10-17 9:11 ` A.s. Dong 2018-10-17 9:11 ` A.s. Dong 2018-10-17 15:07 ` Stephen Boyd 2018-10-17 15:07 ` Stephen Boyd 2018-10-17 15:27 ` A.s. Dong 2018-10-17 15:27 ` A.s. Dong 2018-10-14 8:07 ` [PATCH V4 03/11] clk: imx: scu: add scu clock divider A.s. Dong 2018-10-14 8:07 ` A.s. Dong 2018-10-16 21:26 ` Stephen Boyd 2018-10-16 21:26 ` Stephen Boyd 2018-10-17 8:56 ` A.s. Dong 2018-10-17 8:56 ` A.s. Dong 2018-10-17 15:17 ` Stephen Boyd 2018-10-17 15:17 ` Stephen Boyd 2018-10-17 15:45 ` A.s. Dong 2018-10-17 15:45 ` A.s. Dong 2018-10-17 16:05 ` Stephen Boyd 2018-10-17 16:05 ` Stephen Boyd 2018-10-18 2:35 ` A.s. Dong 2018-10-18 2:35 ` A.s. Dong 2018-10-14 8:07 ` [PATCH V4 04/11] clk: imx: scu: add scu clock gpr divider A.s. Dong 2018-10-14 8:07 ` A.s. Dong 2018-10-16 21:27 ` Stephen Boyd 2018-10-16 21:27 ` Stephen Boyd 2018-10-17 9:03 ` A.s. Dong 2018-10-17 9:03 ` A.s. Dong 2018-10-17 15:17 ` Stephen Boyd 2018-10-17 15:17 ` Stephen Boyd 2018-10-14 8:07 ` [PATCH V4 05/11] clk: imx: scu: add scu clock gate A.s. Dong 2018-10-14 8:07 ` A.s. Dong 2018-10-15 7:32 ` Sascha Hauer 2018-10-15 7:32 ` Sascha Hauer 2018-10-15 9:17 ` A.s. Dong 2018-10-15 9:17 ` A.s. Dong 2018-10-15 9:53 ` Sascha Hauer 2018-10-15 9:53 ` Sascha Hauer 2018-10-15 15:30 ` A.s. Dong 2018-10-15 15:30 ` A.s. Dong 2018-10-16 21:18 ` Stephen Boyd 2018-10-16 21:18 ` Stephen Boyd 2018-10-17 7:28 ` A.s. Dong 2018-10-17 7:28 ` A.s. Dong 2018-10-14 8:07 ` [PATCH V4 06/11] clk: imx: scu: add scu clock gpr gate A.s. Dong 2018-10-14 8:07 ` A.s. Dong 2018-10-14 8:08 ` [PATCH V4 07/11] clk: imx: scu: add scu clock mux A.s. Dong 2018-10-14 8:08 ` A.s. Dong 2018-10-14 8:08 ` [PATCH V4 08/11] clk: imx: scu: add scu clock gpr mux A.s. Dong 2018-10-14 8:08 ` A.s. Dong 2018-10-16 21:30 ` Stephen Boyd [this message] 2018-10-16 21:30 ` Stephen Boyd 2018-10-17 9:07 ` A.s. Dong 2018-10-17 9:07 ` A.s. Dong 2018-10-17 15:18 ` Stephen Boyd 2018-10-17 15:18 ` Stephen Boyd 2018-10-14 8:08 ` [PATCH V4 09/11] clk: imx: add common imx_clk_hw_fixed functions A.s. Dong 2018-10-14 8:08 ` A.s. Dong 2018-10-16 21:32 ` Stephen Boyd 2018-10-16 21:32 ` Stephen Boyd 2018-10-17 9:21 ` A.s. Dong 2018-10-17 9:21 ` A.s. Dong 2018-10-17 15:18 ` Stephen Boyd 2018-10-17 15:18 ` Stephen Boyd 2018-10-14 8:08 ` [PATCH V4 10/11] clk: imx: add imx_check_clk_hws helper function A.s. Dong 2018-10-14 8:08 ` A.s. Dong 2018-10-16 21:34 ` Stephen Boyd 2018-10-16 21:34 ` Stephen Boyd 2018-10-17 9:24 ` A.s. Dong 2018-10-17 9:24 ` A.s. Dong 2018-10-14 8:08 ` [PATCH V4 11/11] clk: imx: add imx8qxp clk driver A.s. Dong 2018-10-14 8:08 ` A.s. Dong 2018-10-16 21:38 ` Stephen Boyd 2018-10-16 21:38 ` Stephen Boyd 2018-10-17 9:43 ` A.s. Dong 2018-10-17 9:43 ` A.s. Dong 2018-10-17 15:20 ` Stephen Boyd 2018-10-17 15:20 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=153972544065.5275.2030080128764662219@swboyd.mtv.corp.google.com \ --to=sboyd@kernel.org \ --cc=aisheng.dong@nxp.com \ --cc=fabio.estevam@nxp.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=mturquette@baylibre.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.