All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Huang Shijie <b32955@freescale.com>,
	alan@linux.intel.com, B20596@freescale.com, B20223@freescale.com,
	gregkh@linuxfoundation.org, r58066@freescale.com,
	linux-serial@vger.kernel.org, shawn.guo@linaro.org,
	s.hauer@pengutronix.de
Subject: Re: [PATCH 1/2] serial/imx: add DMA support
Date: Fri, 27 Apr 2012 17:24:44 +0000	[thread overview]
Message-ID: <201204271724.45435.arnd@arndb.de> (raw)
In-Reply-To: <1335436632-29499-2-git-send-email-b32955@freescale.com>

On Thursday 26 April 2012, Huang Shijie wrote:
> diff --git a/Documentation/devicetree/bindings/tty/serial/fsl-imx-uart.txt b/Documentation/devicetree/bindings/tty/serial/fsl-imx-uart.txt
> index a9c0406..f27489d 100644
> --- a/Documentation/devicetree/bindings/tty/serial/fsl-imx-uart.txt
> +++ b/Documentation/devicetree/bindings/tty/serial/fsl-imx-uart.txt
> @@ -8,6 +8,10 @@ Required properties:
>  Optional properties:
>  - fsl,uart-has-rtscts : Indicate the uart has rts and cts
>  - fsl,irda-mode : Indicate the uart supports irda mode
> +- fsl,enable-dma : Indicate the uart supports DMA
> +- fsl,uart-dma-events : contains the DMA events for RX and TX,
> +                 The first is the RX event, while the other is TX.
> +- fsl,enable-dte: Indicate the uart works in DTE mode
>  

I think we should not add any ad-hoc DMA bindings for device drivers
until we have a proper generic binding for DMA.

	Arnd


WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] serial/imx: add DMA support
Date: Fri, 27 Apr 2012 17:24:44 +0000	[thread overview]
Message-ID: <201204271724.45435.arnd@arndb.de> (raw)
In-Reply-To: <1335436632-29499-2-git-send-email-b32955@freescale.com>

On Thursday 26 April 2012, Huang Shijie wrote:
> diff --git a/Documentation/devicetree/bindings/tty/serial/fsl-imx-uart.txt b/Documentation/devicetree/bindings/tty/serial/fsl-imx-uart.txt
> index a9c0406..f27489d 100644
> --- a/Documentation/devicetree/bindings/tty/serial/fsl-imx-uart.txt
> +++ b/Documentation/devicetree/bindings/tty/serial/fsl-imx-uart.txt
> @@ -8,6 +8,10 @@ Required properties:
>  Optional properties:
>  - fsl,uart-has-rtscts : Indicate the uart has rts and cts
>  - fsl,irda-mode : Indicate the uart supports irda mode
> +- fsl,enable-dma : Indicate the uart supports DMA
> +- fsl,uart-dma-events : contains the DMA events for RX and TX,
> +                 The first is the RX event, while the other is TX.
> +- fsl,enable-dte: Indicate the uart works in DTE mode
>  

I think we should not add any ad-hoc DMA bindings for device drivers
until we have a proper generic binding for DMA.

	Arnd

  parent reply	other threads:[~2012-04-27 20:15 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-26 10:37 [PATCH 0/2] add DMA support to uart Huang Shijie
2012-04-26 10:37 ` Huang Shijie
2012-04-26 10:37 ` [PATCH 1/2] serial/imx: add DMA support Huang Shijie
2012-04-26 10:37   ` Huang Shijie
2012-04-26 11:11   ` Russell King - ARM Linux
2012-04-26 11:11     ` Russell King - ARM Linux
2012-04-27  7:00     ` Huang Shijie
2012-04-27  7:00       ` Huang Shijie
2012-04-27  8:22       ` Russell King - ARM Linux
2012-04-27  8:22         ` Russell King - ARM Linux
2012-04-27  8:38         ` Richard Zhao
2012-04-27  8:38           ` Richard Zhao
2012-04-27  9:46         ` Huang Shijie
2012-04-27  9:46           ` Huang Shijie
2012-04-27  9:50           ` Russell King - ARM Linux
2012-04-27  9:50             ` Russell King - ARM Linux
2012-04-27 15:18             ` Huang Shijie
2012-04-27 15:18               ` Huang Shijie
2012-04-27 15:30               ` Russell King - ARM Linux
2012-04-27 15:30                 ` Russell King - ARM Linux
2012-04-28  8:53                 ` Huang Shijie
2012-04-28  8:53                   ` Huang Shijie
2012-04-26 12:00   ` Sascha Hauer
2012-04-26 12:00     ` Sascha Hauer
2012-04-27  6:09     ` Huang Shijie
2012-04-27  6:09       ` Huang Shijie
2012-05-16  9:37       ` Philippe Rétornaz
2012-05-16  9:37         ` Philippe Rétornaz
2012-05-16  9:42         ` Huang Shijie
2012-05-16  9:42           ` Huang Shijie
2012-04-27 17:24   ` Arnd Bergmann [this message]
2012-04-27 17:24     ` Arnd Bergmann
2012-04-28  8:54     ` Huang Shijie
2012-04-28  8:54       ` Huang Shijie
2012-04-26 10:37 ` [PATCH 2/2] ARM: MX6q: enable DMA support for UART2 Huang Shijie
2012-04-26 10:37   ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204271724.45435.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=B20223@freescale.com \
    --cc=B20596@freescale.com \
    --cc=alan@linux.intel.com \
    --cc=b32955@freescale.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=r58066@freescale.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.