From: Huang Shijie <b32955@freescale.com> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: alan@linux.intel.com, linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org, B20223@freescale.com, r58066@freescale.com, B20596@freescale.com Subject: Re: [PATCH 1/2] serial/imx: add DMA support Date: Fri, 27 Apr 2012 14:09:53 +0800 [thread overview] Message-ID: <4F9A3831.1020203@freescale.com> (raw) In-Reply-To: <20120426120043.GH17184@pengutronix.de> Hi, >> +/* see the "i.MX61 SDMA Scripts User Manual.doc" for the parameters */ > I can't see how the manual helps here. sorry, the comment is in the wrong place. it should placed at configuring the `slave_config`. > Please test this patch at least on one more SoC. There should be nothing > i.MX6 specific in here, the fact that the i.MX6 is mentioned several > times in the comments make me suspicious. There are bugs in the UART DMA code in the firmware before the imx6q. So we can not test the UART DMA except the imx6q arm2 board. thanks Huang Shijie
WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] serial/imx: add DMA support Date: Fri, 27 Apr 2012 14:09:53 +0800 [thread overview] Message-ID: <4F9A3831.1020203@freescale.com> (raw) In-Reply-To: <20120426120043.GH17184@pengutronix.de> Hi, >> +/* see the "i.MX61 SDMA Scripts User Manual.doc" for the parameters */ > I can't see how the manual helps here. sorry, the comment is in the wrong place. it should placed at configuring the `slave_config`. > Please test this patch at least on one more SoC. There should be nothing > i.MX6 specific in here, the fact that the i.MX6 is mentioned several > times in the comments make me suspicious. There are bugs in the UART DMA code in the firmware before the imx6q. So we can not test the UART DMA except the imx6q arm2 board. thanks Huang Shijie
next prev parent reply other threads:[~2012-04-27 6:06 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-04-26 10:37 [PATCH 0/2] add DMA support to uart Huang Shijie 2012-04-26 10:37 ` Huang Shijie 2012-04-26 10:37 ` [PATCH 1/2] serial/imx: add DMA support Huang Shijie 2012-04-26 10:37 ` Huang Shijie 2012-04-26 11:11 ` Russell King - ARM Linux 2012-04-26 11:11 ` Russell King - ARM Linux 2012-04-27 7:00 ` Huang Shijie 2012-04-27 7:00 ` Huang Shijie 2012-04-27 8:22 ` Russell King - ARM Linux 2012-04-27 8:22 ` Russell King - ARM Linux 2012-04-27 8:38 ` Richard Zhao 2012-04-27 8:38 ` Richard Zhao 2012-04-27 9:46 ` Huang Shijie 2012-04-27 9:46 ` Huang Shijie 2012-04-27 9:50 ` Russell King - ARM Linux 2012-04-27 9:50 ` Russell King - ARM Linux 2012-04-27 15:18 ` Huang Shijie 2012-04-27 15:18 ` Huang Shijie 2012-04-27 15:30 ` Russell King - ARM Linux 2012-04-27 15:30 ` Russell King - ARM Linux 2012-04-28 8:53 ` Huang Shijie 2012-04-28 8:53 ` Huang Shijie 2012-04-26 12:00 ` Sascha Hauer 2012-04-26 12:00 ` Sascha Hauer 2012-04-27 6:09 ` Huang Shijie [this message] 2012-04-27 6:09 ` Huang Shijie 2012-05-16 9:37 ` Philippe Rétornaz 2012-05-16 9:37 ` Philippe Rétornaz 2012-05-16 9:42 ` Huang Shijie 2012-05-16 9:42 ` Huang Shijie 2012-04-27 17:24 ` Arnd Bergmann 2012-04-27 17:24 ` Arnd Bergmann 2012-04-28 8:54 ` Huang Shijie 2012-04-28 8:54 ` Huang Shijie 2012-04-26 10:37 ` [PATCH 2/2] ARM: MX6q: enable DMA support for UART2 Huang Shijie 2012-04-26 10:37 ` Huang Shijie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4F9A3831.1020203@freescale.com \ --to=b32955@freescale.com \ --cc=B20223@freescale.com \ --cc=B20596@freescale.com \ --cc=alan@linux.intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-serial@vger.kernel.org \ --cc=r58066@freescale.com \ --cc=s.hauer@pengutronix.de \ --cc=shawn.guo@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.