From: Tony Lindgren <tony@atomide.com> To: Rajendra Nayak <rnayak@ti.com> Cc: Kevin Hilman <khilman@linaro.org>, balbi@ti.com, "Bedia, Vaibhav" <vaibhav.bedia@ti.com>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Mark Jackson <mpfj-list@newflow.co.uk>, Sourav Poddar <sourav.poddar@ti.com>, Paul Walmsley <paul@pwsan.com> Subject: Re: Boot hang regression 3.10.0-rc4 -> 3.10.0 Date: Wed, 10 Jul 2013 23:24:41 -0700 [thread overview] Message-ID: <20130711062440.GY5523@atomide.com> (raw) In-Reply-To: <51DE4E3F.6030503@ti.com> * Rajendra Nayak <rnayak@ti.com> [130710 23:25]: > On Wednesday 10 July 2013 07:56 PM, Tony Lindgren wrote: > > > > Felipe is right, looks like all we need is to check if context is > > initialized or not. So no need for mach-omap2/serial.c or hwmod tinkering. > > > > After that having DEBUG_LL and cmdline with earlyprintk console=ttyO.. > > works for me. > > On what platform? Like I said there are flags set statically in hmwod > data for OMAP4 and OMAP5, which make it work without any hwmod tinkering > in mach-omap2/serial.c. But it won't work for am33xx. For me omap4 sdp hangs during ttyO2 probe if earlyprintk is enabled for that port and console is enabled for that port. That's because we attempt to restore uninitialized context. It's possible that we have more than one bug here though. > > @@ -1523,6 +1524,8 @@ static int serial_omap_probe(struct platform_device *pdev) > > > > pm_runtime_mark_last_busy(up->dev); > > pm_runtime_put_autosuspend(up->dev); > > + up->initialized = true; > > This won't help as the context save for serial happens as part of set_termios() and not > when the device is probed. The issue is that in serial probe we currently restore NULL context to the port which kills earlyprintk output until set_termios() is called. But as discussed, there are better ways for fixing this issue. Regards, Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren) To: linux-arm-kernel@lists.infradead.org Subject: Boot hang regression 3.10.0-rc4 -> 3.10.0 Date: Wed, 10 Jul 2013 23:24:41 -0700 [thread overview] Message-ID: <20130711062440.GY5523@atomide.com> (raw) In-Reply-To: <51DE4E3F.6030503@ti.com> * Rajendra Nayak <rnayak@ti.com> [130710 23:25]: > On Wednesday 10 July 2013 07:56 PM, Tony Lindgren wrote: > > > > Felipe is right, looks like all we need is to check if context is > > initialized or not. So no need for mach-omap2/serial.c or hwmod tinkering. > > > > After that having DEBUG_LL and cmdline with earlyprintk console=ttyO.. > > works for me. > > On what platform? Like I said there are flags set statically in hmwod > data for OMAP4 and OMAP5, which make it work without any hwmod tinkering > in mach-omap2/serial.c. But it won't work for am33xx. For me omap4 sdp hangs during ttyO2 probe if earlyprintk is enabled for that port and console is enabled for that port. That's because we attempt to restore uninitialized context. It's possible that we have more than one bug here though. > > @@ -1523,6 +1524,8 @@ static int serial_omap_probe(struct platform_device *pdev) > > > > pm_runtime_mark_last_busy(up->dev); > > pm_runtime_put_autosuspend(up->dev); > > + up->initialized = true; > > This won't help as the context save for serial happens as part of set_termios() and not > when the device is probed. The issue is that in serial probe we currently restore NULL context to the port which kills earlyprintk output until set_termios() is called. But as discussed, there are better ways for fixing this issue. Regards, Tony
next prev parent reply other threads:[~2013-07-11 6:24 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-04 13:25 Boot hang regression 3.10.0-rc4 -> 3.10.0 Mark Jackson 2013-07-04 13:25 ` Mark Jackson 2013-07-04 15:14 ` Mark Jackson 2013-07-04 15:14 ` Mark Jackson 2013-07-04 16:00 ` Mark Jackson 2013-07-04 16:00 ` Mark Jackson 2013-07-05 8:11 ` Bedia, Vaibhav 2013-07-05 8:11 ` Bedia, Vaibhav 2013-07-05 11:59 ` Tony Lindgren 2013-07-05 11:59 ` Tony Lindgren 2013-07-05 13:20 ` Bedia, Vaibhav 2013-07-05 13:20 ` Bedia, Vaibhav 2013-07-05 13:31 ` Bedia, Vaibhav 2013-07-05 13:31 ` Bedia, Vaibhav 2013-07-08 11:25 ` Tony Lindgren 2013-07-08 11:25 ` Tony Lindgren 2013-07-08 12:16 ` Tony Lindgren 2013-07-08 12:16 ` Tony Lindgren 2013-07-08 12:41 ` Rajendra Nayak 2013-07-08 12:41 ` Rajendra Nayak 2013-07-08 13:10 ` Tony Lindgren 2013-07-08 13:10 ` Tony Lindgren 2013-07-08 13:20 ` Rajendra Nayak 2013-07-08 13:20 ` Rajendra Nayak 2013-07-08 13:25 ` Rajendra Nayak 2013-07-08 13:25 ` Rajendra Nayak 2013-07-08 13:35 ` Felipe Balbi 2013-07-08 13:35 ` Felipe Balbi 2013-07-09 5:33 ` Rajendra Nayak 2013-07-09 5:33 ` Rajendra Nayak 2013-07-09 6:42 ` Felipe Balbi 2013-07-09 6:42 ` Felipe Balbi 2013-07-09 7:19 ` Rajendra Nayak 2013-07-09 7:19 ` Rajendra Nayak 2013-07-09 7:40 ` Felipe Balbi 2013-07-09 7:40 ` Felipe Balbi 2013-07-09 18:59 ` Grygorii Strashko 2013-07-09 18:59 ` Grygorii Strashko 2013-07-09 19:41 ` Felipe Balbi 2013-07-09 19:41 ` Felipe Balbi 2013-07-10 12:16 ` Grygorii Strashko 2013-07-10 12:16 ` Grygorii Strashko 2013-07-10 12:25 ` Felipe Balbi 2013-07-10 12:25 ` Felipe Balbi 2013-07-10 8:22 ` Kevin Hilman 2013-07-10 8:22 ` Kevin Hilman 2013-07-10 12:10 ` Tony Lindgren 2013-07-10 12:10 ` Tony Lindgren 2013-07-10 12:27 ` Tony Lindgren 2013-07-10 12:27 ` Tony Lindgren 2013-07-10 14:26 ` Tony Lindgren 2013-07-10 14:26 ` Tony Lindgren 2013-07-10 16:07 ` Felipe Balbi 2013-07-10 16:07 ` Felipe Balbi 2013-07-10 16:11 ` Felipe Balbi 2013-07-10 16:11 ` Felipe Balbi 2013-07-11 6:32 ` Tony Lindgren 2013-07-11 6:32 ` Tony Lindgren 2013-07-11 9:59 ` Grygorii Strashko 2013-07-11 9:59 ` Grygorii Strashko 2013-07-12 0:40 ` Suman Anna 2013-07-12 0:40 ` Suman Anna 2013-07-15 6:44 ` Rajendra Nayak 2013-07-15 6:44 ` Rajendra Nayak 2013-07-15 10:01 ` Rajendra Nayak 2013-07-15 10:01 ` Rajendra Nayak 2013-07-15 19:23 ` Suman Anna 2013-07-15 19:23 ` Suman Anna 2013-07-16 6:30 ` Rajendra Nayak 2013-07-16 6:30 ` Rajendra Nayak 2013-07-11 9:17 ` Rajendra Nayak 2013-07-11 9:17 ` Rajendra Nayak 2013-07-11 9:26 ` Felipe Balbi 2013-07-11 9:26 ` Felipe Balbi 2013-07-11 10:16 ` [PATCH] arm: omap2plus: unidle devices which are about to probe Felipe Balbi 2013-07-11 10:16 ` Felipe Balbi 2013-07-12 11:58 ` Grygorii Strashko 2013-07-12 11:58 ` Grygorii Strashko 2013-07-12 12:10 ` Felipe Balbi 2013-07-12 12:10 ` Felipe Balbi 2013-07-12 12:27 ` Rajendra Nayak 2013-07-12 12:27 ` Rajendra Nayak 2013-07-13 22:21 ` Kevin Hilman 2013-07-13 22:21 ` Kevin Hilman 2013-07-11 9:59 ` Boot hang regression 3.10.0-rc4 -> 3.10.0 Grygorii Strashko 2013-07-11 9:59 ` Grygorii Strashko 2013-07-16 10:27 ` Grygorii Strashko 2013-07-16 10:27 ` Grygorii Strashko 2013-07-17 7:10 ` Rajendra Nayak 2013-07-17 7:10 ` Rajendra Nayak 2013-07-11 6:18 ` Rajendra Nayak 2013-07-11 6:18 ` Rajendra Nayak 2013-07-11 6:24 ` Tony Lindgren [this message] 2013-07-11 6:24 ` Tony Lindgren 2013-07-11 9:11 ` Rajendra Nayak 2013-07-11 9:11 ` Rajendra Nayak
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130711062440.GY5523@atomide.com \ --to=tony@atomide.com \ --cc=balbi@ti.com \ --cc=khilman@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=mpfj-list@newflow.co.uk \ --cc=paul@pwsan.com \ --cc=rnayak@ti.com \ --cc=sourav.poddar@ti.com \ --cc=vaibhav.bedia@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.