From: Rob Herring <robh@kernel.org> To: Jerome Brunet <jbrunet@baylibre.com> Cc: Neil Armstrong <narmstrong@baylibre.com>, Carlo Caione <carlo@caione.org>, Kevin Hilman <khilman@baylibre.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] clk: meson: axg: document bindings for the audio clock controller Date: Tue, 1 May 2018 09:37:15 -0500 [thread overview] Message-ID: <20180501143715.GA20023@rob-hp-laptop> (raw) In-Reply-To: <20180425163304.10852-7-jbrunet@baylibre.com> On Wed, Apr 25, 2018 at 06:33:03PM +0200, Jerome Brunet wrote: > Add documentation for the device tree bindings of the audio clock > controller of the A113 based SoCs > The preferred subject prefix for bindings is 'dt/bindings: clock: ...' > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > --- > .../bindings/clock/amlogic,axg-audio-clkc.txt | 56 ++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.txt > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.txt > new file mode 100644 > index 000000000000..1b989ceda567 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.txt > @@ -0,0 +1,56 @@ > +* Amlogic AXG Audio Clock Controllers > + > +The Amlogic AXG audio clock controller generates and supplies clock to the > +other elements of the audio subsystem, such as fifos, i2s, spdif and pdm > +devices. > + > +Required Properties: > + > +- compatible : should be "amlogic,axg-audio-clkc" for the A113X and A113D > +- reg : physical base address of the clock controller and length of > + memory mapped region. > +- clocks : a list of phandle + clock-specifier pairs for the clocks listed > + in clock-names. > +- clock-names : must contain the following: > + * "pclk" - Main peripheral bus clock > + may contain the following: > + * "mst_in[0-7]" - 8 input plls to generate clock signals Unless the sources don't exist, then you should always have the clocks. It should not be based on whether you are using them or not. > + * "slv_sclk[0-9]" - 10 slave bit clocks provided by external > + components. > + * "slv_lrclk[0-9]" - 10 slave sample clocks provided by external > + components. I'm guessing these may come from pins that aren't connected, so being optional is fine. > +- reset : phandle of the internal reset line resets > +- #clock-cells : should be 1. > + > +Each clock is assigned an identifier and client nodes can use this identifier > +to specify the clock which they consume. All available clocks are defined as > +preprocessor macros in the dt-bindings/clock/axg-audio-clkc.h header and can be > +used in device tree sources. > + > +Example: > + > +clkc_audio: clock-controller { Needs a unit address. > + compatible = "amlogic,axg-audio-clkc"; > + reg = <0x0 0x0 0x0 0xb4>; > + #clock-cells = <1>; > + > + clocks = <&clkc CLKID_AUDIO>, > + <&clkc CLKID_MPLL0>, > + <&clkc CLKID_MPLL1>, > + <&clkc CLKID_MPLL2>, > + <&clkc CLKID_MPLL3>, > + <&clkc CLKID_HIFI_PLL>, > + <&clkc CLKID_FCLK_DIV3>, > + <&clkc CLKID_FCLK_DIV4>, > + <&clkc CLKID_GP0_PLL>; > + clock-names = "pclk", > + "mst_in0", > + "mst_in1", > + "mst_in2", > + "mst_in3", > + "mst_in4", > + "mst_in5", > + "mst_in6", > + "mst_in7"; > + resets = <&reset RESET_AUDIO>; > +}; > -- > 2.14.3 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linus-amlogic@lists.infradead.org Subject: [PATCH 6/7] clk: meson: axg: document bindings for the audio clock controller Date: Tue, 1 May 2018 09:37:15 -0500 [thread overview] Message-ID: <20180501143715.GA20023@rob-hp-laptop> (raw) In-Reply-To: <20180425163304.10852-7-jbrunet@baylibre.com> On Wed, Apr 25, 2018 at 06:33:03PM +0200, Jerome Brunet wrote: > Add documentation for the device tree bindings of the audio clock > controller of the A113 based SoCs > The preferred subject prefix for bindings is 'dt/bindings: clock: ...' > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > --- > .../bindings/clock/amlogic,axg-audio-clkc.txt | 56 ++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.txt > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.txt > new file mode 100644 > index 000000000000..1b989ceda567 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.txt > @@ -0,0 +1,56 @@ > +* Amlogic AXG Audio Clock Controllers > + > +The Amlogic AXG audio clock controller generates and supplies clock to the > +other elements of the audio subsystem, such as fifos, i2s, spdif and pdm > +devices. > + > +Required Properties: > + > +- compatible : should be "amlogic,axg-audio-clkc" for the A113X and A113D > +- reg : physical base address of the clock controller and length of > + memory mapped region. > +- clocks : a list of phandle + clock-specifier pairs for the clocks listed > + in clock-names. > +- clock-names : must contain the following: > + * "pclk" - Main peripheral bus clock > + may contain the following: > + * "mst_in[0-7]" - 8 input plls to generate clock signals Unless the sources don't exist, then you should always have the clocks. It should not be based on whether you are using them or not. > + * "slv_sclk[0-9]" - 10 slave bit clocks provided by external > + components. > + * "slv_lrclk[0-9]" - 10 slave sample clocks provided by external > + components. I'm guessing these may come from pins that aren't connected, so being optional is fine. > +- reset : phandle of the internal reset line resets > +- #clock-cells : should be 1. > + > +Each clock is assigned an identifier and client nodes can use this identifier > +to specify the clock which they consume. All available clocks are defined as > +preprocessor macros in the dt-bindings/clock/axg-audio-clkc.h header and can be > +used in device tree sources. > + > +Example: > + > +clkc_audio: clock-controller { Needs a unit address. > + compatible = "amlogic,axg-audio-clkc"; > + reg = <0x0 0x0 0x0 0xb4>; > + #clock-cells = <1>; > + > + clocks = <&clkc CLKID_AUDIO>, > + <&clkc CLKID_MPLL0>, > + <&clkc CLKID_MPLL1>, > + <&clkc CLKID_MPLL2>, > + <&clkc CLKID_MPLL3>, > + <&clkc CLKID_HIFI_PLL>, > + <&clkc CLKID_FCLK_DIV3>, > + <&clkc CLKID_FCLK_DIV4>, > + <&clkc CLKID_GP0_PLL>; > + clock-names = "pclk", > + "mst_in0", > + "mst_in1", > + "mst_in2", > + "mst_in3", > + "mst_in4", > + "mst_in5", > + "mst_in6", > + "mst_in7"; > + resets = <&reset RESET_AUDIO>; > +}; > -- > 2.14.3 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-01 14:37 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-25 16:32 [PATCH 0/7] clk: meson: axg: add audio clock controller support Jerome Brunet 2018-04-25 16:32 ` Jerome Brunet 2018-04-25 16:32 ` [PATCH 1/7] clk: meson: clean-up meson clock configuration Jerome Brunet 2018-04-25 16:32 ` Jerome Brunet 2018-04-26 8:46 ` Neil Armstrong 2018-04-26 8:46 ` Neil Armstrong 2018-04-25 16:32 ` [PATCH 2/7] clk: meson: add clk-phase clock driver Jerome Brunet 2018-04-25 16:32 ` Jerome Brunet 2018-04-26 8:46 ` Neil Armstrong 2018-04-26 8:46 ` Neil Armstrong 2018-04-25 16:33 ` [PATCH 3/7] clk: meson: add triple phase " Jerome Brunet 2018-04-25 16:33 ` Jerome Brunet 2018-04-26 8:47 ` Neil Armstrong 2018-04-26 8:47 ` Neil Armstrong 2018-04-26 8:50 ` Neil Armstrong 2018-04-26 8:50 ` Neil Armstrong 2018-04-25 16:33 ` [PATCH 4/7] clk: meson: add axg audio sclk divider driver Jerome Brunet 2018-04-25 16:33 ` Jerome Brunet 2018-04-26 8:47 ` Neil Armstrong 2018-04-26 8:47 ` Neil Armstrong 2018-04-25 16:33 ` [PATCH 5/7] clk: meson: axg: export audio clock controller id bindings Jerome Brunet 2018-04-25 16:33 ` Jerome Brunet 2018-04-26 8:48 ` Neil Armstrong 2018-04-26 8:48 ` Neil Armstrong 2018-05-01 14:31 ` Rob Herring 2018-05-01 14:31 ` Rob Herring 2018-04-25 16:33 ` [PATCH 6/7] clk: meson: axg: document bindings for the audio clock controller Jerome Brunet 2018-04-25 16:33 ` Jerome Brunet 2018-05-01 14:37 ` Rob Herring [this message] 2018-05-01 14:37 ` Rob Herring 2018-05-14 14:16 ` Jerome Brunet 2018-05-14 14:16 ` Jerome Brunet 2018-05-14 14:16 ` Jerome Brunet 2018-04-25 16:33 ` [PATCH 7/7] clk: meson: axg: add the audio clock controller driver Jerome Brunet 2018-04-25 16:33 ` Jerome Brunet 2018-04-26 8:49 ` Neil Armstrong 2018-04-26 8:49 ` Neil Armstrong 2018-05-15 23:41 ` Stephen Boyd 2018-05-15 23:41 ` Stephen Boyd 2018-05-15 23:41 ` Stephen Boyd 2018-04-27 1:13 ` kbuild test robot 2018-04-27 1:13 ` kbuild test robot 2018-04-27 1:13 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180501143715.GA20023@rob-hp-laptop \ --to=robh@kernel.org \ --cc=carlo@caione.org \ --cc=devicetree@vger.kernel.org \ --cc=jbrunet@baylibre.com \ --cc=khilman@baylibre.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=narmstrong@baylibre.com \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.