From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Nayna Jain <nayna@linux.ibm.com> Cc: linuxppc-dev@ozlabs.org, linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Jeremy Kerr <jk@ozlabs.org>, Matthew Garret <matthew.garret@nebula.com>, Mimi Zohar <zohar@linux.ibm.com>, Claudio Carvalho <cclaudio@linux.ibm.com>, George Wilson <gcwilson@linux.ibm.com>, Elaine Palmer <erpalmer@us.ibm.com>, Eric Ricther <erichte@linux.ibm.com>, Oliver O'Halloran <oohall@gmail.com> Subject: Re: [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs Date: Mon, 26 Aug 2019 16:56:49 +0200 [thread overview] Message-ID: <20190826145649.GA27342@kroah.com> (raw) In-Reply-To: <1566825818-9731-3-git-send-email-nayna@linux.ibm.com> On Mon, Aug 26, 2019 at 09:23:36AM -0400, Nayna Jain wrote: > +static struct kobj_attribute size_attr = __ATTR_RO(size); Wait, why not just normal ATTR_RO()? > +static struct bin_attribute data_attr = __BIN_ATTR_RO(data, VARIABLE_MAX_SIZE); And BIN_ATTR_RO() here? Do those not work for you somehow? thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Nayna Jain <nayna@linux.ibm.com> Cc: linux-efi@vger.kernel.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Eric Ricther <erichte@linux.ibm.com>, linux-kernel@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>, Claudio Carvalho <cclaudio@linux.ibm.com>, Matthew Garret <matthew.garret@nebula.com>, linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>, Jeremy Kerr <jk@ozlabs.org>, Elaine Palmer <erpalmer@us.ibm.com>, Oliver O'Halloran <oohall@gmail.com>, linux-integrity@vger.kernel.org, George Wilson <gcwilson@linux.ibm.com> Subject: Re: [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs Date: Mon, 26 Aug 2019 16:56:49 +0200 [thread overview] Message-ID: <20190826145649.GA27342@kroah.com> (raw) In-Reply-To: <1566825818-9731-3-git-send-email-nayna@linux.ibm.com> On Mon, Aug 26, 2019 at 09:23:36AM -0400, Nayna Jain wrote: > +static struct kobj_attribute size_attr = __ATTR_RO(size); Wait, why not just normal ATTR_RO()? > +static struct bin_attribute data_attr = __BIN_ATTR_RO(data, VARIABLE_MAX_SIZE); And BIN_ATTR_RO() here? Do those not work for you somehow? thanks, greg k-h
next prev parent reply other threads:[~2019-08-26 14:56 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-26 13:23 [PATCH v3 0/4] powerpc: expose secure variables to the kernel and userspace Nayna Jain 2019-08-26 13:23 ` Nayna Jain 2019-08-26 13:23 ` [PATCH v3 1/4] powerpc/powernv: Add OPAL API interface to access secure variable Nayna Jain 2019-08-26 13:23 ` Nayna Jain 2019-08-26 13:23 ` [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs Nayna Jain 2019-08-26 13:23 ` Nayna Jain 2019-08-26 14:01 ` Greg Kroah-Hartman 2019-08-26 14:01 ` Greg Kroah-Hartman 2019-08-26 14:12 ` Nayna 2019-08-26 14:12 ` Nayna 2019-08-26 15:01 ` [PATCH] sysfs: add BIN_ATTR_WO() macro Greg Kroah-Hartman 2019-08-26 15:01 ` Greg Kroah-Hartman 2019-09-03 3:37 ` Michael Ellerman 2019-09-03 3:37 ` Michael Ellerman 2019-09-04 11:36 ` Greg Kroah-Hartman 2019-09-04 11:36 ` Greg Kroah-Hartman 2019-10-01 18:08 ` Nayna 2019-10-01 18:16 ` Greg Kroah-Hartman 2019-10-01 18:55 ` Nayna 2019-08-26 14:56 ` Greg Kroah-Hartman [this message] 2019-08-26 14:56 ` [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs Greg Kroah-Hartman 2019-08-26 15:46 ` Nayna 2019-08-26 15:46 ` Nayna 2019-08-26 15:57 ` Greg Kroah-Hartman 2019-08-26 15:57 ` Greg Kroah-Hartman 2019-08-26 13:23 ` [PATCH v3 3/4] x86/efi: move common keyring handler functions to new file Nayna Jain 2019-08-26 13:23 ` Nayna Jain 2019-09-02 11:55 ` Michael Ellerman 2019-09-02 11:55 ` Michael Ellerman 2019-09-03 22:51 ` Mimi Zohar 2019-09-03 22:51 ` Mimi Zohar 2019-09-05 3:59 ` Michael Ellerman 2019-09-05 3:59 ` Michael Ellerman 2019-08-26 13:23 ` [PATCH v3 4/4] powerpc: load firmware trusted keys/hashes into kernel keyring Nayna Jain 2019-08-26 13:23 ` Nayna Jain 2019-09-03 22:54 ` Mimi Zohar 2019-09-03 22:54 ` Mimi Zohar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190826145649.GA27342@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=ard.biesheuvel@linaro.org \ --cc=benh@kernel.crashing.org \ --cc=cclaudio@linux.ibm.com \ --cc=erichte@linux.ibm.com \ --cc=erpalmer@us.ibm.com \ --cc=gcwilson@linux.ibm.com \ --cc=jk@ozlabs.org \ --cc=linux-efi@vger.kernel.org \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@ozlabs.org \ --cc=matthew.garret@nebula.com \ --cc=mpe@ellerman.id.au \ --cc=nayna@linux.ibm.com \ --cc=oohall@gmail.com \ --cc=paulus@samba.org \ --cc=zohar@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.