* [PATCH v2 0/3] arm64: dts: add FlexCAN support to LS1028A and sl28
@ 2020-10-01 9:11 ` Michael Walle
0 siblings, 0 replies; 14+ messages in thread
From: Michael Walle @ 2020-10-01 9:11 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel, linux-can
Cc: Joakim Zhang, Li Yang, Oleksij Rempel, Michael Walle,
Rob Herring, Marc Kleine-Budde, Shawn Guo
Now that FlexCAN support for newer IPs is finally hitting upstream [1],
lets add the corresponding nodes for the LS1028A SoC and enable it for the
Kontron sl28 board.
changes since v1:
- added new patch "dt-bindings: can: flexcan: list supported processors"
Suggested by Lee.
Please keep in mind that this only an intermediate step, as Marc already
pointed out [2] that Oleksij is alreay working on converting the
bindings to YAML format.
[1] https://lore.kernel.org/netdev/20200923085418.2685858-1-mkl@pengutronix.de/
[2] https://lore.kernel.org/linux-can/790ce102-7542-b65e-0945-a04faf6e4b89@pengutronix.de/
Michael Walle (3):
dt-bindings: can: flexcan: list supported processors
arm64: dts: ls1028a: add missing CAN nodes
arm64: dts: freescale: sl28: add CAN node
.../bindings/net/can/fsl-flexcan.txt | 6 ++++++
.../dts/freescale/fsl-ls1028a-kontron-sl28.dts | 4 ++++
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 ++++++++++++++++++
3 files changed, 28 insertions(+)
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 1/3] dt-bindings: can: flexcan: list supported processors
2020-10-01 9:11 ` Michael Walle
@ 2020-10-01 9:11 ` Michael Walle
-1 siblings, 0 replies; 14+ messages in thread
From: Michael Walle @ 2020-10-01 9:11 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel, linux-can
Cc: Shawn Guo, Li Yang, Rob Herring, Marc Kleine-Budde, Joakim Zhang,
Oleksij Rempel, Michael Walle
The compatible is a pattern match. Explicitly list all possible values.
Also mention that the ls1028ar1 must be followed by lx2160ar1.
Signed-off-by: Michael Walle <michael@walle.cc>
---
Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
index 94c0f8bf4deb..c6152dc2d2d0 100644
--- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
+++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
@@ -4,6 +4,12 @@ Required properties:
- compatible : Should be "fsl,<processor>-flexcan"
+ where <processor> is imx8qm, imx6q, imx28, imx53, imx35, imx25, p1010,
+ vf610, ls1021ar2, lx2160ar1, ls1028ar1.
+
+ The ls1028ar1 must be followed by lx2160ar1, e.g.
+ - "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan"
+
An implementation should also claim any of the following compatibles
that it is fully backwards compatible with:
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 1/3] dt-bindings: can: flexcan: list supported processors
@ 2020-10-01 9:11 ` Michael Walle
0 siblings, 0 replies; 14+ messages in thread
From: Michael Walle @ 2020-10-01 9:11 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel, linux-can
Cc: Joakim Zhang, Li Yang, Oleksij Rempel, Michael Walle,
Rob Herring, Marc Kleine-Budde, Shawn Guo
The compatible is a pattern match. Explicitly list all possible values.
Also mention that the ls1028ar1 must be followed by lx2160ar1.
Signed-off-by: Michael Walle <michael@walle.cc>
---
Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
index 94c0f8bf4deb..c6152dc2d2d0 100644
--- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
+++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
@@ -4,6 +4,12 @@ Required properties:
- compatible : Should be "fsl,<processor>-flexcan"
+ where <processor> is imx8qm, imx6q, imx28, imx53, imx35, imx25, p1010,
+ vf610, ls1021ar2, lx2160ar1, ls1028ar1.
+
+ The ls1028ar1 must be followed by lx2160ar1, e.g.
+ - "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan"
+
An implementation should also claim any of the following compatibles
that it is fully backwards compatible with:
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: can: flexcan: list supported processors
2020-10-01 9:11 ` Michael Walle
@ 2020-10-06 19:25 ` Marc Kleine-Budde
-1 siblings, 0 replies; 14+ messages in thread
From: Marc Kleine-Budde @ 2020-10-06 19:25 UTC (permalink / raw)
To: Michael Walle, linux-arm-kernel, devicetree, linux-kernel, linux-can
Cc: Shawn Guo, Li Yang, Rob Herring, Joakim Zhang, Oleksij Rempel
[-- Attachment #1.1: Type: text/plain, Size: 1530 bytes --]
On 10/1/20 11:11 AM, Michael Walle wrote:
> The compatible is a pattern match. Explicitly list all possible values.
> Also mention that the ls1028ar1 must be followed by lx2160ar1.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index 94c0f8bf4deb..c6152dc2d2d0 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -4,6 +4,12 @@ Required properties:
>
> - compatible : Should be "fsl,<processor>-flexcan"
>
> + where <processor> is imx8qm, imx6q, imx28, imx53, imx35, imx25, p1010,
> + vf610, ls1021ar2, lx2160ar1, ls1028ar1.
> +
> + The ls1028ar1 must be followed by lx2160ar1, e.g.
> + - "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan"
> +
> An implementation should also claim any of the following compatibles
> that it is fully backwards compatible with:
>
>
Added this patch to linux-can-next. The others should probably go via the arm
SoC tree.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: can: flexcan: list supported processors
@ 2020-10-06 19:25 ` Marc Kleine-Budde
0 siblings, 0 replies; 14+ messages in thread
From: Marc Kleine-Budde @ 2020-10-06 19:25 UTC (permalink / raw)
To: Michael Walle, linux-arm-kernel, devicetree, linux-kernel, linux-can
Cc: Oleksij Rempel, Rob Herring, Shawn Guo, Joakim Zhang, Li Yang
[-- Attachment #1.1.1: Type: text/plain, Size: 1530 bytes --]
On 10/1/20 11:11 AM, Michael Walle wrote:
> The compatible is a pattern match. Explicitly list all possible values.
> Also mention that the ls1028ar1 must be followed by lx2160ar1.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index 94c0f8bf4deb..c6152dc2d2d0 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -4,6 +4,12 @@ Required properties:
>
> - compatible : Should be "fsl,<processor>-flexcan"
>
> + where <processor> is imx8qm, imx6q, imx28, imx53, imx35, imx25, p1010,
> + vf610, ls1021ar2, lx2160ar1, ls1028ar1.
> +
> + The ls1028ar1 must be followed by lx2160ar1, e.g.
> + - "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan"
> +
> An implementation should also claim any of the following compatibles
> that it is fully backwards compatible with:
>
>
Added this patch to linux-can-next. The others should probably go via the arm
SoC tree.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/3] arm64: dts: ls1028a: add missing CAN nodes
2020-10-01 9:11 ` Michael Walle
@ 2020-10-01 9:11 ` Michael Walle
-1 siblings, 0 replies; 14+ messages in thread
From: Michael Walle @ 2020-10-01 9:11 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel, linux-can
Cc: Shawn Guo, Li Yang, Rob Herring, Marc Kleine-Budde, Joakim Zhang,
Oleksij Rempel, Michael Walle
The LS1028A has two FlexCAN controller. These are compatible with
the ones from the LX2160A. Add the nodes.
The first controller was tested on the Kontron sl28 board.
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 73e4f9466887..f223396b8266 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -386,6 +386,24 @@
status = "disabled";
};
+ can0: can@2180000 {
+ compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan";
+ reg = <0x0 0x2180000 0x0 0x10000>;
+ interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&sysclk>, <&clockgen 4 1>;
+ clock-names = "ipg", "per";
+ status = "disabled";
+ };
+
+ can1: can@2190000 {
+ compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan";
+ reg = <0x0 0x2190000 0x0 0x10000>;
+ interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&sysclk>, <&clockgen 4 1>;
+ clock-names = "ipg", "per";
+ status = "disabled";
+ };
+
duart0: serial@21c0500 {
compatible = "fsl,ns16550", "ns16550a";
reg = <0x00 0x21c0500 0x0 0x100>;
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/3] arm64: dts: ls1028a: add missing CAN nodes
@ 2020-10-01 9:11 ` Michael Walle
0 siblings, 0 replies; 14+ messages in thread
From: Michael Walle @ 2020-10-01 9:11 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel, linux-can
Cc: Joakim Zhang, Li Yang, Oleksij Rempel, Michael Walle,
Rob Herring, Marc Kleine-Budde, Shawn Guo
The LS1028A has two FlexCAN controller. These are compatible with
the ones from the LX2160A. Add the nodes.
The first controller was tested on the Kontron sl28 board.
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 73e4f9466887..f223396b8266 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -386,6 +386,24 @@
status = "disabled";
};
+ can0: can@2180000 {
+ compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan";
+ reg = <0x0 0x2180000 0x0 0x10000>;
+ interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&sysclk>, <&clockgen 4 1>;
+ clock-names = "ipg", "per";
+ status = "disabled";
+ };
+
+ can1: can@2190000 {
+ compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan";
+ reg = <0x0 0x2190000 0x0 0x10000>;
+ interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&sysclk>, <&clockgen 4 1>;
+ clock-names = "ipg", "per";
+ status = "disabled";
+ };
+
duart0: serial@21c0500 {
compatible = "fsl,ns16550", "ns16550a";
reg = <0x00 0x21c0500 0x0 0x100>;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/3] arm64: dts: ls1028a: add missing CAN nodes
2020-10-01 9:11 ` Michael Walle
@ 2020-10-28 9:06 ` Shawn Guo
-1 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2020-10-28 9:06 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-can, Li Yang,
Rob Herring, Marc Kleine-Budde, Joakim Zhang, Oleksij Rempel
On Thu, Oct 01, 2020 at 11:11:30AM +0200, Michael Walle wrote:
> The LS1028A has two FlexCAN controller. These are compatible with
> the ones from the LX2160A. Add the nodes.
>
> The first controller was tested on the Kontron sl28 board.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/3] arm64: dts: ls1028a: add missing CAN nodes
@ 2020-10-28 9:06 ` Shawn Guo
0 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2020-10-28 9:06 UTC (permalink / raw)
To: Michael Walle
Cc: devicetree, Joakim Zhang, linux-kernel, Li Yang, Oleksij Rempel,
Rob Herring, Marc Kleine-Budde, linux-can, linux-arm-kernel
On Thu, Oct 01, 2020 at 11:11:30AM +0200, Michael Walle wrote:
> The LS1028A has two FlexCAN controller. These are compatible with
> the ones from the LX2160A. Add the nodes.
>
> The first controller was tested on the Kontron sl28 board.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 3/3] arm64: dts: freescale: sl28: add CAN node
2020-10-01 9:11 ` Michael Walle
@ 2020-10-01 9:11 ` Michael Walle
-1 siblings, 0 replies; 14+ messages in thread
From: Michael Walle @ 2020-10-01 9:11 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel, linux-can
Cc: Shawn Guo, Li Yang, Rob Herring, Marc Kleine-Budde, Joakim Zhang,
Oleksij Rempel, Michael Walle
The module supports one CAN controller. Enable it.
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index f46eb47cfa4d..17a2f5dacc3f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -60,6 +60,10 @@
};
};
+&can0 {
+ status = "okay";
+};
+
&dspi2 {
status = "okay";
};
--
2.20.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 3/3] arm64: dts: freescale: sl28: add CAN node
@ 2020-10-01 9:11 ` Michael Walle
0 siblings, 0 replies; 14+ messages in thread
From: Michael Walle @ 2020-10-01 9:11 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel, linux-can
Cc: Joakim Zhang, Li Yang, Oleksij Rempel, Michael Walle,
Rob Herring, Marc Kleine-Budde, Shawn Guo
The module supports one CAN controller. Enable it.
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index f46eb47cfa4d..17a2f5dacc3f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -60,6 +60,10 @@
};
};
+&can0 {
+ status = "okay";
+};
+
&dspi2 {
status = "okay";
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: freescale: sl28: add CAN node
2020-10-01 9:11 ` Michael Walle
@ 2020-10-28 9:06 ` Shawn Guo
-1 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2020-10-28 9:06 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-can, Li Yang,
Rob Herring, Marc Kleine-Budde, Joakim Zhang, Oleksij Rempel
On Thu, Oct 01, 2020 at 11:11:31AM +0200, Michael Walle wrote:
> The module supports one CAN controller. Enable it.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: freescale: sl28: add CAN node
@ 2020-10-28 9:06 ` Shawn Guo
0 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2020-10-28 9:06 UTC (permalink / raw)
To: Michael Walle
Cc: devicetree, Joakim Zhang, linux-kernel, Li Yang, Oleksij Rempel,
Rob Herring, Marc Kleine-Budde, linux-can, linux-arm-kernel
On Thu, Oct 01, 2020 at 11:11:31AM +0200, Michael Walle wrote:
> The module supports one CAN controller. Enable it.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread