All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <p.yadav@ti.com>
To: Zhengxun Li <zhengxunli@mxic.com.tw>
Cc: <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>,
	<tudor.ambarus@microchip.com>, <miquel.raynal@bootlin.com>,
	<broonie@kernel.org>, <jaimeliao@mxic.com.tw>
Subject: Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support
Date: Mon, 17 May 2021 21:36:30 +0530	[thread overview]
Message-ID: <20210517160628.s65h6prjt5mw6bud@ti.com> (raw)
In-Reply-To: <1621232088-12567-3-git-send-email-zhengxunli@mxic.com.tw>

On 17/05/21 02:14PM, Zhengxun Li wrote:
> Driver patch for octal DTR mode support.
> 
> Owing to the spi_mem_default_supports_op() is not support dtr
> operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr

I don't like the "Based on Pratyush patch". Please mention the commit 
hash so it is much easier to find later. For example, saying based on 
commit 539cf68cd51b (spi: spi-mem: add spi_mem_dtr_supports_op(), 
2021-02-04) is much better.

But while we are on this topic, I don't think it is needed all that 
much. People use pre-existing APIs all the time. I don't see any need to 
specifically point it out.  So I think saying "Call 
spi_mem_dtr_supports_op() to ..." is better.

> _supports_op()" add spi_mem_dtr_supports_op() to support dtr and
> keep checking the buswidth and command bytes.
> 
> Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw>
> ---

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.

WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <p.yadav@ti.com>
To: Zhengxun Li <zhengxunli@mxic.com.tw>
Cc: <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>,
	<tudor.ambarus@microchip.com>, <miquel.raynal@bootlin.com>,
	<broonie@kernel.org>, <jaimeliao@mxic.com.tw>
Subject: Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support
Date: Mon, 17 May 2021 21:36:30 +0530	[thread overview]
Message-ID: <20210517160628.s65h6prjt5mw6bud@ti.com> (raw)
In-Reply-To: <1621232088-12567-3-git-send-email-zhengxunli@mxic.com.tw>

On 17/05/21 02:14PM, Zhengxun Li wrote:
> Driver patch for octal DTR mode support.
> 
> Owing to the spi_mem_default_supports_op() is not support dtr
> operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr

I don't like the "Based on Pratyush patch". Please mention the commit 
hash so it is much easier to find later. For example, saying based on 
commit 539cf68cd51b (spi: spi-mem: add spi_mem_dtr_supports_op(), 
2021-02-04) is much better.

But while we are on this topic, I don't think it is needed all that 
much. People use pre-existing APIs all the time. I don't see any need to 
specifically point it out.  So I think saying "Call 
spi_mem_dtr_supports_op() to ..." is better.

> _supports_op()" add spi_mem_dtr_supports_op() to support dtr and
> keep checking the buswidth and command bytes.
> 
> Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw>
> ---

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2021-05-17 16:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  6:14 [PATCH v5 0/2] Add octal DTR support for Macronix flash Zhengxun Li
2021-05-17  6:14 ` Zhengxun Li
2021-05-17  6:14 ` [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash Zhengxun Li
2021-05-17  6:14   ` Zhengxun Li
2021-05-17  7:33   ` Pratyush Yadav
2021-05-17  7:33     ` Pratyush Yadav
2021-06-29  2:06     ` zhengxunli
2021-06-29  2:06       ` zhengxunli
2021-06-29  6:37   ` Tudor.Ambarus
2021-06-29  6:37     ` Tudor.Ambarus
2021-06-29  9:33     ` zhengxunli
2021-06-29  9:33       ` zhengxunli
2021-06-30  9:03     ` zhengxunli
2021-06-30  9:03       ` zhengxunli
2021-05-17  6:14 ` [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support Zhengxun Li
2021-05-17  6:14   ` Zhengxun Li
2021-05-17 15:49   ` Mark Brown
2021-05-17 15:49     ` Mark Brown
2021-05-17 16:06   ` Pratyush Yadav [this message]
2021-05-17 16:06     ` Pratyush Yadav
2021-05-18  2:47     ` zhengxunli
2021-05-18  2:47       ` zhengxunli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210517160628.s65h6prjt5mw6bud@ti.com \
    --to=p.yadav@ti.com \
    --cc=broonie@kernel.org \
    --cc=jaimeliao@mxic.com.tw \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=tudor.ambarus@microchip.com \
    --cc=zhengxunli@mxic.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.